)]}'
{"oneview_client/client.py":[{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"06446b072cbff95a8ec33707e63338db9e1e779e","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        except requests.RequestException as e:"},{"line_number":137,"context_line":"            raise exceptions.OneViewConnectionError(e.message)"},{"line_number":138,"context_line":"        else:"},{"line_number":139,"context_line":"            if versions.get(\"minimumVersion\") is None:"},{"line_number":140,"context_line":"                raise exceptions.OneViewNotAuthorizedException()"},{"line_number":141,"context_line":"            return versions"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_f5e2bfd3","line":139,"updated":"2016-07-21 19:49:43.000000000","message":"Shouldn\u0027t this check for a 401 or 403 response status instead? There certainly are many other possibilities why it would lack an expected field in the response body and not be a NotAuthorized case.","commit_id":"71fc14da2c5982b36f0e87f96458ae4cd5335a8e"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"023bc6a2a1d7524c8a4e59a964bd547a210b594f","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        except requests.RequestException as e:"},{"line_number":137,"context_line":"            raise exceptions.OneViewConnectionError(e.message)"},{"line_number":138,"context_line":"        else:"},{"line_number":139,"context_line":"            if versions.get(\"minimumVersion\") is None:"},{"line_number":140,"context_line":"                raise exceptions.OneViewNotAuthorizedException()"},{"line_number":141,"context_line":"            return versions"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_3202b20a","line":139,"range":{"start_line":139,"start_character":12,"end_line":139,"end_character":54},"updated":"2016-07-21 17:36:48.000000000","message":"Yes, there is space for improvement here but I think this approach is mistaken. Any json without the key \"minimumVersion\" would trigger OneViewNotAuthorizedException, that creates a very similar problem that is happening today.","commit_id":"71fc14da2c5982b36f0e87f96458ae4cd5335a8e"},{"author":{"_account_id":10369,"name":"lokesh s","email":"slokesh184@gmail.com","username":"loki"},"change_message_id":"0fa93c528fd2f917f10cbc2e772387ebc9c92f17","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        except requests.RequestException as e:"},{"line_number":137,"context_line":"            raise exceptions.OneViewConnectionError(e.message)"},{"line_number":138,"context_line":"        else:"},{"line_number":139,"context_line":"            if versions.get(\"minimumVersion\") is None:"},{"line_number":140,"context_line":"                raise exceptions.OneViewNotAuthorizedException()"},{"line_number":141,"context_line":"            return versions"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_eb5ac029","line":139,"in_reply_to":"dada55a8_f5e2bfd3","updated":"2016-07-22 10:15:19.000000000","message":"There are lot of error codes like forbidden, malformed, bad request etc., to be checked upon it needs equivalent exceptions to be created and raised. Why not check if json has a key \"errorcode\" and raise generic exception showing the error message as we get from json key \"details\"(Why error) and \"recommendedactions\" (What to be done to resolve).","commit_id":"71fc14da2c5982b36f0e87f96458ae4cd5335a8e"},{"author":{"_account_id":10369,"name":"lokesh s","email":"slokesh184@gmail.com","username":"loki"},"change_message_id":"0bda64ba23e60c8115ec25d5fb81a70eb029f68d","unresolved":false,"context_lines":[{"line_number":670,"context_line":"            \"OneView appliance returned an unknown response status: %s\""},{"line_number":671,"context_line":"            % status"},{"line_number":672,"context_line":"        )"},{"line_number":673,"context_line":"        raise exceptions.UnknowOneViewResponseError(message)"},{"line_number":674,"context_line":"    return repeat"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_41e274a0","line":673,"range":{"start_line":673,"start_character":52,"end_line":673,"end_character":59},"updated":"2016-07-29 06:55:03.000000000","message":"This message can also be taken from \nerror_code \u003d response.json().get(\u0027details\u0027).\nThis should be fine for now.","commit_id":"8c976721cac606ec4d841ab225a2b59e1452f6b3"}]}
