)]}'
{"valenceclient/client.py":[{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"6a4a2f742efc9c899af35694794e0a3bea7e3b8d","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_utils import importutils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from valenceclient.common.http import DEFAULT_VERSION"},{"line_number":19,"context_line":"from valenceclient import exc"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_13d35162","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":53},"updated":"2017-05-22 04:57:53.000000000","message":"should not import variables, only modules should be imported according to pep8.\n\nOr how about moving all the constants to diff file, constants.py, but its your call.","commit_id":"a9f4f5d96829ad02891317c3592e4e8941f5f6b5"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"6a4a2f742efc9c899af35694794e0a3bea7e3b8d","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    if valence_url is None:"},{"line_number":26,"context_line":"        raise exc.InvalidValenceUrl"},{"line_number":27,"context_line":"    valence_api_version \u003d valence_api_version if valence_api_version \\"},{"line_number":28,"context_line":"        else DEFAULT_VERSION"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    kwargs \u003d {"},{"line_number":31,"context_line":"        \u0027valence_url\u0027: valence_url,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_7393ada4","line":28,"range":{"start_line":27,"start_character":3,"end_line":28,"end_character":28},"updated":"2017-05-22 04:57:53.000000000","message":"api_version \u003d api_version or DEFAULT_VERSION  should do?","commit_id":"a9f4f5d96829ad02891317c3592e4e8941f5f6b5"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"6a4a2f742efc9c899af35694794e0a3bea7e3b8d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        else DEFAULT_VERSION"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    kwargs \u003d {"},{"line_number":31,"context_line":"        \u0027valence_url\u0027: valence_url,"},{"line_number":32,"context_line":"        \u0027valence_api_version\u0027: valence_api_version,"},{"line_number":33,"context_line":"        \u0027max_retries\u0027: max_retries,"},{"line_number":34,"context_line":"        \u0027retry_interval\u0027: retry_interval"},{"line_number":35,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_93af61e2","line":32,"range":{"start_line":31,"start_character":1,"end_line":32,"end_character":51},"updated":"2017-05-22 04:57:53.000000000","message":"as its for valence only , i think we dont need to prefix with valence here. url, api_version would be good here?","commit_id":"a9f4f5d96829ad02891317c3592e4e8941f5f6b5"}]}
