)]}'
{"valenceclient/common/http.py":[{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"e10f6dafe368f85e7c82bcb4c1c082c96534efa6","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        Wrapper around request.Session.request to handle tasks such as"},{"line_number":132,"context_line":"        setting headers and error handling."},{"line_number":133,"context_line":"        \"\"\""},{"line_number":134,"context_line":"        headers \u003d {}"},{"line_number":135,"context_line":"        headers \u003d copy.deepcopy(kwargs.get(\u0027headers\u0027, {}))"},{"line_number":136,"context_line":"        headers.setdefault(\u0027User-agent\u0027, USER_AGENT)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_eea974dd","line":134,"updated":"2017-09-01 00:02:56.000000000","message":"Why assign headers here just to reassign it in the next line? Is there something I\u0027m missing?","commit_id":"960c0cf0d6e478a350d08352246117bd3c468fff"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"9de98e67672df994ee8ab2b52a801591cb49741c","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        Wrapper around request.Session.request to handle tasks such as"},{"line_number":132,"context_line":"        setting headers and error handling."},{"line_number":133,"context_line":"        \"\"\""},{"line_number":134,"context_line":"        headers \u003d {}"},{"line_number":135,"context_line":"        headers \u003d copy.deepcopy(kwargs.get(\u0027headers\u0027, {}))"},{"line_number":136,"context_line":"        headers.setdefault(\u0027User-agent\u0027, USER_AGENT)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_7f50900b","line":134,"in_reply_to":"7f287b81_eea974dd","updated":"2017-09-01 04:08:57.000000000","message":"actually, I want to pass headers separately, in session.request, and all other arguments separately in json argument as in L143-144. As log_curl_request expects in kwargs, I\u0027m just removing the headers part after log_curl_request. But now I think about it, variable can be assigned after pop itself. Will update. Thanks","commit_id":"960c0cf0d6e478a350d08352246117bd3c468fff"}],"valenceclient/osc/v1/podmanager.py":[{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"e10f6dafe368f85e7c82bcb4c1c082c96534efa6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7f287b81_eed7344f","updated":"2017-09-01 00:02:56.000000000","message":"I think rather than have classes for each action, we should have a pod manager class that contains all of these actions. Here\u0027s an example of how another project does it https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v1/volumes.py\n\nIn that example, and other clients, the parser and the options are all added in a file shell.py that contains all of the commands and make calls to files like this one to perform the actions.","commit_id":"960c0cf0d6e478a350d08352246117bd3c468fff"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"9de98e67672df994ee8ab2b52a801591cb49741c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7f287b81_df48a45d","in_reply_to":"7f287b81_eed7344f","updated":"2017-09-01 04:08:57.000000000","message":"But I think for osc client, it is expected in the below format I think. I checked the cinderclient as you pointed out, it doesn\u0027t use osc_lib, that is the implementation of normal cinder client i think.\n\nI checked the clients that use osc, its in the same format as below. https://github.com/openstack/python-rsdclient/blob/master/rsdclient/osc/v1/node.py\n\nand also checked the neutronclient, its in the similar way.","commit_id":"960c0cf0d6e478a350d08352246117bd3c468fff"}]}