)]}'
{"ranger_tempest_plugin/services/rms_client.py":[{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"acef4fb90054a93bbc6fd3768ddd5deaab1406fb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"class RmsClient(base_client.RangerClientBase):\r"},{"line_number":29,"context_line":"\r"},{"line_number":30,"context_line":"    rms_url \u003d CONF.ranger.RANGER_RMS_BASE_URL\r"},{"line_number":31,"context_line":"    if CONF.identity.uri_v3 is not None:\r"},{"line_number":32,"context_line":"        identity_url \u003d CONF.identity.uri_v3.strip(\u0027v3\u0027)\r"},{"line_number":33,"context_line":"    version \u003d \"v2\"\r"},{"line_number":34,"context_line":"\r"},{"line_number":35,"context_line":"    def create_region(self, region_id, **kwargs):\r"}],"source_content_type":"text/x-python","patch_set":21,"id":"7faddb67_2424d5ae","line":32,"range":{"start_line":31,"start_character":4,"end_line":32,"end_character":55},"updated":"2019-07-31 14:29:32.000000000","message":"If CONF.identity.uri_v3 is really None, then it seems identity_url will never be defined in RmsClient.","commit_id":"8e6877541290bde12e197347606f7bae43269a57"},{"author":{"_account_id":29585,"name":"Jeremy Houser","email":"jeremyhouser@protonmail.com","username":"jh629g"},"change_message_id":"23101af93561efbd23661fceef414704ea4f82eb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"class RmsClient(base_client.RangerClientBase):\r"},{"line_number":29,"context_line":"\r"},{"line_number":30,"context_line":"    rms_url \u003d CONF.ranger.RANGER_RMS_BASE_URL\r"},{"line_number":31,"context_line":"    if CONF.identity.uri_v3 is not None:\r"},{"line_number":32,"context_line":"        identity_url \u003d CONF.identity.uri_v3.strip(\u0027v3\u0027)\r"},{"line_number":33,"context_line":"    version \u003d \"v2\"\r"},{"line_number":34,"context_line":"\r"},{"line_number":35,"context_line":"    def create_region(self, region_id, **kwargs):\r"}],"source_content_type":"text/x-python","patch_set":21,"id":"7faddb67_e41f9d05","line":32,"range":{"start_line":31,"start_character":4,"end_line":32,"end_character":55},"in_reply_to":"7faddb67_2424d5ae","updated":"2019-07-31 15:37:44.000000000","message":"Correct. I will more than likely replace this statement with identity_url \u003d CONF.identity.uri_v3 or \"\"\nidentity_url \u003d identity_url.strip(\u0027/v3\u0027) which wont fail on an empty string, but will fail on a nonetype object.","commit_id":"8e6877541290bde12e197347606f7bae43269a57"}],"tempest_setup/tempest.conf":[{"author":{"_account_id":19391,"name":"Chi Lo","email":"cl566n@att.com","username":"cl566n"},"change_message_id":"acef4fb90054a93bbc6fd3768ddd5deaab1406fb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"debug \u003d true"},{"line_number":3,"context_line":"log_file \u003d tempest.log"},{"line_number":4,"context_line":"log_dir \u003d /var/log/tempest.conf"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[auth]"},{"line_number":7,"context_line":"test_accounts_file \u003d /opt/stack/tempest/etc/accounts.yaml"}],"source_content_type":"text/plain","patch_set":21,"id":"7faddb67_c441413b","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":31},"updated":"2019-07-31 14:29:32.000000000","message":"is this correct?  log_dir is used to specify the full path config file but not the log directory?","commit_id":"8e6877541290bde12e197347606f7bae43269a57"},{"author":{"_account_id":29585,"name":"Jeremy Houser","email":"jeremyhouser@protonmail.com","username":"jh629g"},"change_message_id":"23101af93561efbd23661fceef414704ea4f82eb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"debug \u003d true"},{"line_number":3,"context_line":"log_file \u003d tempest.log"},{"line_number":4,"context_line":"log_dir \u003d /var/log/tempest.conf"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[auth]"},{"line_number":7,"context_line":"test_accounts_file \u003d /opt/stack/tempest/etc/accounts.yaml"}],"source_content_type":"text/plain","patch_set":21,"id":"7faddb67_c4f941c8","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":31},"in_reply_to":"7faddb67_c441413b","updated":"2019-07-31 15:37:44.000000000","message":"This is what it was before. I accidentally removed this value. As far as I know, this is the default value.","commit_id":"8e6877541290bde12e197347606f7bae43269a57"}]}