)]}'
{"cmd/stackube-controller/stackube-controller.go":[{"author":{"_account_id":11138,"name":"Pengfei Ni","email":"feiskyer@gmail.com","username":"feisky"},"change_message_id":"54f047d299db374c088b8178ffba54ae40f0e821","unresolved":false,"context_lines":[{"line_number":130,"context_line":"}"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"func main() {"},{"line_number":133,"context_line":"\tutil.InitFlags(version)"},{"line_number":134,"context_line":"\tutil.InitLogs()"},{"line_number":135,"context_line":"\tdefer util.FlushLogs()"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-go","patch_set":1,"id":"7f287b81_e4893aca","line":133,"updated":"2017-08-25 06:13:56.000000000","message":"I think it\u0027s better to not touching the InitFlags logic. Instead, check whether version is set or not before initializing kubernetes clients, e.g.\n\nif *version {\n      print version.VERSION\n      exit 0\n}","commit_id":"c62d8b5d15ce01dcd7a2e58ea219d5f7c336ccf9"}],"cmd/stackube-proxy/stackube-proxy.go":[{"author":{"_account_id":11138,"name":"Pengfei Ni","email":"feiskyer@gmail.com","username":"feisky"},"change_message_id":"761d7326bf89ecbcb32c79a92a01c6cf0b5e3608","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"\t\"k8s.io/apimachinery/pkg/util/wait\""},{"line_number":29,"context_line":"\t\"k8s.io/client-go/kubernetes\""},{"line_number":30,"context_line":"\t\"os\""},{"line_number":31,"context_line":")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"var ("}],"source_content_type":"text/x-go","patch_set":4,"id":"7f287b81_c7387d3e","line":30,"updated":"2017-08-25 09:24:08.000000000","message":"nit: move \"os\" to first group","commit_id":"3eda49669c1fa00144fd6499c031bc1b50d63b60"}]}