)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"4dfc9846548e899004eaa8de4f567febf15ad3da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"058d0b56_ffb6ee9a","updated":"2023-10-05 18:08:53.000000000","message":"This change passed gates since requirements.txt wasn\u0027t mentioned and processed in tox.ini.\nWhen we include it like here [1], scapy module isn\u0027t found [2], so we need to fix it, maybe this dependency needs to be used in an earlier stage using the .spec file (distgit).\nFeel free to tackle this, I will be able to check it out next week since Sunday.\n\n[1]\nhttps://review.opendev.org/c/x/whitebox-neutron-tempest-plugin/+/892136\n\n[2]\nhttps://zuul.opendev.org/t/openstack/build/e720c2faaa8e4ab48030cd1b011262c4\n\"ModuleNotFoundError: No module named \u0027scapy\u0027\"","commit_id":"c2eb89025912f5a896002e93d65e7b5bfded4bd0"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"17e2ac491800fff044fddd9b25e97d841311f5e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bf223b76_fdef7946","updated":"2023-09-20 12:22:30.000000000","message":"lgtm, also tested that no issues when running downstream dvr and mtu tests on a multinode environment. Just noticed a mismatch in options group name","commit_id":"c2eb89025912f5a896002e93d65e7b5bfded4bd0"}],"whitebox_neutron_tempest_plugin/common/tcpdump_capture.py":[{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"e94638a94322e3ce707136cf640eb85cf27356da","unresolved":true,"context_lines":[{"line_number":131,"context_line":"                    else:"},{"line_number":132,"context_line":"                        break"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        return merged_cap_file"}],"source_content_type":"text/x-python","patch_set":2,"id":"f94f062a_0fc79576","line":134,"updated":"2023-09-18 14:24:28.000000000","message":"I noticed this change comparing to the original d/s version:\n\n-        ssh_channel \u003d self.client.open_session()\n-        ssh_channel.exec_command(\u0027sudo cat \u0027 + merged_cap_file)\n-        self.addCleanup(ssh_channel.close)\n-        return ssh_channel.makefile()\n\nFYI, I tried to run a test that uses this code on a d/s multinode environment and there were FileNotFoundError failures since capture files were not found. After I restored this snippet of d/s code the test worked.","commit_id":"5a3dc289cea9e0ec4d897fbc0c6032f2f12f1ba5"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"93ba9a35cc390e125a2ac14ed487794bbb068696","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                    else:"},{"line_number":132,"context_line":"                        break"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        return merged_cap_file"}],"source_content_type":"text/x-python","patch_set":2,"id":"18effa54_be37a03f","line":134,"in_reply_to":"16ef9ed5_1aebcc56","updated":"2023-09-19 13:19:37.000000000","message":"Yeah I see now, I added missing code snippet.","commit_id":"5a3dc289cea9e0ec4d897fbc0c6032f2f12f1ba5"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"20918065bd45216c6f48a35cce3d72ab0e03702b","unresolved":true,"context_lines":[{"line_number":131,"context_line":"                    else:"},{"line_number":132,"context_line":"                        break"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        return merged_cap_file"}],"source_content_type":"text/x-python","patch_set":2,"id":"16ef9ed5_1aebcc56","line":134,"in_reply_to":"6793b776_b72d2014","updated":"2023-09-19 10:36:08.000000000","message":"Yes, I think we should include this code as well. Otherwise, when running on OSP (d/s openstack) the test complains that a capture file in not found. IIUC, this code lets tempest to read capture files from remote nodes.","commit_id":"5a3dc289cea9e0ec4d897fbc0c6032f2f12f1ba5"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"773cd7cc35b4c9735bcf4d61db5fa92e950e347a","unresolved":true,"context_lines":[{"line_number":131,"context_line":"                    else:"},{"line_number":132,"context_line":"                        break"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        return merged_cap_file"}],"source_content_type":"text/x-python","patch_set":2,"id":"6793b776_b72d2014","line":134,"in_reply_to":"f94f062a_0fc79576","updated":"2023-09-19 08:33:44.000000000","message":"Oh, maybe I misunderstood meaning of it, but in the documentation to ssh.Channel i found that makefile returns file-like object and rdpcap from scapy requires just file name instead of dpkt pcap reader which requires file object.\n\nSo do you think I should return this snippet to patch?","commit_id":"5a3dc289cea9e0ec4d897fbc0c6032f2f12f1ba5"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"17e2ac491800fff044fddd9b25e97d841311f5e3","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        self.client \u003d client"},{"line_number":36,"context_line":"        self.interfaces \u003d [ifc.strip() for ifc in interfaces.split(\u0027,\u0027)]"},{"line_number":37,"context_line":"        self.filter_str \u003d filter_str"},{"line_number":38,"context_line":"        self.timeout \u003d CONF.whitebox_options.capture_timeout"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _setUp(self):"},{"line_number":41,"context_line":"        self.start()"}],"source_content_type":"text/x-python","patch_set":3,"id":"30af6cc0_041011ad","line":38,"updated":"2023-09-20 12:22:30.000000000","message":"according to the current state of the repo the options group have name whitebox_neutron_plugin_options","commit_id":"c2eb89025912f5a896002e93d65e7b5bfded4bd0"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"34078e10bcafb1f8d932b70cc90e62474b5236ed","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        self.client \u003d client"},{"line_number":36,"context_line":"        self.interfaces \u003d [ifc.strip() for ifc in interfaces.split(\u0027,\u0027)]"},{"line_number":37,"context_line":"        self.filter_str \u003d filter_str"},{"line_number":38,"context_line":"        self.timeout \u003d CONF.whitebox_options.capture_timeout"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _setUp(self):"},{"line_number":41,"context_line":"        self.start()"}],"source_content_type":"text/x-python","patch_set":3,"id":"cb6e809c_991ddbec","line":38,"in_reply_to":"0d81420e_7099b917","updated":"2023-10-04 12:36:19.000000000","message":"This option doesn\u0027t exist yet, only after patch 892136 it will exist like that under section whitebox_options.\n\nOn the other hand we also need the scapy fix for same patch 892136 to pass gates.\n\nThis will not cause any failures yet, since no test instantiate TcpdumpCapture class yet.\n\nSo IMO lets merge this patch as it is, and get patch 892136 reviewed and merged soon too, then we can continue with other changes after both merged.\n\nwdyt?","commit_id":"c2eb89025912f5a896002e93d65e7b5bfded4bd0"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"9ab5b5dc548a1d4fa0412b4ad755b19e156f234b","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        self.client \u003d client"},{"line_number":36,"context_line":"        self.interfaces \u003d [ifc.strip() for ifc in interfaces.split(\u0027,\u0027)]"},{"line_number":37,"context_line":"        self.filter_str \u003d filter_str"},{"line_number":38,"context_line":"        self.timeout \u003d CONF.whitebox_options.capture_timeout"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _setUp(self):"},{"line_number":41,"context_line":"        self.start()"}],"source_content_type":"text/x-python","patch_set":3,"id":"0d81420e_7099b917","line":38,"in_reply_to":"30af6cc0_041011ad","updated":"2023-10-04 10:07:06.000000000","message":"Yeah, I\u0027ll leave it as it is now and rename it after this patch - https://review.opendev.org/c/x/whitebox-neutron-tempest-plugin/+/892136/17/whitebox_neutron_tempest_plugin/config.py#26 is merged","commit_id":"c2eb89025912f5a896002e93d65e7b5bfded4bd0"}]}