)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"646c4912d0019e75c495906905689d735a6d9ce9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"84969c42_4acd801d","updated":"2024-03-18 14:01:43.000000000","message":"Passed on ovn devstack deployed on local machine, ready for review","commit_id":"c5800d4dd59f602160c271de34564067f9fde465"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"fe4c20640c1ea83c12b8ce400cafbb874a48b056","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"df3b9a01_dcee67d6","updated":"2024-03-18 14:14:54.000000000","message":"lgtm, the test was skipped during gate job due to console_output True. Maybe it\u0027s ok to have the test skipped on devstack gates since it can cause \u0027No valid host\u0027 issues when running in parallel with other tests. I\u0027ll tested it already on podified and it works well","commit_id":"c5800d4dd59f602160c271de34564067f9fde465"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"7b2f96ba270f0c8a233f80785206d669258996b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ebe97a20_da473e92","in_reply_to":"0fca0492_bae7f8bd","updated":"2024-03-18 14:33:09.000000000","message":"ack, I will set that condition back.","commit_id":"c5800d4dd59f602160c271de34564067f9fde465"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"665c45b0f3f95ade6f356b6623c5d7b022bf8ad0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"8626ad1b_10355e8b","in_reply_to":"0fca0492_bae7f8bd","updated":"2024-03-18 14:32:39.000000000","message":"it\u0027s ok to set console_output to False for the whole job. IIRC there are no tests in this plugin that will be affected. This will also allow multicast tests to run much faster (3 vms will be spawned in parallel instead of one by one) without affecting the results.","commit_id":"c5800d4dd59f602160c271de34564067f9fde465"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"cdf1e7ab8d935f50c2acc3b7180f61685392867f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"0fca0492_bae7f8bd","in_reply_to":"63d83088_bc5b0f11","updated":"2024-03-18 14:30:24.000000000","message":"test can be run with console_output\u003dTrue but VMs are spawned slower and there are much less chances that the issue that this test was designed to cover will be reproduced.","commit_id":"c5800d4dd59f602160c271de34564067f9fde465"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"3c4fa86adfe4c50a155046814bd15d0431d308cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"7172fd37_b0ead51b","in_reply_to":"6eeee950_bc4987ca","updated":"2024-03-18 14:40:16.000000000","message":"this code was needed for downstream jobs in the past where we had advanced image the default","commit_id":"c5800d4dd59f602160c271de34564067f9fde465"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"ca8f7cf5e0cb8bd8f03d738159639f4b5fba1f2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f00b3e73_cd79c826","in_reply_to":"7172fd37_b0ead51b","updated":"2024-03-18 14:44:25.000000000","message":"there can be also a disadvantage of dinabling console_output that the many_vms test will run (it spawns all the VMs on the same host IIRC) and can cause sporadic \u0027No valid host found\u0027 issues","commit_id":"c5800d4dd59f602160c271de34564067f9fde465"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"48eea1491fd02de56813beb3511c44e10ac27476","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"194465b3_09088382","in_reply_to":"73fd7c3f_a931b7d6","updated":"2024-03-18 14:40:15.000000000","message":"\u003e sorry, IMO we can omit this code since we do not plan to have default image advanced. So there is enough that main image is centos\n\nack, I agree +1.","commit_id":"c5800d4dd59f602160c271de34564067f9fde465"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"d89e9850062ecae98512273207bb89a0bf9b2a5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"6eeee950_bc4987ca","in_reply_to":"bdd89918_91f10e41","updated":"2024-03-18 14:37:47.000000000","message":"sorry, IMO we can omit this code since we do not plan to have default image advanced. So there is enough that main image is centos","commit_id":"c5800d4dd59f602160c271de34564067f9fde465"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"3cccc15b21be35b573d0b80fb510309db9ad55b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"63d83088_bc5b0f11","in_reply_to":"df3b9a01_dcee67d6","updated":"2024-03-18 14:27:21.000000000","message":"it also worked for me so far on ovn devstack deployed on ubuntu vm, we did reduce the tenant VMs amount a lot when comparing to original conf, so lets try without the console_output restriction for now, see how gates handle that, so we keep more full testing coverage if we can.","commit_id":"c5800d4dd59f602160c271de34564067f9fde465"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"b64dad560abff9ab72e39274b1c46fda54b19c46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"73fd7c3f_a931b7d6","in_reply_to":"ebe97a20_da473e92","updated":"2024-03-18 14:39:38.000000000","message":"\u003e it\u0027s ok to set console_output to False for the whole job. IIRC there are no tests in this plugin that will be affected. This will also allow multicast tests to run much faster (3 vms will be spawned in parallel instead of one by one) without affecting the results.\n\nonly disadvantage I see is less debugging info when failure found, but we can deploy and manually change that in conf file when extra info needed.","commit_id":"c5800d4dd59f602160c271de34564067f9fde465"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"ea2d9aa8edf841c0838bf8dfd0ee8e6e12645837","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"bdd89918_91f10e41","in_reply_to":"ebe97a20_da473e92","updated":"2024-03-18 14:34:47.000000000","message":"you can set the original code back but you\u0027ll have to add config.py entries for the alternative image.","commit_id":"c5800d4dd59f602160c271de34564067f9fde465"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"2e314b7d0ae9b930cc9e5efeedf702bf62495af2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"b314d053_1247fd1d","in_reply_to":"f00b3e73_cd79c826","updated":"2024-03-18 14:55:43.000000000","message":"so lets set console_output\u003dFalse, seems like the safer bet with upstream resources, in case we see a future problem then fix it back, and maybe make single threaded job and gate soon after the migration and next gen adaptations.","commit_id":"c5800d4dd59f602160c271de34564067f9fde465"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"e7993ce1d508d74b9669ec6c3bc1971f458b326e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"625a9eb1_24bfee90","in_reply_to":"f00b3e73_cd79c826","updated":"2024-03-18 14:45:58.000000000","message":"this is because there will be some other test in parallel (can be any). In d/s jbs we run this test in a single thread (alone)","commit_id":"c5800d4dd59f602160c271de34564067f9fde465"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"38a1520fb335e959836815f59e4782b183c64463","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"97359371_1413f30e","updated":"2024-03-19 08:41:15.000000000","message":"recheck","commit_id":"eea8f81ce5409a61d1191f30ef4155150ced8c19"}],"whitebox_neutron_tempest_plugin/config.py":[{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"fab6066f383e6f134adedf5546ece9c5e78f93a3","unresolved":true,"context_lines":[{"line_number":92,"context_line":"               help\u003d\u0027The number of network nodes used \u0027"},{"line_number":93,"context_line":"                    \u0027for the OVN router HA.\u0027),"},{"line_number":94,"context_line":"    cfg.IntOpt(\u0027servers_count\u0027,"},{"line_number":95,"context_line":"               default\u003d20,"},{"line_number":96,"context_line":"               help\u003d\u0027How many tenant VMs should be tested when many needed \u0027"},{"line_number":97,"context_line":"                    \u0027(default value meant for cirros image).\u0027)"},{"line_number":98,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a6ca8de_d8e25ed5","line":95,"range":{"start_line":95,"start_character":15,"end_line":95,"end_character":25},"updated":"2024-03-18 15:58:04.000000000","message":"note, as I see cirros flavor is 256M and disk 1G\ndevstack host has 80.0G disk and ~8G RAM  (if I am not mistaken)\nso 20*256M is very close to 8G. So it can be that in case the test will be unblocked on devstack gate (by console_output\u003dFalse) a lowering the servers_count or flavor may be required","commit_id":"e75e4a50c08bc6c445cf4a78e65f3bdb070d1ba5"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"ffcd20ba2d8e9896ce43b6fc45bebdde2772d5da","unresolved":true,"context_lines":[{"line_number":92,"context_line":"               help\u003d\u0027The number of network nodes used \u0027"},{"line_number":93,"context_line":"                    \u0027for the OVN router HA.\u0027),"},{"line_number":94,"context_line":"    cfg.IntOpt(\u0027servers_count\u0027,"},{"line_number":95,"context_line":"               default\u003d20,"},{"line_number":96,"context_line":"               help\u003d\u0027How many tenant VMs should be tested when many needed \u0027"},{"line_number":97,"context_line":"                    \u0027(default value meant for cirros image).\u0027)"},{"line_number":98,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":14,"id":"6e031a59_e6ab4eca","line":95,"range":{"start_line":95,"start_character":15,"end_line":95,"end_character":25},"in_reply_to":"7a6ca8de_d8e25ed5","updated":"2024-03-18 16:02:06.000000000","message":"meaning that there can be a test that spawns 3 advanced vms running in parallel, like multicast or broadcast test","commit_id":"e75e4a50c08bc6c445cf4a78e65f3bdb070d1ba5"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"bd2d58add83dc73be1c04e03a200c23c73e591c6","unresolved":false,"context_lines":[{"line_number":92,"context_line":"               help\u003d\u0027The number of network nodes used \u0027"},{"line_number":93,"context_line":"                    \u0027for the OVN router HA.\u0027),"},{"line_number":94,"context_line":"    cfg.IntOpt(\u0027servers_count\u0027,"},{"line_number":95,"context_line":"               default\u003d20,"},{"line_number":96,"context_line":"               help\u003d\u0027How many tenant VMs should be tested when many needed \u0027"},{"line_number":97,"context_line":"                    \u0027(default value meant for cirros image).\u0027)"},{"line_number":98,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":14,"id":"244f74c0_25191ea9","line":95,"range":{"start_line":95,"start_character":15,"end_line":95,"end_character":25},"in_reply_to":"7a6ca8de_d8e25ed5","updated":"2024-03-18 16:24:00.000000000","message":"sure why not, we can reduce resources used further, I can set 12 vms as default.\n\nfyi logs on equivalent local ovn env shows flavor used is with id 42, which has 128M ram and 1G disk, so these 20 vms should take ~2.5G ram, and all jobs use 2 threads for tests, the host will likely survive 2 or 3 tests like this running in parallel.\nso far also console_output\u003dTrue passed on last gate run before change which set to False.","commit_id":"e75e4a50c08bc6c445cf4a78e65f3bdb070d1ba5"}],"whitebox_neutron_tempest_plugin/tests/scenario/test_ports.py":[{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"4913c813d4ea16015d5f2e6bacef9b75c62dcd2b","unresolved":true,"context_lines":[{"line_number":28,"context_line":"class NetworkPortTestManyVmsBase(base.BaseTempestWhiteboxTestCase):"},{"line_number":29,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(NetworkPortTestManyVmsBase, self).setUp()"},{"line_number":33,"context_line":"        if not CONF.neutron_plugin_options.default_image_is_advanced:"},{"line_number":34,"context_line":"            self.flavor_ref \u003d CONF.compute.flavor_ref"},{"line_number":35,"context_line":"            self.image_ref \u003d CONF.compute.image_ref"},{"line_number":36,"context_line":"        else:"},{"line_number":37,"context_line":"            self.flavor_ref \u003d ("},{"line_number":38,"context_line":"                CONF.neutron_plugin_options.advanced_image_flavor_ref)"},{"line_number":39,"context_line":"            self.image_ref \u003d CONF.neutron_plugin_options.advanced_image_ref"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _update_quota(self, quota_item, quota_value):"},{"line_number":42,"context_line":"        quota_set \u003d self.quotas_client.show_quota_set("}],"source_content_type":"text/x-python","patch_set":13,"id":"d909c6c1_cd18870e","line":39,"range":{"start_line":31,"start_character":0,"end_line":39,"end_character":75},"updated":"2024-03-18 14:26:24.000000000","message":"we don\u0027t want to run this test with advanced image(slow and requires many resources). But we would like to run it with some alternative small image in case default image is advanced. The original code was specifically wrote for handling this.","commit_id":"c5800d4dd59f602160c271de34564067f9fde465"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"e0d481aedd815f88de230b2dfc75027b299e3720","unresolved":false,"context_lines":[{"line_number":28,"context_line":"class NetworkPortTestManyVmsBase(base.BaseTempestWhiteboxTestCase):"},{"line_number":29,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(NetworkPortTestManyVmsBase, self).setUp()"},{"line_number":33,"context_line":"        if not CONF.neutron_plugin_options.default_image_is_advanced:"},{"line_number":34,"context_line":"            self.flavor_ref \u003d CONF.compute.flavor_ref"},{"line_number":35,"context_line":"            self.image_ref \u003d CONF.compute.image_ref"},{"line_number":36,"context_line":"        else:"},{"line_number":37,"context_line":"            self.flavor_ref \u003d ("},{"line_number":38,"context_line":"                CONF.neutron_plugin_options.advanced_image_flavor_ref)"},{"line_number":39,"context_line":"            self.image_ref \u003d CONF.neutron_plugin_options.advanced_image_ref"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _update_quota(self, quota_item, quota_value):"},{"line_number":42,"context_line":"        quota_set \u003d self.quotas_client.show_quota_set("}],"source_content_type":"text/x-python","patch_set":13,"id":"517fb8bb_07fdc2bd","line":39,"range":{"start_line":31,"start_character":0,"end_line":39,"end_character":75},"in_reply_to":"c94d1d11_fdf8d7d7","updated":"2024-03-18 15:28:06.000000000","message":"Done","commit_id":"c5800d4dd59f602160c271de34564067f9fde465"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"182de2a711a89528c35d5bd2f90508dbcbbe355b","unresolved":true,"context_lines":[{"line_number":28,"context_line":"class NetworkPortTestManyVmsBase(base.BaseTempestWhiteboxTestCase):"},{"line_number":29,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(NetworkPortTestManyVmsBase, self).setUp()"},{"line_number":33,"context_line":"        if not CONF.neutron_plugin_options.default_image_is_advanced:"},{"line_number":34,"context_line":"            self.flavor_ref \u003d CONF.compute.flavor_ref"},{"line_number":35,"context_line":"            self.image_ref \u003d CONF.compute.image_ref"},{"line_number":36,"context_line":"        else:"},{"line_number":37,"context_line":"            self.flavor_ref \u003d ("},{"line_number":38,"context_line":"                CONF.neutron_plugin_options.advanced_image_flavor_ref)"},{"line_number":39,"context_line":"            self.image_ref \u003d CONF.neutron_plugin_options.advanced_image_ref"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _update_quota(self, quota_item, quota_value):"},{"line_number":42,"context_line":"        quota_set \u003d self.quotas_client.show_quota_set("}],"source_content_type":"text/x-python","patch_set":13,"id":"c94d1d11_fdf8d7d7","line":39,"range":{"start_line":31,"start_character":0,"end_line":39,"end_character":75},"in_reply_to":"d909c6c1_cd18870e","updated":"2024-03-18 14:32:22.000000000","message":"ok, is this alternative image testing relevant for next gen tests currently? or we can currently spare that code? if needed in the future then migrate code and adjust such image.","commit_id":"c5800d4dd59f602160c271de34564067f9fde465"}]}