)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"b42510ec17d2cf410aeb4a6eaca5e15e2978c0c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"efc5245d_277972a2","updated":"2024-12-09 10:48:54.000000000","message":"lgtm\nthere\u0027s just a syntax error","commit_id":"b833b234dd01f6d5bae12408854fb28d3ec63e40"}],"whitebox_neutron_tempest_plugin/tests/scenario/base.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"b904451e588afd5fbd33d2a11ffb9e8b82062ab2","unresolved":true,"context_lines":[{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"    def _log_captured_packets(self):"},{"line_number":1133,"context_line":"        for node in self.nodes:"},{"line_number":1134,"context_line":"            if node[\u0027capture\u0027].is_empty():"},{"line_number":1135,"context_line":"                captured_packets \u003d \"No packets captured\""},{"line_number":1136,"context_line":"            else:"},{"line_number":1137,"context_line":"                captured_packets \u003d \"\\n \".join("}],"source_content_type":"text/x-python","patch_set":3,"id":"b6f49557_f407d285","line":1134,"updated":"2024-12-09 07:25:58.000000000","message":"Considering other checks this seems could result into KeyError.","commit_id":"4d82a21f763e028c5b2766bb804858fa22f2a83d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cf51fbd1956a05ab8a7793fb3b31c28d9f4c9941","unresolved":false,"context_lines":[{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"    def _log_captured_packets(self):"},{"line_number":1133,"context_line":"        for node in self.nodes:"},{"line_number":1134,"context_line":"            if node[\u0027capture\u0027].is_empty():"},{"line_number":1135,"context_line":"                captured_packets \u003d \"No packets captured\""},{"line_number":1136,"context_line":"            else:"},{"line_number":1137,"context_line":"                captured_packets \u003d \"\\n \".join("}],"source_content_type":"text/x-python","patch_set":3,"id":"808a7646_2f9251d2","line":1134,"in_reply_to":"b6f49557_f407d285","updated":"2024-12-09 10:03:53.000000000","message":"Done","commit_id":"4d82a21f763e028c5b2766bb804858fa22f2a83d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"b904451e588afd5fbd33d2a11ffb9e8b82062ab2","unresolved":true,"context_lines":[{"line_number":1136,"context_line":"            else:"},{"line_number":1137,"context_line":"                captured_packets \u003d \"\\n \".join("},{"line_number":1138,"context_line":"                    node[\u0027capture\u0027].get_captured_records())"},{"line_number":1139,"context_line":"            LOG.debug(\"Node: {}; Packets captured: {}\".format("},{"line_number":1140,"context_line":"                      node[\"short_name\"], captured_packets))"},{"line_number":1141,"context_line":""},{"line_number":1142,"context_line":"    def check_east_west_icmp_flow("}],"source_content_type":"text/x-python","patch_set":3,"id":"4b4dffdd_1e6fe70c","line":1139,"in_reply_to":"e4c6b4b5_6b8b2bf0","updated":"2024-12-09 07:25:58.000000000","message":"\u003e pep8: H904: String interpolation should be delayed to be handled by the logging code, rather than being done at the point of the logging call. Use \u0027,\u0027 instead of \u0027%\u0027.\n\nPlease fix.","commit_id":"4d82a21f763e028c5b2766bb804858fa22f2a83d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"b904451e588afd5fbd33d2a11ffb9e8b82062ab2","unresolved":true,"context_lines":[{"line_number":1234,"context_line":"        try:"},{"line_number":1235,"context_line":"            self.assertCountEqual(expected_routing_nodes, actual_routing_nodes)"},{"line_number":1236,"context_line":"        except AssertionError:"},{"line_number":1237,"context_line":"            self._log_captured_packets()"},{"line_number":1238,"context_line":"            raise"},{"line_number":1239,"context_line":""},{"line_number":1240,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9c65b4f9_64522abb","line":1237,"updated":"2024-12-09 07:25:58.000000000","message":"Still unsure on how this will help in related bug as all nodes are returning empty result , and now if all captures is empty will just additionally log \"No packets captured\"","commit_id":"4d82a21f763e028c5b2766bb804858fa22f2a83d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"0fd326c1350e45cdccf038492ba77b73e31c3f75","unresolved":true,"context_lines":[{"line_number":1234,"context_line":"        try:"},{"line_number":1235,"context_line":"            self.assertCountEqual(expected_routing_nodes, actual_routing_nodes)"},{"line_number":1236,"context_line":"        except AssertionError:"},{"line_number":1237,"context_line":"            self._log_captured_packets()"},{"line_number":1238,"context_line":"            raise"},{"line_number":1239,"context_line":""},{"line_number":1240,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ec882818_1cfbfc51","line":1237,"in_reply_to":"839af1b9_a248458a","updated":"2024-12-10 10:52:19.000000000","message":"ack with additional actual_routing_nodes it may help, but with linked issue what i saw list was empty.","commit_id":"4d82a21f763e028c5b2766bb804858fa22f2a83d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cf51fbd1956a05ab8a7793fb3b31c28d9f4c9941","unresolved":true,"context_lines":[{"line_number":1234,"context_line":"        try:"},{"line_number":1235,"context_line":"            self.assertCountEqual(expected_routing_nodes, actual_routing_nodes)"},{"line_number":1236,"context_line":"        except AssertionError:"},{"line_number":1237,"context_line":"            self._log_captured_packets()"},{"line_number":1238,"context_line":"            raise"},{"line_number":1239,"context_line":""},{"line_number":1240,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"839af1b9_a248458a","line":1237,"in_reply_to":"9c65b4f9_64522abb","updated":"2024-12-09 10:03:53.000000000","message":"I think that in cases which I was checking the error was that actual_routing_nodes list contained additional compute node. Not that the list was empty. But maybe I\u0027m wrong - I will check it once again","commit_id":"4d82a21f763e028c5b2766bb804858fa22f2a83d"}]}