)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"67b80e6b71fcb81538cc1cfdd00a0fa5bfb08d40","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Renjing Xiao \u003crxiao@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-02-12 12:49:09 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add nested snat tesin whitebox"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This test checks connectivity when ovn_router_indirect_snat is enabled."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"4458ac6a_14d86c19","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":2},"updated":"2025-02-12 13:58:55.000000000","message":"It is worth mentioning that this functionality was added for ML2/OVN in https://review.opendev.org/c/openstack/neutron/+/926495","commit_id":"0fe0c586d32518634fd9cb33c36ca860afd3e719"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"67b80e6b71fcb81538cc1cfdd00a0fa5bfb08d40","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Renjing Xiao \u003crxiao@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-02-12 12:49:09 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add nested snat tesin whitebox"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This test checks connectivity when ovn_router_indirect_snat is enabled."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"fae01f4e_80bc7077","line":7,"updated":"2025-02-12 13:58:55.000000000","message":"nit: no needed, this is the whitebox repository","commit_id":"0fe0c586d32518634fd9cb33c36ca860afd3e719"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"dea2de3a9e418ffbcbf401d292b7c6cfae14f51c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Renjing Xiao \u003crxiao@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-02-12 12:49:09 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add nested snat tesin whitebox"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This test checks connectivity when ovn_router_indirect_snat is enabled."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"e723eb9e_0204ff9b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":2},"in_reply_to":"4458ac6a_14d86c19","updated":"2025-03-11 10:16:29.000000000","message":"Done","commit_id":"0fe0c586d32518634fd9cb33c36ca860afd3e719"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"dea2de3a9e418ffbcbf401d292b7c6cfae14f51c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Renjing Xiao \u003crxiao@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-02-12 12:49:09 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add nested snat tesin whitebox"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This test checks connectivity when ovn_router_indirect_snat is enabled."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"53228316_917f5e9a","line":7,"in_reply_to":"fae01f4e_80bc7077","updated":"2025-03-11 10:16:29.000000000","message":"Done","commit_id":"0fe0c586d32518634fd9cb33c36ca860afd3e719"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"67b80e6b71fcb81538cc1cfdd00a0fa5bfb08d40","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/940906"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related Jira ticket: https://issues.redhat.com/browse/OSPRH-13329"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2b31d1c123286bcbd69f932bda069aa3af9beb18"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"725bff17_ef56b221","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":65},"updated":"2025-02-12 13:58:55.000000000","message":"Resolves-Bug: OSPRH-13329","commit_id":"0fe0c586d32518634fd9cb33c36ca860afd3e719"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"dea2de3a9e418ffbcbf401d292b7c6cfae14f51c","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/940906"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related Jira ticket: https://issues.redhat.com/browse/OSPRH-13329"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2b31d1c123286bcbd69f932bda069aa3af9beb18"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"b065509d_afa482b3","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":65},"in_reply_to":"725bff17_ef56b221","updated":"2025-03-11 10:16:29.000000000","message":"Done","commit_id":"0fe0c586d32518634fd9cb33c36ca860afd3e719"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"f328a996a1fbe42e45feebc5de3b02d7b8024d7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"a1a01576_11023e63","updated":"2025-02-14 13:35:39.000000000","message":"recheck test operator not triggered","commit_id":"d5ab80b2c7564a94cb6dd7ed899593144ce67fba"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"5c1c7f248ca844ccaf36c73f9c563b01c18cf89d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"95aa03ef_37152838","updated":"2025-02-19 08:48:01.000000000","message":"@rxiao@redhat.com Looks good to me, lets get the `neutron-tempest-plugin` patch merged first since code here depends on it, you\u0027ll need more reviewers to approve it there, I already added +1 there.","commit_id":"bd428a6c2f072502b9d9aa43939589b30ac997a4"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"813bc78e6341c87feba6e7a68eaed9000605a1cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"9c0cb10d_d71738b6","updated":"2025-03-09 09:35:51.000000000","message":"Hi, after looking at some CI changes on `neutron-tempest-plugin` patch, we also have devstack ovn master gate on `whitebox-neutron-tempest-plugin`, and RDO 3rd party whitebox job using antelope and already checking by default with feature disabled.\nSo lets enable feature on devstack ovn gate as well (cover gates for enabled/disabled feature on whitebox changes).","commit_id":"bd428a6c2f072502b9d9aa43939589b30ac997a4"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"0b6dda39c1ed4739a1673074becb4f8d4b99418d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"6060fc99_7922ac95","updated":"2025-03-10 07:56:55.000000000","message":"The single thread gate failure afaik seems random and one-off, unrelated to tests, something went wrong with tempest itself, and more logs needed to know better.","commit_id":"bd428a6c2f072502b9d9aa43939589b30ac997a4"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"38b4ea2f304d0fad40756ea8a5ddb553894b301c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"963a6506_444a3914","updated":"2025-03-08 16:28:06.000000000","message":"recheck again","commit_id":"bd428a6c2f072502b9d9aa43939589b30ac997a4"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"c69eca0535a3af2e6dc1314d4b0a678b74ee44f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"ac2a1d44_014025cd","updated":"2025-03-08 09:11:12.000000000","message":"recheck build","commit_id":"bd428a6c2f072502b9d9aa43939589b30ac997a4"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"dbbcc35c9120a2b0b7c1da165b42324b38e81cda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"aa85f5b6_0d549290","updated":"2025-03-08 23:49:58.000000000","message":"recheck whitebox-neutron-tempest-plugin-ovn-single-thread","commit_id":"bd428a6c2f072502b9d9aa43939589b30ac997a4"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"0b253d95aa31727dcfd47d615eda9581206d7850","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"86d25888_25066528","updated":"2025-03-10 09:45:17.000000000","message":"I just noticed that on `neutron-tempest-plugin`\u0027s similar devstack master job - there is `ovn_router_indirect_snat: false` [1], meaning that it isn\u0027t enabled in any job due to ovn stable version currently used lower than needed for feature :/\nSo not sure that patchset 22 will work here.\n\n[1] https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/940906/19/zuul.d/master_jobs.yaml#L689","commit_id":"0ea8c5bf4eff96888db26eb890db56a0a8f6b303"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"dea2de3a9e418ffbcbf401d292b7c6cfae14f51c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"e5f22fb2_cd9347a3","in_reply_to":"86d25888_25066528","updated":"2025-03-11 10:16:29.000000000","message":"Done","commit_id":"0ea8c5bf4eff96888db26eb890db56a0a8f6b303"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"75678b996613d885e235bd8ef6465e928bd87187","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"2d7fe573_37fb1ef9","updated":"2025-03-11 17:29:14.000000000","message":"recheck unrelated tempest fault","commit_id":"e401b6162b72517bc38d9b13b932fd3995cf84e7"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"40ae3bc60939d173bac96aba77611f31cc710cd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"706d7511_8e01259a","updated":"2025-03-10 20:41:28.000000000","message":"recheck whitebox-neutron-tempest-plugin-ovn","commit_id":"e401b6162b72517bc38d9b13b932fd3995cf84e7"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"bb7e11061d9f2417a39f56ff37b62afe6ad83d13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"d89a4b91_de6db481","updated":"2025-03-12 18:50:10.000000000","message":"recheck whitebox-neutron-tempest-plugin-ovn","commit_id":"e401b6162b72517bc38d9b13b932fd3995cf84e7"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"e6468e6bb7ceaed1c7b4b090db5281d5ec4576f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"236d22f1_007349fb","updated":"2025-03-12 21:23:36.000000000","message":"recheck whitebox-neutron-tempest-plugin-ovn-single-thread","commit_id":"e401b6162b72517bc38d9b13b932fd3995cf84e7"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"c63023901b19e089f64526cb37fda13fb20f7960","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"25780963_97f2df9a","updated":"2025-03-10 23:59:12.000000000","message":"recheck whitebox-neutron-tempest-plugin-ovn-single-thread","commit_id":"e401b6162b72517bc38d9b13b932fd3995cf84e7"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"153db805e221b52fe3c486a2fda79f17e83bcdf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"30b1694c_5facd782","updated":"2025-03-11 08:21:45.000000000","message":"recheck whitebox-neutron-tempest-plugin-ovn-single-thread","commit_id":"e401b6162b72517bc38d9b13b932fd3995cf84e7"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"b9dc5fcb2204a2ec519304a6a50553f858bcf2d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"32b8331b_24693241","updated":"2025-03-12 16:18:54.000000000","message":"recheck whitebox-neutron-tempest-plugin-ovn-single-thread","commit_id":"e401b6162b72517bc38d9b13b932fd3995cf84e7"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"8402eddafaa6595e95a6d40303f0d5d32966c9da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"74cf0f99_f7ce7526","updated":"2025-03-11 22:29:16.000000000","message":"recheck whitebox-neutron-tempest-plugin-ovn-single-thread","commit_id":"e401b6162b72517bc38d9b13b932fd3995cf84e7"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"dea2de3a9e418ffbcbf401d292b7c6cfae14f51c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"771bb55c_c3c46e0d","updated":"2025-03-11 10:16:29.000000000","message":"recheck whitebox-neutron-tempest-plugin-ovn-single-thread","commit_id":"e401b6162b72517bc38d9b13b932fd3995cf84e7"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"93d77d22fdabb0f750851bffa6e33e65c92f500c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"7a0cb855_5b826a3f","updated":"2025-03-10 16:27:31.000000000","message":"recheck whitebox-neutron-tempest-plugin-ovn-single-thread","commit_id":"e401b6162b72517bc38d9b13b932fd3995cf84e7"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"1b538138478345cc740d546ecd1f611c503d363e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"7f152c27_a2c0d2c4","updated":"2025-03-10 14:08:08.000000000","message":"recheck whitebox-neutron-tempest-plugin-ovn-single-thread","commit_id":"e401b6162b72517bc38d9b13b932fd3995cf84e7"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"84db8080b9a9e7345cf8b950b21c8e110f90b89e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"ec6fe7f7_bfa61449","updated":"2025-03-11 07:33:39.000000000","message":"whitebox-neutron-tempest-plugin-ovn-single-thread","commit_id":"e401b6162b72517bc38d9b13b932fd3995cf84e7"}],"whitebox_neutron_tempest_plugin/tests/scenario/test_floatingip.py":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"201d2ecca734b5a771dba69dd8d09fe114aab254","unresolved":true,"context_lines":[{"line_number":15,"context_line":"                section\u003d\u0027ovn\u0027,"},{"line_number":16,"context_line":"                config_files\u003dconfig_files,"},{"line_number":17,"context_line":"                param\u003d\u0027ovn_router_indirect_snat\u0027):"},{"line_number":18,"context_line":"            msg \u003d \"Backend doesn\u0027t enable nested SNAT.\""},{"line_number":19,"context_line":"            raise cls.skipException(msg)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_nested_snat_external_ip(self):"},{"line_number":22,"context_line":"        self.resource_setup()"},{"line_number":23,"context_line":"        super().test_nested_snat_external_ip()"}],"source_content_type":"text/x-python","patch_set":3,"id":"6f0d6c78_d6521765","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":0},"updated":"2025-02-07 07:09:36.000000000","message":"`check_service_setting` has 2 arguments that can be used for this purpose: `msg` and `skip_if_fails`.\nhttps://opendev.org/x/whitebox-neutron-tempest-plugin/src/commit/37a4f7b8285dc5a7649ad55a15c89357d7954271/whitebox_neutron_tempest_plugin/tests/scenario/base.py#L512","commit_id":"607563fbc782214f81777837a4524a784dc4ee19"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"dea2de3a9e418ffbcbf401d292b7c6cfae14f51c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"                section\u003d\u0027ovn\u0027,"},{"line_number":16,"context_line":"                config_files\u003dconfig_files,"},{"line_number":17,"context_line":"                param\u003d\u0027ovn_router_indirect_snat\u0027):"},{"line_number":18,"context_line":"            msg \u003d \"Backend doesn\u0027t enable nested SNAT.\""},{"line_number":19,"context_line":"            raise cls.skipException(msg)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_nested_snat_external_ip(self):"},{"line_number":22,"context_line":"        self.resource_setup()"},{"line_number":23,"context_line":"        super().test_nested_snat_external_ip()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ae92bc69_2f234b62","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":0},"in_reply_to":"6f0d6c78_d6521765","updated":"2025-03-11 10:16:29.000000000","message":"Done","commit_id":"607563fbc782214f81777837a4524a784dc4ee19"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"201d2ecca734b5a771dba69dd8d09fe114aab254","unresolved":true,"context_lines":[{"line_number":19,"context_line":"            raise cls.skipException(msg)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_nested_snat_external_ip(self):"},{"line_number":22,"context_line":"        self.resource_setup()"},{"line_number":23,"context_line":"        super().test_nested_snat_external_ip()"}],"source_content_type":"text/x-python","patch_set":3,"id":"52314734_2a74333f","line":22,"range":{"start_line":22,"start_character":8,"end_line":22,"end_character":29},"updated":"2025-02-07 07:09:36.000000000","message":"`resource_setup` is called before test start by tempest to make all resources for test class, no need to add line here.","commit_id":"607563fbc782214f81777837a4524a784dc4ee19"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"dea2de3a9e418ffbcbf401d292b7c6cfae14f51c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"            raise cls.skipException(msg)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_nested_snat_external_ip(self):"},{"line_number":22,"context_line":"        self.resource_setup()"},{"line_number":23,"context_line":"        super().test_nested_snat_external_ip()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3182f1ea_e0f683c4","line":22,"range":{"start_line":22,"start_character":8,"end_line":22,"end_character":29},"in_reply_to":"52314734_2a74333f","updated":"2025-03-11 10:16:29.000000000","message":"Done","commit_id":"607563fbc782214f81777837a4524a784dc4ee19"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"028dae8de2f1235c40404ca630693147536470a7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"fb6fc576_ec2632ad","updated":"2025-02-12 09:43:23.000000000","message":"nit: Tests in file seem to test specifically nested routers feature, not generally fips as file in other plugin does, so maybe such filename would be more appropriate `test_nested_routers.py`, etc.","commit_id":"dd5a9e9bfccab6e94127d22e91368c5eac684eb9"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"dea2de3a9e418ffbcbf401d292b7c6cfae14f51c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"383724ff_483b9536","in_reply_to":"fb6fc576_ec2632ad","updated":"2025-03-11 10:16:29.000000000","message":"Done","commit_id":"dd5a9e9bfccab6e94127d22e91368c5eac684eb9"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"028dae8de2f1235c40404ca630693147536470a7","unresolved":true,"context_lines":[{"line_number":22,"context_line":"WB_CONF \u003d config.CONF.whitebox_neutron_plugin_options"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class WhiteboxDefaultSnatToExternal("},{"line_number":26,"context_line":"        base.BaseTempestWhiteboxTestCase, DefaultSnatToExternal):"},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"d904c909_16b5babe","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":35},"updated":"2025-02-12 09:43:23.000000000","message":"Please add \u0027Test\u0027 word to class to differentiate from base classes, and ones containing tests, like `WhiteboxDefaultSnatToExternalTest`","commit_id":"dd5a9e9bfccab6e94127d22e91368c5eac684eb9"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"dea2de3a9e418ffbcbf401d292b7c6cfae14f51c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"WB_CONF \u003d config.CONF.whitebox_neutron_plugin_options"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class WhiteboxDefaultSnatToExternal("},{"line_number":26,"context_line":"        base.BaseTempestWhiteboxTestCase, DefaultSnatToExternal):"},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5a1c04_6c71ca03","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":35},"in_reply_to":"d904c909_16b5babe","updated":"2025-03-11 10:16:29.000000000","message":"Done","commit_id":"dd5a9e9bfccab6e94127d22e91368c5eac684eb9"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"028dae8de2f1235c40404ca630693147536470a7","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def resource_setup(cls):"},{"line_number":29,"context_line":"        super(WhiteboxDefaultSnatToExternal, cls).resource_setup()"},{"line_number":30,"context_line":"        config_files \u003d cls.get_configs_of_service()"},{"line_number":31,"context_line":"        cls.check_service_setting("},{"line_number":32,"context_line":"            {\u0027client\u0027: cls.proxy_host_client},"},{"line_number":33,"context_line":"            section\u003d\u0027ovn\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"e29af2e0_be3c28b0","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":51},"updated":"2025-02-12 09:43:23.000000000","message":"There is failure with devstack job `whitebox-neutron-tempest-plugin-ovn` [1], it can\u0027t use oc commands.\n`WB_CONF.openstack_type` can be checked to execute only on podified setups, but in this case maybe we can avoid fetching `config_files`, for example this code handles some devstack non podifed, and podified setups using predefined constants [2].\n\n[1] https://zuul.opendev.org/t/openstack/build/1817341bda9f4756aefbccd0833ba2b7\n[2] https://opendev.org/x/whitebox-neutron-tempest-plugin/src/commit/da9f583c1e/whitebox_neutron_tempest_plugin/tests/scenario/test_security_group_logging.py#L83","commit_id":"dd5a9e9bfccab6e94127d22e91368c5eac684eb9"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"dea2de3a9e418ffbcbf401d292b7c6cfae14f51c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def resource_setup(cls):"},{"line_number":29,"context_line":"        super(WhiteboxDefaultSnatToExternal, cls).resource_setup()"},{"line_number":30,"context_line":"        config_files \u003d cls.get_configs_of_service()"},{"line_number":31,"context_line":"        cls.check_service_setting("},{"line_number":32,"context_line":"            {\u0027client\u0027: cls.proxy_host_client},"},{"line_number":33,"context_line":"            section\u003d\u0027ovn\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"47d443b4_6e47cfae","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":51},"in_reply_to":"e29af2e0_be3c28b0","updated":"2025-03-11 10:16:29.000000000","message":"Done","commit_id":"dd5a9e9bfccab6e94127d22e91368c5eac684eb9"}],"whitebox_neutron_tempest_plugin/tests/scenario/test_nested_routers.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"67b80e6b71fcb81538cc1cfdd00a0fa5bfb08d40","unresolved":true,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron_tempest_plugin.scenario.test_floatingip \\"},{"line_number":17,"context_line":"    import DefaultSnatToExternal"},{"line_number":18,"context_line":"from tempest import config"},{"line_number":19,"context_line":"from whitebox_neutron_tempest_plugin.tests.scenario import base"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"402aacee_3f916cd3","line":17,"updated":"2025-02-12 13:58:55.000000000","message":"We don\u0027t import classes by modules. Just do\n``from neutron_tempest_plugin.scenario import test_floatingip``","commit_id":"0fe0c586d32518634fd9cb33c36ca860afd3e719"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"dea2de3a9e418ffbcbf401d292b7c6cfae14f51c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron_tempest_plugin.scenario.test_floatingip \\"},{"line_number":17,"context_line":"    import DefaultSnatToExternal"},{"line_number":18,"context_line":"from tempest import config"},{"line_number":19,"context_line":"from whitebox_neutron_tempest_plugin.tests.scenario import base"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"6d5b902f_8130b79e","line":17,"in_reply_to":"402aacee_3f916cd3","updated":"2025-03-11 10:16:29.000000000","message":"Done","commit_id":"0fe0c586d32518634fd9cb33c36ca860afd3e719"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"67b80e6b71fcb81538cc1cfdd00a0fa5bfb08d40","unresolved":true,"context_lines":[{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":"WB_CONF \u003d config.CONF.whitebox_neutron_plugin_options"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class WhiteboxDefaultSnatToExternalTest("},{"line_number":25,"context_line":"        base.BaseTempestWhiteboxTestCase, DefaultSnatToExternal):"},{"line_number":26,"context_line":"    @classmethod"},{"line_number":27,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9407e291_da267a2a","line":24,"range":{"start_line":24,"start_character":6,"end_line":24,"end_character":14},"updated":"2025-02-12 13:58:55.000000000","message":"There is no need to add this prefix. This is the whitebox repository","commit_id":"0fe0c586d32518634fd9cb33c36ca860afd3e719"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"67b80e6b71fcb81538cc1cfdd00a0fa5bfb08d40","unresolved":true,"context_lines":[{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":"WB_CONF \u003d config.CONF.whitebox_neutron_plugin_options"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class WhiteboxDefaultSnatToExternalTest("},{"line_number":25,"context_line":"        base.BaseTempestWhiteboxTestCase, DefaultSnatToExternal):"},{"line_number":26,"context_line":"    @classmethod"},{"line_number":27,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":11,"id":"337b67d1_2906d4cd","line":24,"range":{"start_line":24,"start_character":6,"end_line":24,"end_character":39},"updated":"2025-02-12 13:58:55.000000000","message":"What is the goal of this test? Shouldn\u0027t you check ``test_nested_snat_external_ip`` with the config flag set and unset?","commit_id":"0fe0c586d32518634fd9cb33c36ca860afd3e719"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"dea2de3a9e418ffbcbf401d292b7c6cfae14f51c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":"WB_CONF \u003d config.CONF.whitebox_neutron_plugin_options"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class WhiteboxDefaultSnatToExternalTest("},{"line_number":25,"context_line":"        base.BaseTempestWhiteboxTestCase, DefaultSnatToExternal):"},{"line_number":26,"context_line":"    @classmethod"},{"line_number":27,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":11,"id":"f45c75f3_c6cc5dc4","line":24,"range":{"start_line":24,"start_character":6,"end_line":24,"end_character":39},"in_reply_to":"337b67d1_2906d4cd","updated":"2025-03-11 10:16:29.000000000","message":"Done","commit_id":"0fe0c586d32518634fd9cb33c36ca860afd3e719"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"dea2de3a9e418ffbcbf401d292b7c6cfae14f51c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":"WB_CONF \u003d config.CONF.whitebox_neutron_plugin_options"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class WhiteboxDefaultSnatToExternalTest("},{"line_number":25,"context_line":"        base.BaseTempestWhiteboxTestCase, DefaultSnatToExternal):"},{"line_number":26,"context_line":"    @classmethod"},{"line_number":27,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a237507_a09b9116","line":24,"range":{"start_line":24,"start_character":6,"end_line":24,"end_character":14},"in_reply_to":"9407e291_da267a2a","updated":"2025-03-11 10:16:29.000000000","message":"Done","commit_id":"0fe0c586d32518634fd9cb33c36ca860afd3e719"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"78f6bcbb788d5f265fd3bdb22de35bcff6867f50","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            cls.feature_enabled_bool \u003d False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_nested_snat_external_ip(self):"},{"line_number":45,"context_line":"        super(DefaultSnatToExternalTest, self)._test_nested_snat_external_ip("},{"line_number":46,"context_line":"            self.feature_enabled_bool"},{"line_number":47,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":19,"id":"36472bf0_22609bf9","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":36},"updated":"2025-02-18 12:24:07.000000000","message":"please add decorator `idempotent_id` with unique uuid for this test method, like on `neutron-tempest-plugin` patch, you can use `uuidgen` command.","commit_id":"d5ab80b2c7564a94cb6dd7ed899593144ce67fba"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"dea2de3a9e418ffbcbf401d292b7c6cfae14f51c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            cls.feature_enabled_bool \u003d False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_nested_snat_external_ip(self):"},{"line_number":45,"context_line":"        super(DefaultSnatToExternalTest, self)._test_nested_snat_external_ip("},{"line_number":46,"context_line":"            self.feature_enabled_bool"},{"line_number":47,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":19,"id":"6b17a1e0_06a734bc","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":36},"in_reply_to":"36472bf0_22609bf9","updated":"2025-03-11 10:16:29.000000000","message":"Done","commit_id":"d5ab80b2c7564a94cb6dd7ed899593144ce67fba"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"78f6bcbb788d5f265fd3bdb22de35bcff6867f50","unresolved":true,"context_lines":[{"line_number":42,"context_line":"            cls.feature_enabled_bool \u003d False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_nested_snat_external_ip(self):"},{"line_number":45,"context_line":"        super(DefaultSnatToExternalTest, self)._test_nested_snat_external_ip("},{"line_number":46,"context_line":"            self.feature_enabled_bool"},{"line_number":47,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":19,"id":"e6ee8d74_d98e2a65","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":46},"updated":"2025-02-18 12:24:07.000000000","message":"nit: the method `_test_nested_snat_external_ip` is inherited and not overridden by method in this class, so no need to call the parent method with `super`.\nIt will also keep the method call only in one line.","commit_id":"d5ab80b2c7564a94cb6dd7ed899593144ce67fba"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"dea2de3a9e418ffbcbf401d292b7c6cfae14f51c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            cls.feature_enabled_bool \u003d False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_nested_snat_external_ip(self):"},{"line_number":45,"context_line":"        super(DefaultSnatToExternalTest, self)._test_nested_snat_external_ip("},{"line_number":46,"context_line":"            self.feature_enabled_bool"},{"line_number":47,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":19,"id":"9bd4950a_f4df2ba0","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":46},"in_reply_to":"9cb10228_28ec9a20","updated":"2025-03-11 10:16:29.000000000","message":"Done","commit_id":"d5ab80b2c7564a94cb6dd7ed899593144ce67fba"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"9aa697df6f4e05310f20a5fc44854bbd073e4e53","unresolved":true,"context_lines":[{"line_number":42,"context_line":"            cls.feature_enabled_bool \u003d False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_nested_snat_external_ip(self):"},{"line_number":45,"context_line":"        super(DefaultSnatToExternalTest, self)._test_nested_snat_external_ip("},{"line_number":46,"context_line":"            self.feature_enabled_bool"},{"line_number":47,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":19,"id":"9cb10228_28ec9a20","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":46},"in_reply_to":"e6ee8d74_d98e2a65","updated":"2025-02-18 13:08:53.000000000","message":"nit: It is shorter but `super()` still refers to parent class, you can use `self` instead.","commit_id":"d5ab80b2c7564a94cb6dd7ed899593144ce67fba"}]}