)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"55de68dbe2fdbfaf8b0bb042fe58004c87831b64","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bdf123bf_03707cdd","updated":"2025-02-18 09:42:56.000000000","message":"Additionally `whitebox-neutron-tempest-plugin-ovn` gate fails, I didn\u0027t expect that, the neutron fix is missing there [1], I\u0027ll take a look on that too, maybe devstack ovn gate takes old changes and can be fixed.\n\n[1]\n\nhttps://7e10bbdd98bbf744650d-bb4c2814ef367a6a12ccd71597cd133f.ssl.cf1.rackcdn.com/941930/1/check/whitebox-neutron-tempest-plugin-ovn/27b154d/controller/logs/tempest_log.txt\n\n\"\"\"\n...\n2025-02-17 15:32:24.875 86092 DEBUG neutron_tempest_plugin.common.shell [-] Command \u0027bash -c \". /opt/stack/devstack/openrc admin \u0026\u0026 openstack port list --server f6461c9d-845e-4caf-80d0-4b8ea5d273d5 --long -c \\\u0027Security Groups\\\u0027\"\u0027 succeeded:\nstderr:\nNone\nstdout:\n+-----------------+\n| Security Groups |\n+-----------------+\n| None            |\n+-----------------+\n...\n\"\"\"","commit_id":"73cb6503561244a2928a1f0c55fbbd33e90a00cb"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"1069763b1588d22576a1d56a33402aa0b02eb6ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0f20c5d8_36d2102c","updated":"2025-02-18 16:45:55.000000000","message":"Tested the method argument on new port list test - on podified setup.\nthe security group logging tests have no functional change, same happens.","commit_id":"73cb6503561244a2928a1f0c55fbbd33e90a00cb"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"f4c9ec7ee7e0dca46992bbc870171abac0877829","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a91f2afc_926cfc15","updated":"2025-02-17 14:35:53.000000000","message":"Verified on network crc autohold, please review","commit_id":"73cb6503561244a2928a1f0c55fbbd33e90a00cb"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"4df7175e5711b3fe1e56a3856dcc50528ec26ca4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d2789f1e_4045e83d","updated":"2025-02-17 15:54:39.000000000","message":"recheck","commit_id":"73cb6503561244a2928a1f0c55fbbd33e90a00cb"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"1069763b1588d22576a1d56a33402aa0b02eb6ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"36218ed5_b5d86152","in_reply_to":"bdf123bf_03707cdd","updated":"2025-02-18 16:45:55.000000000","message":"Done, bump to include tested fix in ovn devstack job is handled here\nhttps://review.opendev.org/c/openstack/releases/+/942104","commit_id":"73cb6503561244a2928a1f0c55fbbd33e90a00cb"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"4611618bad6485dc219c3b9fedf48ec68e3b5095","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2c698375_5fcf406a","updated":"2025-02-19 08:40:19.000000000","message":"The fix was verified downstream, but not available upstream (for both whitebox job and devstack ovn).\nAlso depends-on doesn\u0027t work for needed openstackclient upstream bump [1] that has the tested fix, waiting for [1] to be merged.\n\n[1] 942104: Release python-openstackclient 7.3.0 branch for epoxy | https://review.opendev.org/c/openstack/releases/+/942104","commit_id":"220668cb364cdb78dcced704a468af41df49a608"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"53b9f91a7c1e8725b72e4536648af331980fb141","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d79c04c2_0febdb16","updated":"2025-02-19 14:13:49.000000000","message":"recheck openstackclient bump merged :)","commit_id":"220668cb364cdb78dcced704a468af41df49a608"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"53b28a66a8b6ae86ad951f7ea5a3bef930bb908d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"96aa1158_dc83f8cb","updated":"2025-02-20 09:02:28.000000000","message":"Devstack job fixed.\nNow we have to wait for another requirements [1] to merge, since depends-on here doesn\u0027t affect whitebox upstream job [2].\n\nSorry folks for adding reviewers too early, I didn\u0027t anticipate CI issues with openstackclient fix availability.\n\n[1] https://review.opendev.org/c/openstack/requirements/+/942194\n[2] https://github.com/openstack-k8s-operators/ci-framework/blob/main/zuul.d/whitebox_neutron_tempest_jobs.yaml","commit_id":"7bcd9e9c345dee30e68d8bc9e505a0021f197568"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"bb36157b9e0f712cd4248ad879263d5e4094f932","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a98502b0_e9ea4a20","updated":"2025-02-24 08:23:36.000000000","message":"recheck since bump merged: https://review.opendev.org/c/openstack/requirements/+/942491","commit_id":"7bcd9e9c345dee30e68d8bc9e505a0021f197568"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"d75773d5144766f04f821e1e6f3871d37e53f90b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7251fd49_b3512d29","updated":"2025-02-25 12:31:30.000000000","message":"iiuc currently RDO promotion needed to have tested fix (openstackclient bump) in whitebox job, waiting","commit_id":"bfd7b71bb46c469433831b08d18f8c82fb5de7e2"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"7676742b4c56cc138fec6c9cce28d54fc2736df9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7799c3b5_87f6e795","updated":"2025-02-27 15:04:35.000000000","message":"recheck","commit_id":"bfd7b71bb46c469433831b08d18f8c82fb5de7e2"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"6e82b6295ca5a27ee7013a9ebd55f08e667b5ed3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e7aede84_ec4bb2cf","updated":"2025-03-02 11:19:37.000000000","message":"recheck if new rpm with fix applied","commit_id":"bfd7b71bb46c469433831b08d18f8c82fb5de7e2"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"bd6e092f9a905e36721baffb9e25bdfa812991e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0d8f1ce6_76a7cfd5","updated":"2025-03-06 11:35:10.000000000","message":"Ready for review (gates handled)","commit_id":"f00eb5e9d7cea804e663165973ab35c892110b29"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"02019d00f08710d3315b822eae7487528ab2563c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2d8682ba_4fac8aaa","updated":"2025-03-05 17:16:39.000000000","message":"`depends on` doesn\u0027t work for 3rd party rdo whitebox job, waiting for skip on antelope to be merged:\nhttps://github.com/openstack-k8s-operators/ci-framework/pull/2775","commit_id":"f00eb5e9d7cea804e663165973ab35c892110b29"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"91fbeb636fff833d9e26e93f267e93ea340b3250","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1600fccd_6ac2c932","updated":"2025-03-06 06:48:13.000000000","message":"check-rdo","commit_id":"f00eb5e9d7cea804e663165973ab35c892110b29"}],"whitebox_neutron_tempest_plugin/tests/scenario/test_ports.py":[{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"4df7175e5711b3fe1e56a3856dcc50528ec26ca4","unresolved":true,"context_lines":[{"line_number":178,"context_line":"               ).format(prefix, vm[\u0027id\u0027])"},{"line_number":179,"context_line":"        # validates correct security group uuid in output"},{"line_number":180,"context_line":"        self.validate_command("},{"line_number":181,"context_line":"            \u0027bash -c \"\u0027 + cmd + \u0027\"\u0027,"},{"line_number":182,"context_line":"            self.secgroup[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"a8becc04_58e291a8","line":181,"range":{"start_line":181,"start_character":13,"end_line":181,"end_character":21},"updated":"2025-02-17 15:54:39.000000000","message":"I see in some part of the code we call `validate_command` with `bash -c` and in others we just run the openstack commands directly. It would be nice to follow a common criteria always.","commit_id":"73cb6503561244a2928a1f0c55fbbd33e90a00cb"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"938be7cc983b4aaaf0e15ba562cd3fb58256e6b1","unresolved":false,"context_lines":[{"line_number":178,"context_line":"               ).format(prefix, vm[\u0027id\u0027])"},{"line_number":179,"context_line":"        # validates correct security group uuid in output"},{"line_number":180,"context_line":"        self.validate_command("},{"line_number":181,"context_line":"            \u0027bash -c \"\u0027 + cmd + \u0027\"\u0027,"},{"line_number":182,"context_line":"            self.secgroup[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"79e8d640_ad7220b5","line":181,"range":{"start_line":181,"start_character":13,"end_line":181,"end_character":21},"in_reply_to":"63484578_5e0fe207","updated":"2025-02-20 09:03:11.000000000","message":"Resolved","commit_id":"73cb6503561244a2928a1f0c55fbbd33e90a00cb"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"f7480b1b876e306d688cf6525f704623f1dfb60f","unresolved":true,"context_lines":[{"line_number":178,"context_line":"               ).format(prefix, vm[\u0027id\u0027])"},{"line_number":179,"context_line":"        # validates correct security group uuid in output"},{"line_number":180,"context_line":"        self.validate_command("},{"line_number":181,"context_line":"            \u0027bash -c \"\u0027 + cmd + \u0027\"\u0027,"},{"line_number":182,"context_line":"            self.secgroup[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"63484578_5e0fe207","line":181,"range":{"start_line":181,"start_character":13,"end_line":181,"end_character":21},"in_reply_to":"6a76f215_48036898","updated":"2025-02-18 16:15:49.000000000","message":"I also remember it failed in other place for test, and seemed Roman used it as well for non `oc rsh` cases, so lets keep it as argument.","commit_id":"73cb6503561244a2928a1f0c55fbbd33e90a00cb"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"c8bff1f4b163336059edda70657806e225146d1c","unresolved":true,"context_lines":[{"line_number":178,"context_line":"               ).format(prefix, vm[\u0027id\u0027])"},{"line_number":179,"context_line":"        # validates correct security group uuid in output"},{"line_number":180,"context_line":"        self.validate_command("},{"line_number":181,"context_line":"            \u0027bash -c \"\u0027 + cmd + \u0027\"\u0027,"},{"line_number":182,"context_line":"            self.secgroup[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"f381affd_dd619385","line":181,"range":{"start_line":181,"start_character":13,"end_line":181,"end_character":21},"in_reply_to":"a8becc04_58e291a8","updated":"2025-02-18 09:39:37.000000000","message":"I think its a good idea.\nThe bash encapsulating the command was due to some issue in the past, not sure what it was by now, maybe sh used by default but not compatible with the command used, maybe something else.\nOn the other hand - removing it allows single/double quotes command flexibility for sh/bash.  \nI can make a boolean argument with default value, such as `force_bash\u003dTrue`, and would be overriden to `False` only if the extra flexibility needed, to prioritise stability where it used to fail.\n\nUploading soon.","commit_id":"73cb6503561244a2928a1f0c55fbbd33e90a00cb"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"918e0f7106cdc3ef35a52e937b3357089937c63d","unresolved":true,"context_lines":[{"line_number":178,"context_line":"               ).format(prefix, vm[\u0027id\u0027])"},{"line_number":179,"context_line":"        # validates correct security group uuid in output"},{"line_number":180,"context_line":"        self.validate_command("},{"line_number":181,"context_line":"            \u0027bash -c \"\u0027 + cmd + \u0027\"\u0027,"},{"line_number":182,"context_line":"            self.secgroup[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"6a76f215_48036898","line":181,"range":{"start_line":181,"start_character":13,"end_line":181,"end_character":21},"in_reply_to":"f381affd_dd619385","updated":"2025-02-18 16:08:36.000000000","message":"Actually most cases don\u0027t use that and were fine so far, so I will set default value to `True`.\n\nAlso I think I found the reason and issue it handles, as note suggests:\nhttps://opendev.org/x/whitebox-neutron-tempest-plugin/src/branch/master/whitebox_neutron_tempest_plugin/tests/scenario/base.py#L432","commit_id":"73cb6503561244a2928a1f0c55fbbd33e90a00cb"}]}