)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"174ec8d3914fca7abbb783497d6787e065b0bb4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"256be38b_c34f58ef","updated":"2025-05-29 20:03:36.000000000","message":"Failure on whitebox-neutron-tempest-plugin-ovn-single-thread is: neutron_tempest_plugin.common.utils.SSHExecCommandFailed: Command \u0027sudo systemctl restart \u0027 failed, exit status: 1, stderr","commit_id":"c1a99ef87dc85f039cb46ae6fe558c2e168b6e7d"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"913ccc4a051d3e979278c32ec7ff72a658ea1f55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"de181dd9_1272a757","updated":"2025-05-29 15:45:12.000000000","message":"recheck - Tested d/s, DVR tests passed correctly","commit_id":"c1a99ef87dc85f039cb46ae6fe558c2e168b6e7d"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"c342293247946b7e1f1dd708a2df184495cf7ac7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e0f81432_55b394c0","updated":"2025-06-16 13:54:16.000000000","message":"recheck - https://review.opendev.org/c/x/whitebox-neutron-tempest-plugin/+/951264 was merged","commit_id":"c1a99ef87dc85f039cb46ae6fe558c2e168b6e7d"}],"whitebox_neutron_tempest_plugin/tests/scenario/test_dvr_ovn.py":[{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"a417d50f665e23e263b3a3b1d53bfbb7d72e292f","unresolved":true,"context_lines":[{"line_number":279,"context_line":"            floating_network_id\u003dCONF.network.public_network_id)[\u0027floatingip\u0027]"},{"line_number":280,"context_line":"        fip_port_mac \u003d self.get_fip_port_details(fip)[\u0027mac_address\u0027]"},{"line_number":281,"context_line":"        # Add sleep to ensure changes are applied"},{"line_number":282,"context_line":"        time.sleep(5)"},{"line_number":283,"context_line":"        self.check_north_south_icmp_flow("},{"line_number":284,"context_line":"            dst_ip\u003dfip[\u0027floating_ip_address\u0027],"},{"line_number":285,"context_line":"            expected_routing_nodes\u003dexpected_routing_nodes,"}],"source_content_type":"text/x-python","patch_set":2,"id":"f70a7f7b_6136feb9","line":282,"updated":"2025-06-23 14:22:55.000000000","message":"The tests already sleep(2) between tcpdump processes start and traffic is send [1] and sleep(5) between traffic finishes and tcpdump proccesses stop.\nAre we sure we need more sleep?\nIf so, I would advice to increase the sleep from [1], instead of adding these sleeps per test.\n\n\n\n[1] https://opendev.org/x/whitebox-neutron-tempest-plugin/src/branch/master/whitebox_neutron_tempest_plugin/tests/scenario/base.py#L1166\n[2] https://opendev.org/x/whitebox-neutron-tempest-plugin/src/branch/master/whitebox_neutron_tempest_plugin/tests/scenario/base.py#L1268","commit_id":"5113a45e38a540be380ecbc0f30c6162a0ecdd16"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"1b9a40b951c1bd6745ad6c9176f29298df1f2b25","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            floating_network_id\u003dCONF.network.public_network_id)[\u0027floatingip\u0027]"},{"line_number":280,"context_line":"        fip_port_mac \u003d self.get_fip_port_details(fip)[\u0027mac_address\u0027]"},{"line_number":281,"context_line":"        # Add sleep to ensure changes are applied"},{"line_number":282,"context_line":"        time.sleep(5)"},{"line_number":283,"context_line":"        self.check_north_south_icmp_flow("},{"line_number":284,"context_line":"            dst_ip\u003dfip[\u0027floating_ip_address\u0027],"},{"line_number":285,"context_line":"            expected_routing_nodes\u003dexpected_routing_nodes,"}],"source_content_type":"text/x-python","patch_set":2,"id":"71ffd341_95619523","line":282,"in_reply_to":"f70a7f7b_6136feb9","updated":"2025-06-24 12:23:40.000000000","message":"I have reviewed again logs and patch and now I think the patch is fine. I\u0027m going to approve it.\n\nThis change only applies after FIP is deleted or added again to a VM.","commit_id":"5113a45e38a540be380ecbc0f30c6162a0ecdd16"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"77e8ffe7cd4eb8e430df7c312d8f75796d7e5942","unresolved":true,"context_lines":[{"line_number":280,"context_line":"        fip_port_mac \u003d self.get_fip_port_details(fip)[\u0027mac_address\u0027]"},{"line_number":281,"context_line":"        # Add sleep to ensure changes are applied"},{"line_number":282,"context_line":"        time.sleep(5)"},{"line_number":283,"context_line":"        self.check_north_south_icmp_flow("},{"line_number":284,"context_line":"            dst_ip\u003dfip[\u0027floating_ip_address\u0027],"},{"line_number":285,"context_line":"            expected_routing_nodes\u003dexpected_routing_nodes,"},{"line_number":286,"context_line":"            expected_mac\u003dfip_port_mac,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3d6e3a1a_314aeaac","line":283,"range":{"start_line":283,"start_character":13,"end_line":283,"end_character":40},"updated":"2025-06-25 15:37:06.000000000","message":"Just a note for future changes, noticed all sleeps are added a line before `check_north_south_icmp_flow` which is common test method from base.py file in `TrafficFlowTest` class, maybe sleep can be added to method instead, also for other similar flaky cases (current and future).","commit_id":"5113a45e38a540be380ecbc0f30c6162a0ecdd16"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"a01eeb508aabeffcd2485b8d4eb977dd94c67800","unresolved":true,"context_lines":[{"line_number":280,"context_line":"        fip_port_mac \u003d self.get_fip_port_details(fip)[\u0027mac_address\u0027]"},{"line_number":281,"context_line":"        # Add sleep to ensure changes are applied"},{"line_number":282,"context_line":"        time.sleep(5)"},{"line_number":283,"context_line":"        self.check_north_south_icmp_flow("},{"line_number":284,"context_line":"            dst_ip\u003dfip[\u0027floating_ip_address\u0027],"},{"line_number":285,"context_line":"            expected_routing_nodes\u003dexpected_routing_nodes,"},{"line_number":286,"context_line":"            expected_mac\u003dfip_port_mac,"}],"source_content_type":"text/x-python","patch_set":2,"id":"2824fbe1_487b36a4","line":283,"range":{"start_line":283,"start_character":13,"end_line":283,"end_character":40},"in_reply_to":"3d6e3a1a_314aeaac","updated":"2025-06-25 15:39:40.000000000","message":"or maybe have argument to allow sleep time with certain default, if this is a common timing issue","commit_id":"5113a45e38a540be380ecbc0f30c6162a0ecdd16"}]}
