)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"c08683ae3b03ca23aa4f7a36b3e4e3840bc4073a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"632b3254_1633f3d9","updated":"2025-12-23 17:02:37.000000000","message":"Thank you for the changes, generally looks good to me, but setting -2 to have some concerns in comments addressed before merging","commit_id":"a90ed1fa7c36f271394784688fa151d012e6dfc3"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"ffb058d121557bb9d39cea1a91bc0442a10bb383","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8729d76e_5f96cdcf","updated":"2025-12-17 07:20:30.000000000","message":"recheck","commit_id":"a90ed1fa7c36f271394784688fa151d012e6dfc3"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"c0852be5e3f591f4fb9d42bf47d80e2e46816801","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9815373f_3eb048f6","updated":"2025-12-23 13:20:44.000000000","message":"recheck","commit_id":"a90ed1fa7c36f271394784688fa151d012e6dfc3"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"e3c4fedf1bcf9a0e074fc2c8c833972f73d586db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ca252f48_6d16b2c0","updated":"2025-12-16 11:12:37.000000000","message":"recheck","commit_id":"a90ed1fa7c36f271394784688fa151d012e6dfc3"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"ae0f5cf8237b2ba38756907b4875211272b6d3f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e174fed2_ceec4925","updated":"2025-12-23 11:16:54.000000000","message":"recheck","commit_id":"a90ed1fa7c36f271394784688fa151d012e6dfc3"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"2f7776d0a8fb0c11c7bf3ffffd8321b0fd510662","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ea23bc84_b8c7b13a","updated":"2025-12-16 12:51:27.000000000","message":"recheck","commit_id":"a90ed1fa7c36f271394784688fa151d012e6dfc3"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"cdd578b9751f5ff6ac6516565d704233e1c36189","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f8179384_f1827df2","updated":"2025-12-23 16:08:16.000000000","message":"recheck","commit_id":"a90ed1fa7c36f271394784688fa151d012e6dfc3"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"adf4303c86f0674fff86417447ca3aeba0aef799","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9e320389_a1a035ba","updated":"2025-12-23 11:18:14.000000000","message":"recheck whitebox_neutron_tempest_plugin.tests.scenario.test_mtu.GatewayMtuTestIcmp.test_northbound_pmtud_icmp","commit_id":"a90ed1fa7c36f271394784688fa151d012e6dfc3"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"691d35108642680d8956c87ad78d7ecfa999b3a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"421cf794_1aa70b38","updated":"2026-01-12 14:55:24.000000000","message":"Looks good to me, thank you for the changes","commit_id":"2fce6035d6c675c4e6f288554a7948539a2f1cf2"}],"whitebox_neutron_tempest_plugin/tests/scenario/base.py":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"c08683ae3b03ca23aa4f7a36b3e4e3840bc4073a","unresolved":true,"context_lines":[{"line_number":534,"context_line":"    @classmethod"},{"line_number":535,"context_line":"    def _verify_neutron_agents_health(cls, host\u003dNone):"},{"line_number":536,"context_line":"        try:"},{"line_number":537,"context_line":"            agents \u003d cls.os_admin.network_client.list_agents()[\u0027agents\u0027]"},{"line_number":538,"context_line":"            if host:"},{"line_number":539,"context_line":"                agents \u003d [agent for agent in agents if agent[\u0027host\u0027] \u003d\u003d host]"},{"line_number":540,"context_line":"            if not agents:"}],"source_content_type":"text/x-python","patch_set":1,"id":"022d23be_e80f1230","line":537,"updated":"2025-12-23 17:02:37.000000000","message":"`try` block should be on least code, only code relevant to catch specific exception(s), only on line of 537 API call, unless there is valid reason for it to be on rest of the lines.","commit_id":"a90ed1fa7c36f271394784688fa151d012e6dfc3"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"c08683ae3b03ca23aa4f7a36b3e4e3840bc4073a","unresolved":true,"context_lines":[{"line_number":552,"context_line":"            LOG.debug(\"All neutron agents are healthy for host: %s\","},{"line_number":553,"context_line":"                      host or \"all hosts\")"},{"line_number":554,"context_line":"            return True"},{"line_number":555,"context_line":"        except Exception as e:"},{"line_number":556,"context_line":"            LOG.debug(\"Failed to check neutron agents: %s\", e)"},{"line_number":557,"context_line":"            return False"},{"line_number":558,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e60057f2_74d0575d","line":555,"range":{"start_line":555,"start_character":15,"end_line":555,"end_character":24},"updated":"2025-12-23 17:02:37.000000000","message":"What is expected more specifically to be caught here? I assume REST API exception, maybe 5XX server issue until neutron server/pod is ready, etc something more specific like exceptions [1] or others.\n\nIt is better having more specific exception(s) caught so we son\u0027t dismiss future issues which can be caught in automated tests.\n\n[1]\nhttps://opendev.org/openstack/tempest/src/branch/master/tempest/exceptions.py\nhttps://opendev.org/openstack/tempest/src/branch/master/tempest/lib/exceptions.py","commit_id":"a90ed1fa7c36f271394784688fa151d012e6dfc3"}]}