)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"62a80e2eb7c1df73b49a592c1f6358d14e4dbf15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"890e1026_a7e57034","updated":"2026-02-23 13:39:55.000000000","message":"Tests failures were not related to metadata-rate-limiting","commit_id":"816a275d544a033a17c681407e1e88ac80b4ca17"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7a3d7ca7f0c169f09f3c711ca08096bd2a0af8bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0f9e577e_c7744904","updated":"2026-02-23 11:49:05.000000000","message":"We have another problem related to this path change: the `bgp_agent_config` refers to the whole path (`/var/lib/config-data/ansible-generated/ovn-bgp-agent/etc/ovn-bgp-agent/bgp-agent.conf`). You should push another patch to fix it, maybe just passing `etc/ovn-bgp-agent/bgp-agent.conf` and being the FW the one in charge of finding the correct location of the generated configs.","commit_id":"816a275d544a033a17c681407e1e88ac80b4ca17"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"e1af9f4dc942028fa3d5882c49acafe393b7204f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a9626e96_320ae359","updated":"2026-02-23 12:34:14.000000000","message":"lgtm, was it tested on podified setup?","commit_id":"816a275d544a033a17c681407e1e88ac80b4ca17"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"38e2ca7cf042b0759a0787426f6de65a5d2b42fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"47c8ae93_0064bd5c","updated":"2026-02-23 14:20:31.000000000","message":"recheck unrelated test failuers","commit_id":"816a275d544a033a17c681407e1e88ac80b4ca17"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"150a0f8ed9a1ef42df9296ee58cf00b57aca6f4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b0d28ffc_71581d48","updated":"2026-02-23 14:19:59.000000000","message":"thanks, lgtm.\nare we waiting on some patch changes? or they\u0027re planned for future patches (to +1 workflow)?","commit_id":"816a275d544a033a17c681407e1e88ac80b4ca17"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"ccf6e0ac894198666ff353013668042037dd75ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4d28ffcf_b9c5da52","in_reply_to":"8ab25915_8ffecb38","updated":"2026-02-23 15:04:28.000000000","message":"Sure, seems good to me, but why not have also few values possible so test/job won\u0027t fail and block CI?\nfor example also having a list with few values, or string comma separated (to have more control internally parsed than oslo configuration - I recall some issues with oslo configuration).\n\nAlso noticed occurrence in `whitebox_neutron_tempest_plugin/tests/scenario/test_sriov_provider_network.py` line 192, could benefit from such change.\n\nLastly `default_config_root_dir` maybe prefix `compute_` to something like that, seems related in existing contexts to computes only, but maybe missing something.","commit_id":"816a275d544a033a17c681407e1e88ac80b4ca17"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"62a80e2eb7c1df73b49a592c1f6358d14e4dbf15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"664a5f47_a1dc9497","in_reply_to":"a9626e96_320ae359","updated":"2026-02-23 13:39:55.000000000","message":"Yes","commit_id":"816a275d544a033a17c681407e1e88ac80b4ca17"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"b483fd515acd743d91bc7326b73e5199b0ca3726","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ddabf507_652fc67c","in_reply_to":"b0d28ffc_71581d48","updated":"2026-02-23 14:36:58.000000000","message":"As rodolfo said, I\u0027m looking at bgp, which can have the same problem, either we can merge this one and I\u0027ll followup for BGP, or I can enhance this one","commit_id":"816a275d544a033a17c681407e1e88ac80b4ca17"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"495fe6f569e988eb468a53cd1d209f8e2c967795","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f29f1dc7_b89b903d","in_reply_to":"ddabf507_652fc67c","updated":"2026-02-23 14:40:27.000000000","message":"I don\u0027t mind either, if change isn\u0027t expected to be that different or bigger.\nI think since CI isn\u0027t stable recently here, I would add it easily merge both, but whichever you prefer.","commit_id":"816a275d544a033a17c681407e1e88ac80b4ca17"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"454f884f3ea420fe09b54ccd25e0e1a2b2477e16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8ab25915_8ffecb38","in_reply_to":"f29f1dc7_b89b903d","updated":"2026-02-23 14:52:53.000000000","message":"I\u0027ve talk with eolivares, he thinks that it would be best to have a common path, for metadata_rate_limit and bgp. \nThe idea now is create a variable which will be \"default_config_root_dir: /var/lib/config/data/ansible-generated\", and all classes that needs to modify/look the config, will use relative paths from default_config_root_dir. (whenever edpm-ansible code changes the path, by only modifying this variable tests will work again) (Also fixing the optimization Rodolfo suggested to only look once, this way there\u0027s no look-up needed)","commit_id":"816a275d544a033a17c681407e1e88ac80b4ca17"}],"whitebox_neutron_tempest_plugin/tests/scenario/test_metadata_rate_limiting.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"182f38cd18dce3777d7b958aaa46c39f5e70bb61","unresolved":true,"context_lines":[{"line_number":55,"context_line":"                \u0027/var/lib/config-data/ansible-generated/\u0027"},{"line_number":56,"context_line":"                \u0027neutron-ovn-metadata-agent/\u0027"},{"line_number":57,"context_line":"                \u002701-neutron-ovn-metadata-agent.conf\u0027,"},{"line_number":58,"context_line":"                \u0027/var/lib/openstack/\u0027"},{"line_number":59,"context_line":"                \u0027neutron-ovn-metadata-agent/\u0027"},{"line_number":60,"context_line":"                \u002701-neutron-ovn-metadata-agent.conf\u0027,"},{"line_number":61,"context_line":"            ]"},{"line_number":62,"context_line":"            for path in possible_paths:"},{"line_number":63,"context_line":"                # Use the SSH client from the node to check file existance"}],"source_content_type":"text/x-python","patch_set":1,"id":"c79952cd_05c64120","line":60,"range":{"start_line":58,"start_character":16,"end_line":60,"end_character":53},"updated":"2026-02-19 14:19:48.000000000","message":"Why not this one first? `/var/lib/openstack/` is the new default directory so it should be tested first.\n\nWhy not storing the \"good\" directory? Just to void retries.","commit_id":"bd9c2346b1607cf27ca6ff5b9737eb3cc93e3460"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7a3d7ca7f0c169f09f3c711ca08096bd2a0af8bc","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                \u0027/var/lib/config-data/ansible-generated/\u0027"},{"line_number":56,"context_line":"                \u0027neutron-ovn-metadata-agent/\u0027"},{"line_number":57,"context_line":"                \u002701-neutron-ovn-metadata-agent.conf\u0027,"},{"line_number":58,"context_line":"                \u0027/var/lib/openstack/\u0027"},{"line_number":59,"context_line":"                \u0027neutron-ovn-metadata-agent/\u0027"},{"line_number":60,"context_line":"                \u002701-neutron-ovn-metadata-agent.conf\u0027,"},{"line_number":61,"context_line":"            ]"},{"line_number":62,"context_line":"            for path in possible_paths:"},{"line_number":63,"context_line":"                # Use the SSH client from the node to check file existance"}],"source_content_type":"text/x-python","patch_set":1,"id":"af9425ab_b15714cf","line":60,"range":{"start_line":58,"start_character":16,"end_line":60,"end_character":53},"in_reply_to":"567c2101_981785ac","updated":"2026-02-23 11:49:05.000000000","message":"We will execute this method several times, once per testing method in this class. Instead of testing what is the correct directory, it would be better to store it and reuse it the next time.\n\nIn any case, that could be an optimization.","commit_id":"bd9c2346b1607cf27ca6ff5b9737eb3cc93e3460"},{"author":{"_account_id":34118,"name":"Arnau Verdaguer","email":"averdagu@redhat.com","username":"averdaguer"},"change_message_id":"aea2150ba452ccb5c736b0125cece8771f5d4feb","unresolved":true,"context_lines":[{"line_number":55,"context_line":"                \u0027/var/lib/config-data/ansible-generated/\u0027"},{"line_number":56,"context_line":"                \u0027neutron-ovn-metadata-agent/\u0027"},{"line_number":57,"context_line":"                \u002701-neutron-ovn-metadata-agent.conf\u0027,"},{"line_number":58,"context_line":"                \u0027/var/lib/openstack/\u0027"},{"line_number":59,"context_line":"                \u0027neutron-ovn-metadata-agent/\u0027"},{"line_number":60,"context_line":"                \u002701-neutron-ovn-metadata-agent.conf\u0027,"},{"line_number":61,"context_line":"            ]"},{"line_number":62,"context_line":"            for path in possible_paths:"},{"line_number":63,"context_line":"                # Use the SSH client from the node to check file existance"}],"source_content_type":"text/x-python","patch_set":1,"id":"567c2101_981785ac","line":60,"range":{"start_line":58,"start_character":16,"end_line":60,"end_character":53},"in_reply_to":"c79952cd_05c64120","updated":"2026-02-19 15:35:19.000000000","message":"I added first the one in downstream since I think it\u0027s the only way where it\u0027s triggered. I check job \"whitebox-neutron-tempest-plugin-podified-multinode-edpm-deployment-crc-2comp\" and it\u0027s not triggering the test_metadata_rate_limit tests.\nThat\u0027s why we haven\u0027t seen this issue upstream eventhough edpm change was done \u003e3 months ago.\nI fail to understand the question regarding storing the good directory.","commit_id":"bd9c2346b1607cf27ca6ff5b9737eb3cc93e3460"}]}
