)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"db9ce76ede17779ff7d0e47e045a8a06ef4ebc2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"99d654b8_5a7dcb67","updated":"2026-05-19 13:53:21.000000000","message":"Thanks Edu! only some small nit comments.","commit_id":"804705ae215bd293b2d0d6e3ffd9265112b162f4"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"e2494c2abe372949874f197a24be424d50f4cac2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"356e96fd_81c71d61","updated":"2026-05-19 13:42:35.000000000","message":"mtu tests passed\nhttps://zuul.opendev.org/t/openstack/build/52d695c56e8d4042b66aeef5f9972b97\n\nand the new method to test udp traffic was used:\nhttps://cf7854112bb0d6fc22f2-2a1119ffb990d5655d2006b333255d45.ssl.cf1.rackcdn.com/openstack/52d695c56e8d4042b66aeef5f9972b97/controller/logs/tempest_log.txt\n```\n2026-05-19 12:18:50.340 87456 DEBUG whitebox_neutron_tempest_plugin.common.utils [-] Starting nc client: \u0027python3 -c \"import socket; s \u003d socket.socket(socket.AF_INET, socket.SOCK_DGRAM); s.sendto(open(\u00271344\u0027, \u0027rb\u0027).read(), (\u0027172.24.5.186\u0027, 65000))\"\u0027 run_ncat_client /opt/stack/tempest/.tox/tempest/lib/python3.12/site-packages/whitebox_neutron_tempest_plugin/common/utils.py:290\n```","commit_id":"804705ae215bd293b2d0d6e3ffd9265112b162f4"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"281e08e424527a7240ab3c01a31c9acaf2c0e2aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"688b3470_c30d15d3","updated":"2026-05-19 17:50:54.000000000","message":"recheck unrelated failures","commit_id":"d6e0628062bc3e03e052b623771baa3f65d3e5d4"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"e67c41033627acbd8a0f81513a143022b51adc9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cc35838e_79655586","updated":"2026-05-19 15:07:48.000000000","message":"tnx","commit_id":"d6e0628062bc3e03e052b623771baa3f65d3e5d4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"259ec7f25d0a1dff1272eea5a4b8da1e6ba19db5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6756eebf_4e176640","updated":"2026-05-20 12:43:33.000000000","message":"We need https://review.opendev.org/c/openstack/neutron/+/989360 merged","commit_id":"2c9ea52c98e55185c40e32154af7e427a3850dc1"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"2f30c347bec530b6a93e2a56c3d4dc0ef12cee21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"dd464c73_63dcabbd","in_reply_to":"6756eebf_4e176640","updated":"2026-05-20 13:45:54.000000000","message":"since we are facing an issue on devstack jobs with master neutron branch, depends on may help speed up testing here in commit message, wdyt?","commit_id":"2c9ea52c98e55185c40e32154af7e427a3850dc1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cf6e38e0cd718551c54d1c58158be8d0d1865e47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"30e91b89_ac897845","updated":"2026-05-20 15:08:06.000000000","message":"CI tests passing now","commit_id":"c2dd6eb67b790997917c6c718bd04fbcc79103f1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"09009391ae71a8f5768dda39b036b6735a65664e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"85057b50_3c40c809","updated":"2026-05-21 10:35:40.000000000","message":"Neutron patch merged","commit_id":"c2dd6eb67b790997917c6c718bd04fbcc79103f1"}],"whitebox_neutron_tempest_plugin/common/utils.py":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"db9ce76ede17779ff7d0e47e045a8a06ef4ebc2d","unresolved":true,"context_lines":[{"line_number":282,"context_line":"            \"s \u003d socket.socket(socket.AF_INET, socket.SOCK_DGRAM); \""},{"line_number":283,"context_line":"            \"s.sendto(open(\u0027{file}\u0027, \u0027rb\u0027).read(), \""},{"line_number":284,"context_line":"            \"(\u0027{host}\u0027, {port}))\\\"\").format("},{"line_number":285,"context_line":"            file\u003dpayload_size, host\u003dhost,"},{"line_number":286,"context_line":"            port\u003dconstants.NCAT_PORT)"},{"line_number":287,"context_line":"    else:"},{"line_number":288,"context_line":"        cmd \u003d \"nc -w 1 {0} {1} \u003c {2}\".format("}],"source_content_type":"text/x-python","patch_set":1,"id":"1d85f4e3_1a5cf4d2","line":285,"range":{"start_line":285,"start_character":17,"end_line":285,"end_character":29},"updated":"2026-05-19 13:53:21.000000000","message":"nit: this should be `payload_size` as filename? not a filename clearer for debugging?\nlogs show [1].\n\n[1]\nhttps://cf7854112bb0d6fc22f2-2a1119ffb990d5655d2006b333255d45.ssl.cf1.rackcdn.com/openstack/52d695c56e8d4042b66aeef5f9972b97/controller/logs/tempest_log.txt\n```\n2026-05-19 12:18:50.340 87456 DEBUG whitebox_neutron_tempest_plugin.common.utils [-] Starting nc client: \u0027python3 -c \"import socket; s \u003d socket.socket(socket.AF_INET, socket.SOCK_DGRAM); s.sendto(open(\u00271344\u0027, \u0027rb\u0027).read(), (\u0027172.24.5.186\u0027, 65000))\"\u0027 run_ncat_client /opt/stack/tempest/.tox/tempest/lib/python3.12/site-packages/whitebox_neutron_tempest_plugin/common/utils.py:290\n```","commit_id":"804705ae215bd293b2d0d6e3ffd9265112b162f4"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"281e08e424527a7240ab3c01a31c9acaf2c0e2aa","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            \"s \u003d socket.socket(socket.AF_INET, socket.SOCK_DGRAM); \""},{"line_number":283,"context_line":"            \"s.sendto(open(\u0027{file}\u0027, \u0027rb\u0027).read(), \""},{"line_number":284,"context_line":"            \"(\u0027{host}\u0027, {port}))\\\"\").format("},{"line_number":285,"context_line":"            file\u003dpayload_size, host\u003dhost,"},{"line_number":286,"context_line":"            port\u003dconstants.NCAT_PORT)"},{"line_number":287,"context_line":"    else:"},{"line_number":288,"context_line":"        cmd \u003d \"nc -w 1 {0} {1} \u003c {2}\".format("}],"source_content_type":"text/x-python","patch_set":1,"id":"6a789580_a2a0c547","line":285,"range":{"start_line":285,"start_character":17,"end_line":285,"end_character":29},"in_reply_to":"1d85f4e3_1a5cf4d2","updated":"2026-05-19 17:50:54.000000000","message":"Done","commit_id":"804705ae215bd293b2d0d6e3ffd9265112b162f4"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"db9ce76ede17779ff7d0e47e045a8a06ef4ebc2d","unresolved":true,"context_lines":[{"line_number":287,"context_line":"    else:"},{"line_number":288,"context_line":"        cmd \u003d \"nc -w 1 {0} {1} \u003c {2}\".format("},{"line_number":289,"context_line":"            host, constants.NCAT_PORT, payload_size)"},{"line_number":290,"context_line":"    LOG.debug(\"Starting nc client: \u0027%s\u0027\", cmd)"},{"line_number":291,"context_line":"    ssh_client.exec_command(cmd)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"444c1949_5add5ec0","line":290,"range":{"start_line":290,"start_character":24,"end_line":290,"end_character":26},"updated":"2026-05-19 13:53:21.000000000","message":"nit: log entry not always uses netcat since python option added","commit_id":"804705ae215bd293b2d0d6e3ffd9265112b162f4"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"281e08e424527a7240ab3c01a31c9acaf2c0e2aa","unresolved":false,"context_lines":[{"line_number":287,"context_line":"    else:"},{"line_number":288,"context_line":"        cmd \u003d \"nc -w 1 {0} {1} \u003c {2}\".format("},{"line_number":289,"context_line":"            host, constants.NCAT_PORT, payload_size)"},{"line_number":290,"context_line":"    LOG.debug(\"Starting nc client: \u0027%s\u0027\", cmd)"},{"line_number":291,"context_line":"    ssh_client.exec_command(cmd)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fc30e723_b257206e","line":290,"range":{"start_line":290,"start_character":24,"end_line":290,"end_character":26},"in_reply_to":"444c1949_5add5ec0","updated":"2026-05-19 17:50:54.000000000","message":"Done","commit_id":"804705ae215bd293b2d0d6e3ffd9265112b162f4"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"6afd621d81ec0dad1bba2328c382196918209018","unresolved":true,"context_lines":[{"line_number":271,"context_line":"    return output_file"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"def send_payload_from_client(ssh_client, host, udp, payload_size):"},{"line_number":275,"context_line":"    if udp:"},{"line_number":276,"context_line":"        # ncat\u0027s read buffer (8192 bytes) splits large payloads into"},{"line_number":277,"context_line":"        # multiple UDP datagrams, breaking PMTUD tests that need a"}],"source_content_type":"text/x-python","patch_set":4,"id":"3e2ab357_3dadc69a","line":274,"range":{"start_line":274,"start_character":0,"end_line":274,"end_character":66},"updated":"2026-05-20 08:21:13.000000000","message":"nit: if already being edited, since python script instead of netcat is growing with each patchset, what about keeping it before method in multi line string (spares opening/closing parenthesis, and allows more python lines char length without linter complaining).\nSomething like this:\n```\n_UDP_SEND_SCRIPT \u003d \"\"\"\\\nimport socket\ns \u003d socket.socket(...\n... more lines ...\"\"\"\n\ndef send_payload_from_client(...\n```","commit_id":"cc5622d56eca3492a7827bf6a6de7df8fa6eb68f"}]}