)]}'
{"nodepool/driver/static/config.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"550e7922754f043e84b2e6d5682567c96d70fc9e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                \u0027connection-type\u0027: node.get(\u0027connection-type\u0027, \u0027ssh\u0027),"},{"line_number":59,"context_line":"                \u0027username\u0027: node.get(\u0027username\u0027, \u0027zuul\u0027),"},{"line_number":60,"context_line":"                \u0027max-parallel-jobs\u0027: int(node.get(\u0027max-parallel-jobs\u0027, 1)),"},{"line_number":61,"context_line":"                \u0027python-path\u0027: node.get(\u0027python-path\u0027, \u0027/usr/bin/python2\u0027),"},{"line_number":62,"context_line":"            })"},{"line_number":63,"context_line":"            if isinstance(node[\u0027labels\u0027], str):"},{"line_number":64,"context_line":"                for label in node[\u0027labels\u0027].split():"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_4f584455","line":61,"range":{"start_line":61,"start_character":1,"end_line":61,"end_character":75},"updated":"2019-02-22 19:10:09.000000000","message":"I don\u0027t like that we duplicate the default value here (or the schema def below), but I get why (because static labels are a bit different). I don\u0027t have a good solution. Maybe define the default as a ConfigPoolLabel attribute that we can refer to here?","commit_id":"128682e1ca47a460da5b0af6da5ff6b2fc7ca6c0"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"8081a6f49307a2330049825cc4103876edb9213c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                \u0027connection-type\u0027: node.get(\u0027connection-type\u0027, \u0027ssh\u0027),"},{"line_number":59,"context_line":"                \u0027username\u0027: node.get(\u0027username\u0027, \u0027zuul\u0027),"},{"line_number":60,"context_line":"                \u0027max-parallel-jobs\u0027: int(node.get(\u0027max-parallel-jobs\u0027, 1)),"},{"line_number":61,"context_line":"                \u0027python-path\u0027: node.get(\u0027python-path\u0027, \u0027/usr/bin/python2\u0027),"},{"line_number":62,"context_line":"            })"},{"line_number":63,"context_line":"            if isinstance(node[\u0027labels\u0027], str):"},{"line_number":64,"context_line":"                for label in node[\u0027labels\u0027].split():"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_369755ee","line":61,"range":{"start_line":61,"start_character":1,"end_line":61,"end_character":75},"in_reply_to":"9fdfeff1_4f584455","updated":"2019-02-23 01:53:42.000000000","message":"It seems like the static driver \"label\" (called nodes) is slightly different from the other drivers as it support multiple labels per request. I think the correct implementation would be to adapt the other driver to use a similar schema. Could we please do that in follow-up though?","commit_id":"128682e1ca47a460da5b0af6da5ff6b2fc7ca6c0"}]}