)]}'
{"nodepool/driver/openstack/config.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"9406292f42283b3ffca911b8a25c1765d5fcb28c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self.auto_floating_ip \u003d True"},{"line_number":124,"context_line":"        self.host_key_checking \u003d True"},{"line_number":125,"context_line":"        self.labels \u003d None"},{"line_number":126,"context_line":"        self._networks \u003d None"},{"line_number":127,"context_line":"        # The OpenStackProviderConfig object that owns this pool."},{"line_number":128,"context_line":"        self.provider \u003d None"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_23d4cfbc","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":29},"updated":"2019-04-29 17:16:47.000000000","message":"Why the rename to use _ here? Not seeing what that buys us in the code below, and adds inconsistency to the code.","commit_id":"e6b9807b482cf08f91283e7bcebed31b299ee496"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"3a9b6e7665fd9cac60a041a9f8715fe000208801","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self.auto_floating_ip \u003d True"},{"line_number":124,"context_line":"        self.host_key_checking \u003d True"},{"line_number":125,"context_line":"        self.labels \u003d None"},{"line_number":126,"context_line":"        self._networks \u003d None"},{"line_number":127,"context_line":"        # The OpenStackProviderConfig object that owns this pool."},{"line_number":128,"context_line":"        self.provider \u003d None"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_c30ff334","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":29},"in_reply_to":"ffb9cba7_23d4cfbc","updated":"2019-04-29 17:20:56.000000000","message":"It was to flip the value to private, to help protect us using the wrong network setting now, since we have 2.  But I can revert.","commit_id":"e6b9807b482cf08f91283e7bcebed31b299ee496"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"67dbd99737b63cc3e83c161508be1220b3df6fa6","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self.auto_floating_ip \u003d True"},{"line_number":124,"context_line":"        self.host_key_checking \u003d True"},{"line_number":125,"context_line":"        self.labels \u003d None"},{"line_number":126,"context_line":"        self._networks \u003d None"},{"line_number":127,"context_line":"        # The OpenStackProviderConfig object that owns this pool."},{"line_number":128,"context_line":"        self.provider \u003d None"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_f6dd1470","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":29},"in_reply_to":"ffb9cba7_c30ff334","updated":"2019-04-29 21:23:56.000000000","message":"I get that (and have largely given up on using that convention out of frustration), but in this case, it isn\u0027t really private since a configuration NOT using networks in labels may still need to access the pool networks in some code in the present or future.","commit_id":"e6b9807b482cf08f91283e7bcebed31b299ee496"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"b0512df564922bed60e825ef9e43a855db9c7cde","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self.auto_floating_ip \u003d True"},{"line_number":124,"context_line":"        self.host_key_checking \u003d True"},{"line_number":125,"context_line":"        self.labels \u003d None"},{"line_number":126,"context_line":"        self._networks \u003d None"},{"line_number":127,"context_line":"        # The OpenStackProviderConfig object that owns this pool."},{"line_number":128,"context_line":"        self.provider \u003d None"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_f6f994c7","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":29},"in_reply_to":"ffb9cba7_f6dd1470","updated":"2019-04-29 21:30:03.000000000","message":"ack, thanks for info. In PS3, I revert back to original way.","commit_id":"e6b9807b482cf08f91283e7bcebed31b299ee496"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"9406292f42283b3ffca911b8a25c1765d5fcb28c","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            pl.instance_properties \u003d label.get(\u0027instance-properties\u0027,"},{"line_number":207,"context_line":"                                               None)"},{"line_number":208,"context_line":"            pl.userdata \u003d label.get(\u0027userdata\u0027, None)"},{"line_number":209,"context_line":"            pl.networks \u003d label.get(\u0027networks\u0027, self._networks)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"            top_label \u003d full_config.labels[pl.name]"},{"line_number":212,"context_line":"            top_label.pools.append(self)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_63c5e7f0","line":209,"range":{"start_line":209,"start_character":15,"end_line":209,"end_character":23},"updated":"2019-04-29 17:16:47.000000000","message":"This should be added to ProviderLabel class definition (and the comparison method there).","commit_id":"e6b9807b482cf08f91283e7bcebed31b299ee496"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"3a9b6e7665fd9cac60a041a9f8715fe000208801","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            pl.instance_properties \u003d label.get(\u0027instance-properties\u0027,"},{"line_number":207,"context_line":"                                               None)"},{"line_number":208,"context_line":"            pl.userdata \u003d label.get(\u0027userdata\u0027, None)"},{"line_number":209,"context_line":"            pl.networks \u003d label.get(\u0027networks\u0027, self._networks)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"            top_label \u003d full_config.labels[pl.name]"},{"line_number":212,"context_line":"            top_label.pools.append(self)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_e30c7742","line":209,"range":{"start_line":209,"start_character":15,"end_line":209,"end_character":23},"in_reply_to":"ffb9cba7_63c5e7f0","updated":"2019-04-29 17:20:56.000000000","message":"ack","commit_id":"e6b9807b482cf08f91283e7bcebed31b299ee496"}]}