)]}'
{"nodepool/builder.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d168c3b13867694fdbaf02cc8de0e7f29351d01e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    \u0027\u0027\u0027"},{"line_number":60,"context_line":"    def __init__(self, image_id, extension\u003dNone):"},{"line_number":61,"context_line":"        self.image_id \u003d image_id"},{"line_number":62,"context_line":"        self.extension \u003d extension"},{"line_number":63,"context_line":"        self.md5 \u003d None"},{"line_number":64,"context_line":"        self.md5_file \u003d None"},{"line_number":65,"context_line":"        self.sha256 \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_1f462925","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":34},"updated":"2019-05-20 21:23:32.000000000","message":"This can be removed then the if check below on 70 becomes:\n\n  if extension:\n      self.extension \u003d extension.lstrip(\u0027.\u0027)","commit_id":"c3334b769c5b9845be4967d6fef702efebcea07f"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"160e15e9aea4aed010fc132cb96198d96eed0a00","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    \u0027\u0027\u0027"},{"line_number":60,"context_line":"    def __init__(self, image_id, extension\u003dNone):"},{"line_number":61,"context_line":"        self.image_id \u003d image_id"},{"line_number":62,"context_line":"        self.extension \u003d extension"},{"line_number":63,"context_line":"        self.md5 \u003d None"},{"line_number":64,"context_line":"        self.md5_file \u003d None"},{"line_number":65,"context_line":"        self.sha256 \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_bf5fdd3f","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":34},"in_reply_to":"bfb3d3c7_1f462925","updated":"2019-05-20 21:42:48.000000000","message":"True. Will change that with next PS.","commit_id":"c3334b769c5b9845be4967d6fef702efebcea07f"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"718944e989bbffe2a29447a3ee99dc939a16092d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    \u0027\u0027\u0027"},{"line_number":60,"context_line":"    def __init__(self, image_id, extension\u003dNone):"},{"line_number":61,"context_line":"        self.image_id \u003d image_id"},{"line_number":62,"context_line":"        self.extension \u003d extension"},{"line_number":63,"context_line":"        self.md5 \u003d None"},{"line_number":64,"context_line":"        self.md5_file \u003d None"},{"line_number":65,"context_line":"        self.sha256 \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_df1cff6b","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":34},"in_reply_to":"bfb3d3c7_bf5fdd3f","updated":"2019-05-21 16:26:02.000000000","message":"I decided against that change since this way seems more logical in my mind (I didn\u0027t like the resulting code).","commit_id":"c3334b769c5b9845be4967d6fef702efebcea07f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d168c3b13867694fdbaf02cc8de0e7f29351d01e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def from_path(path):"},{"line_number":75,"context_line":"        if isinstance(path, str):"},{"line_number":76,"context_line":"            path \u003d Path(path)"},{"line_number":77,"context_line":"        return DibImageFile(path.stem, path.suffix)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @staticmethod"},{"line_number":80,"context_line":"    def from_image_id(images_dir, image_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_7f02c5b6","line":77,"range":{"start_line":77,"start_character":28,"end_line":77,"end_character":50},"updated":"2019-05-20 21:23:32.000000000","message":"Note there is a slight change in behavior here with the old code. Previously foo.qcow2.md5 would be rsplit resulting in foo and qcow2.md5 but with .stem and .suffix you\u0027ll get foo.qcow1 and md5.","commit_id":"c3334b769c5b9845be4967d6fef702efebcea07f"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"160e15e9aea4aed010fc132cb96198d96eed0a00","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def from_path(path):"},{"line_number":75,"context_line":"        if isinstance(path, str):"},{"line_number":76,"context_line":"            path \u003d Path(path)"},{"line_number":77,"context_line":"        return DibImageFile(path.stem, path.suffix)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @staticmethod"},{"line_number":80,"context_line":"    def from_image_id(images_dir, image_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_ff455571","line":77,"range":{"start_line":77,"start_character":28,"end_line":77,"end_character":50},"in_reply_to":"bfb3d3c7_7f02c5b6","updated":"2019-05-20 21:42:48.000000000","message":"It\u0027s the same. rsplit, not lsplit.","commit_id":"c3334b769c5b9845be4967d6fef702efebcea07f"}]}