)]}'
{"nodepool/driver/__init__.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"f410d0c66cd3af8ac5dca1a65ca028f7ae027c70","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        if self.done:"},{"line_number":673,"context_line":"            return True"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"        if self.waiting:"},{"line_number":676,"context_line":"            self.run()"},{"line_number":677,"context_line":"            if self.waiting:"},{"line_number":678,"context_line":"                return False"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"        # Driver must implement this call"},{"line_number":681,"context_line":"        if not self.launchesComplete():"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_e77274e3","line":678,"range":{"start_line":675,"start_character":0,"end_line":678,"end_character":28},"updated":"2019-07-10 18:06:30.000000000","message":"I fear calling run() here may be problematic. poll() is called to all NodeRequestHandlers and is supposed to run *relatively* quickly so that node requests may be marked fulfilled, declined, failed, etc, as soon as possible, while run() may take as much time as it needs to do the launches.","commit_id":"2d667dbfacb31b5385210110fca84c55d2d4f44b"}],"nodepool/launcher.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"f410d0c66cd3af8ac5dca1a65ca028f7ae027c70","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            # There is still a chance for this to happen when a node type"},{"line_number":242,"context_line":"            # becomes available after we re-ran the waiting handlers and before"},{"line_number":243,"context_line":"            # the current handler\u0027s run() method is called."},{"line_number":244,"context_line":"            for wh in self.request_handlers:"},{"line_number":245,"context_line":"                if wh.waiting:"},{"line_number":246,"context_line":"                    wh.run()"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"            self.log.debug(\"Locking request %s\", req.id)"},{"line_number":249,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_d941600d","line":246,"range":{"start_line":244,"start_character":0,"end_line":246,"end_character":28},"updated":"2019-07-10 18:06:30.000000000","message":"This is misplaced. This method is for only assigning a request to a handler. Iterating through existing handlers to give them a chance to run again should not be its job. We already have code that does that.","commit_id":"2d667dbfacb31b5385210110fca84c55d2d4f44b"}]}