)]}'
{"nodepool/driver/fake/provider.py":[{"author":{"_account_id":30637,"name":"Jan Kubovy","email":"jan.kubovy@bmw.de","username":"kubovy"},"change_message_id":"c6b4f73b06e2b7bdc92baa188d48bffae2aa6a56","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        result \u003d self._get(name_or_id, self._server_list)"},{"line_number":260,"context_line":"        return result"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def get_server_by_id(self, server_id):"},{"line_number":263,"context_line":"        return self.get_server(server_id)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def _clean_floating_ip(self, server):"},{"line_number":266,"context_line":"        server.public_v4 \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_aedff00a","line":263,"range":{"start_line":262,"start_character":4,"end_line":263,"end_character":41},"updated":"2019-07-19 11:22:06.000000000","message":"Why is this wrapper needed and the get_server method not used instead?","commit_id":"78e03f87b3a2e060566eeacd90c72f8dc4225a9b"}],"nodepool/driver/openstack/handler.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"224ed4281a7465e08d2125e96e3796ee40ecb268","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                            self.node.external_id) or {}"},{"line_number":270,"context_line":"                        fault \u003d server.get(\u0027fault\u0027, {}).get(\u0027message\u0027)"},{"line_number":271,"context_line":"                        if fault:"},{"line_number":272,"context_line":"                            self.log.error("},{"line_number":273,"context_line":"                                \u0027Request %s: Detailed error for node %s: %s\u0027,"},{"line_number":274,"context_line":"                                self.node.external_id, fault)"},{"line_number":275,"context_line":"                            if \u0027quota\u0027 in fault:"},{"line_number":276,"context_line":"                                quota_exceeded \u003d True"},{"line_number":277,"context_line":"                    except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_82198289","line":274,"range":{"start_line":272,"start_character":0,"end_line":274,"end_character":61},"updated":"2019-09-06 18:50:10.000000000","message":"Missing parameter here (request ID).","commit_id":"78e03f87b3a2e060566eeacd90c72f8dc4225a9b"}],"nodepool/driver/openstack/provider.py":[{"author":{"_account_id":30637,"name":"Jan Kubovy","email":"jan.kubovy@bmw.de","username":"kubovy"},"change_message_id":"c6b4f73b06e2b7bdc92baa188d48bffae2aa6a56","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        return self._client.get_server(server_id)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def getServerById(self, server_id):"},{"line_number":367,"context_line":"        return self._client.get_server_by_id(server_id)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def getServerConsole(self, server_id):"},{"line_number":370,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_eed8881e","line":367,"range":{"start_line":367,"start_character":15,"end_line":367,"end_character":55},"updated":"2019-07-19 11:22:06.000000000","message":"Could the self._client.get_server(server_id) not be used?","commit_id":"78e03f87b3a2e060566eeacd90c72f8dc4225a9b"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"29224415decf4259af3143ff6990f89e7760cab4","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        return self._client.get_server(server_id)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def getServerById(self, server_id):"},{"line_number":367,"context_line":"        return self._client.get_server_by_id(server_id)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def getServerConsole(self, server_id):"},{"line_number":370,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_a28efe2b","line":367,"range":{"start_line":367,"start_character":15,"end_line":367,"end_character":55},"in_reply_to":"7faddb67_2e06a053","updated":"2019-09-06 18:14:58.000000000","message":"The get_server() call will not get the necessary server details unless you supply the details\u003dTrue option (first calls the /servers compute API, second uses the /servers/detail compute API which would include fault info.\n\nBut since we have the server ID, it is more efficient to use get_server_by_id() anyway.","commit_id":"78e03f87b3a2e060566eeacd90c72f8dc4225a9b"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"f41dbcd63721217b09ec349a9a0b7af3b1d7d6aa","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        return self._client.get_server(server_id)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def getServerById(self, server_id):"},{"line_number":367,"context_line":"        return self._client.get_server_by_id(server_id)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def getServerConsole(self, server_id):"},{"line_number":370,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_2e06a053","line":367,"range":{"start_line":367,"start_character":15,"end_line":367,"end_character":55},"in_reply_to":"7faddb67_eed8881e","updated":"2019-07-19 11:53:26.000000000","message":"No, because that doesn\u0027t contain the fault information (I tested this using openstacksdk). Maybe Monty can tell why this is not available when using get_server.","commit_id":"78e03f87b3a2e060566eeacd90c72f8dc4225a9b"}]}