)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"0cd3a162ad4c4170117a57d98064bbe8fd28414b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable interface_ip check, when host-key-checking is disable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the OpenStack driver, we have a check to ensure the interface_ip is"},{"line_number":10,"context_line":"returned by the cloud. This is a way to help confirm there is a public"},{"line_number":11,"context_line":"IP for nodescan to work. However, in some cases we want to disable"},{"line_number":12,"context_line":"host-key-scanning (due to no public IP) which means we also don\u0027t want"},{"line_number":13,"context_line":"to fail if the interface_ip is missing."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ifd2a011302287bffb07b0b94f436748b8620b71d"},{"line_number":16,"context_line":"Signed-off-by: Paul Belanger \u003cpabelanger@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5faad753_fec8a022","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":39},"updated":"2019-09-12 14:57:59.000000000","message":"A bit misleading since interface_ip does not necessarily mean a \"public IP\". It is the IP that sdk has decided is best used to communicate with the node, which could be a public IP or as public IP, depending on the cloud.","commit_id":"1d7fa475ec3561452fa46d13eaef2c7bc3d67799"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"6a6a5780a6d846bb1f928695ccadedb854b73dd9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable interface_ip check, when host-key-checking is disable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the OpenStack driver, we have a check to ensure the interface_ip is"},{"line_number":10,"context_line":"returned by the cloud. This is a way to help confirm there is a public"},{"line_number":11,"context_line":"IP for nodescan to work. However, in some cases we want to disable"},{"line_number":12,"context_line":"host-key-scanning (due to no public IP) which means we also don\u0027t want"},{"line_number":13,"context_line":"to fail if the interface_ip is missing."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ifd2a011302287bffb07b0b94f436748b8620b71d"},{"line_number":16,"context_line":"Signed-off-by: Paul Belanger \u003cpabelanger@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5faad753_deecc490","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":39},"in_reply_to":"5faad753_fec8a022","updated":"2019-09-12 14:58:58.000000000","message":"edit: could be a public IP or a private IP\n\nlack of coffee","commit_id":"1d7fa475ec3561452fa46d13eaef2c7bc3d67799"}],"doc/source/configuration.rst":[{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"af545c8345ff0e20014785aa9942be81d0980a11","unresolved":false,"context_lines":[{"line_number":859,"context_line":"        nodepool-launcher and the nodes it launches are on different"},{"line_number":860,"context_line":"        networks."},{"line_number":861,"context_line":""},{"line_number":862,"context_line":"        Additionally, when set to False, nodepool will no longer validate"},{"line_number":863,"context_line":"        an interface IP exists for the node. This means interface_ip"},{"line_number":864,"context_line":"        maybe empty however a job still has access to private_ipv4 /"},{"line_number":865,"context_line":"        public_ipv4 / public_ipv6 in the inventory file."},{"line_number":866,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5faad753_1cdb521b","line":863,"range":{"start_line":862,"start_character":49,"end_line":863,"end_character":23},"updated":"2019-09-12 07:11:13.000000000","message":"shouldn\u0027t this be \u0027will no longer validate if an interface IP\u0027?","commit_id":"1d7fa475ec3561452fa46d13eaef2c7bc3d67799"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"af545c8345ff0e20014785aa9942be81d0980a11","unresolved":false,"context_lines":[{"line_number":963,"context_line":"           booted. This might be needed if nodepool-launcher and the nodes it"},{"line_number":964,"context_line":"           launches are on different networks."},{"line_number":965,"context_line":""},{"line_number":966,"context_line":"           Additionally, when set to False, nodepool will no longer validate"},{"line_number":967,"context_line":"           an interface IP exists for the node. This means interface_ip"},{"line_number":968,"context_line":"           maybe empty however a job still has access to private_ipv4 /"},{"line_number":969,"context_line":"           public_ipv4 / public_ipv6 in the inventory file."},{"line_number":970,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5faad753_9c00a269","line":967,"range":{"start_line":966,"start_character":68,"end_line":967,"end_character":13},"updated":"2019-09-12 07:11:13.000000000","message":"ditto","commit_id":"1d7fa475ec3561452fa46d13eaef2c7bc3d67799"}]}