)]}'
{"nodepool/driver/openshift/provider.py":[{"author":{"_account_id":14022,"name":"Gabor Lekeny","email":"gabor.lekeny@gmail.com","username":"gabor.lekeny"},"change_message_id":"f32800e41821ffb96616707c6d7841910d3a3255","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                for secret_obj in sa.secrets:"},{"line_number":155,"context_line":"                    secret \u003d self.k8s_client.read_namespaced_secret("},{"line_number":156,"context_line":"                        secret_obj.name, project)"},{"line_number":157,"context_line":"                    token \u003d secret.data.get(\u0027token\u0027)"},{"line_number":158,"context_line":"                    if token:"},{"line_number":159,"context_line":"                        token \u003d base64.b64decode("},{"line_number":160,"context_line":"                            token.encode(\u0027utf-8\u0027)).decode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_222e29a5","line":157,"updated":"2019-10-09 07:01:58.000000000","message":"I would also pass \u0027ca_crt\u0027 here as you do in Kubernetes driver.\nhttps://opendev.org/zuul/nodepool/src/branch/master/nodepool/driver/kubernetes/provider.py#L173-L176\n\nIn this case, \u0027insecure-skip-tls-verify\u0027 is not needed. I have tested it to connect to our 4.1 OpenShift environment and worked. Security first :)","commit_id":"69d5a6cbcc0d316e1279cf817a0880d5b815f2b3"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"b86d9a05d6701d40a77265569cbee8bcd7a7cc1a","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                for secret_obj in sa.secrets:"},{"line_number":155,"context_line":"                    secret \u003d self.k8s_client.read_namespaced_secret("},{"line_number":156,"context_line":"                        secret_obj.name, project)"},{"line_number":157,"context_line":"                    token \u003d secret.data.get(\u0027token\u0027)"},{"line_number":158,"context_line":"                    if token:"},{"line_number":159,"context_line":"                        token \u003d base64.b64decode("},{"line_number":160,"context_line":"                            token.encode(\u0027utf-8\u0027)).decode(\u0027utf-8\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f306c821","line":157,"in_reply_to":"3fa7e38b_222e29a5","updated":"2019-10-23 17:06:00.000000000","message":"Done","commit_id":"69d5a6cbcc0d316e1279cf817a0880d5b815f2b3"}]}