)]}'
{"Dockerfile":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"7075b4b1f27df15899e8fd94f72b91b26acfcde1","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"FROM nodepool as nodepool-builder"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"USER root"},{"line_number":43,"context_line":"RUN echo \"nodepool ALL\u003d(ALL) NOPASSWD:ALL\" \u003e /etc/sudoers.d/nodepool-sudo \\"},{"line_number":44,"context_line":"  \u0026\u0026 chmod 0440 /etc/sudoers.d/nodepool-sudo"},{"line_number":45,"context_line":"RUN \\"}],"source_content_type":"text/x-dockerfile","patch_set":2,"id":"3fa7e38b_dd31640c","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":9},"updated":"2019-11-12 22:16:22.000000000","message":"Instead of switching back to root here, perhaps we should move the USER @ L31 to right before the nodepool-launcher CMD.","commit_id":"7a998638ceb110b902fa34a0053af9428dd4133f"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"51103bd33e688d72c31bb5c554ec806d95e95de0","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"FROM nodepool as nodepool-builder"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"USER root"},{"line_number":43,"context_line":"RUN echo \"nodepool ALL\u003d(ALL) NOPASSWD:ALL\" \u003e /etc/sudoers.d/nodepool-sudo \\"},{"line_number":44,"context_line":"  \u0026\u0026 chmod 0440 /etc/sudoers.d/nodepool-sudo"},{"line_number":45,"context_line":"RUN \\"}],"source_content_type":"text/x-dockerfile","patch_set":2,"id":"3fa7e38b_9e04431a","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":9},"in_reply_to":"3fa7e38b_dd31640c","updated":"2019-11-13 01:19:29.000000000","message":"That\u0027s a good idea.","commit_id":"7a998638ceb110b902fa34a0053af9428dd4133f"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"7075b4b1f27df15899e8fd94f72b91b26acfcde1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"RUN echo \"nodepool ALL\u003d(ALL) NOPASSWD:ALL\" \u003e /etc/sudoers.d/nodepool-sudo \\"},{"line_number":44,"context_line":"  \u0026\u0026 chmod 0440 /etc/sudoers.d/nodepool-sudo"},{"line_number":45,"context_line":"RUN \\"},{"line_number":46,"context_line":"  apt-get update \\"},{"line_number":47,"context_line":"  \u0026\u0026 apt-get install -y gnupg2 \\"},{"line_number":48,"context_line":"  \u0026\u0026 apt-key adv --keyserver keyserver.ubuntu.com --recv 2B5DE24F0EC9F98BD2F85CA315B6CE7C018D05F5 \\"},{"line_number":49,"context_line":"  \u0026\u0026 echo \"deb http://ppa.launchpad.net/openstack-ci-core/vhd-util/ubuntu bionic main\" \u003e\u003e /etc/apt/sources.list \\"},{"line_number":50,"context_line":"  \u0026\u0026 apt-get update \\"},{"line_number":51,"context_line":"  \u0026\u0026 apt-get install -y \\"},{"line_number":52,"context_line":"      debian-keyring \\"},{"line_number":53,"context_line":"      kpartx \\"},{"line_number":54,"context_line":"      qemu-utils \\"}],"source_content_type":"text/x-dockerfile","patch_set":2,"id":"3fa7e38b_98cc5abc","line":51,"range":{"start_line":46,"start_character":0,"end_line":51,"end_character":25},"updated":"2019-11-12 22:16:22.000000000","message":"This seems odd to do packages install after nodepool install, and it may produce a layer that drift from the python-base image (e.g. this apt-get install could pick or change the package already provided by the python-base image). Shouldn\u0027t this be managed by bindep?","commit_id":"7a998638ceb110b902fa34a0053af9428dd4133f"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"51103bd33e688d72c31bb5c554ec806d95e95de0","unresolved":false,"context_lines":[{"line_number":43,"context_line":"RUN echo \"nodepool ALL\u003d(ALL) NOPASSWD:ALL\" \u003e /etc/sudoers.d/nodepool-sudo \\"},{"line_number":44,"context_line":"  \u0026\u0026 chmod 0440 /etc/sudoers.d/nodepool-sudo"},{"line_number":45,"context_line":"RUN \\"},{"line_number":46,"context_line":"  apt-get update \\"},{"line_number":47,"context_line":"  \u0026\u0026 apt-get install -y gnupg2 \\"},{"line_number":48,"context_line":"  \u0026\u0026 apt-key adv --keyserver keyserver.ubuntu.com --recv 2B5DE24F0EC9F98BD2F85CA315B6CE7C018D05F5 \\"},{"line_number":49,"context_line":"  \u0026\u0026 echo \"deb http://ppa.launchpad.net/openstack-ci-core/vhd-util/ubuntu bionic main\" \u003e\u003e /etc/apt/sources.list \\"},{"line_number":50,"context_line":"  \u0026\u0026 apt-get update \\"},{"line_number":51,"context_line":"  \u0026\u0026 apt-get install -y \\"},{"line_number":52,"context_line":"      debian-keyring \\"},{"line_number":53,"context_line":"      kpartx \\"},{"line_number":54,"context_line":"      qemu-utils \\"}],"source_content_type":"text/x-dockerfile","patch_set":2,"id":"3fa7e38b_61fc4a0c","line":51,"range":{"start_line":46,"start_character":0,"end_line":51,"end_character":25},"in_reply_to":"3fa7e38b_98cc5abc","updated":"2019-11-13 01:19:29.000000000","message":"Well - it\u0027s complicated. These are only depends for builder and not for launcher - but more complicated than that is vhd-util which comes from the ppa, so we can\u0027t put it into the bindep file.","commit_id":"7a998638ceb110b902fa34a0053af9428dd4133f"}]}