)]}'
{"nodepool/builder.py":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"c15e9ae4dd099cb19dea0fe48796603432c9803c","unresolved":false,"context_lines":[{"line_number":511,"context_line":"            # use unique builder IDs before, but do now, always compare to"},{"line_number":512,"context_line":"            # hostname as well since some ZK data may still reference that."},{"line_number":513,"context_line":"            all_deleting \u003d all(map(lambda x: x.state \u003d\u003d zk.DELETING, uploads))"},{"line_number":514,"context_line":"            if ((not uploads or all_deleting) and"},{"line_number":515,"context_line":"                (build.builder_id \u003d\u003d self._builder_id or"},{"line_number":516,"context_line":"                 build.builder \u003d\u003d self._hostname)"},{"line_number":517,"context_line":"                ):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_7e3758b0","line":514,"updated":"2020-01-11 01:08:50.000000000","message":"\"not uploads or all_deleting\" is redundant, since \"not uploads\" will always result in \"all_deleting\" being True (because a map() of an empty set is an empty set, and all() over an empty set is True).","commit_id":"db2fcc959ab55d409ca0ef1a3e4c4a18f822cb44"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a656c37e806203525eb96dc07a5d27fc16605e71","unresolved":false,"context_lines":[{"line_number":511,"context_line":"            # use unique builder IDs before, but do now, always compare to"},{"line_number":512,"context_line":"            # hostname as well since some ZK data may still reference that."},{"line_number":513,"context_line":"            all_deleting \u003d all(map(lambda x: x.state \u003d\u003d zk.DELETING, uploads))"},{"line_number":514,"context_line":"            if ((not uploads or all_deleting) and"},{"line_number":515,"context_line":"                (build.builder_id \u003d\u003d self._builder_id or"},{"line_number":516,"context_line":"                 build.builder \u003d\u003d self._hostname)"},{"line_number":517,"context_line":"                ):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_de476c1d","line":514,"in_reply_to":"3fa7e38b_7e3758b0","updated":"2020-01-11 01:10:28.000000000","message":"Yup I had thought of that. I think because the next block conditional on line 520 compares against empty uploads as well that this reads better. It helps to show you that both blocks run when uploads is empty but the first one can additionally execute if the state are all deleting.","commit_id":"db2fcc959ab55d409ca0ef1a3e4c4a18f822cb44"}]}