)]}'
{"nodepool/driver/static/provider.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"03b6b17c453375f8319c391f14bd20de3c1b4901","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                               gather_hostkeys\u003dFalse)"},{"line_number":130,"context_line":"            return True"},{"line_number":131,"context_line":"        except Exception:"},{"line_number":132,"context_line":"            self.log.warning(\"Failed to connect to node: %s\", node_tuple)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        try:"},{"line_number":135,"context_line":"            self.deregisterNode(count\u003d1, node_tuple\u003dnode_tuple)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_7260960d","line":132,"updated":"2020-01-16 23:52:33.000000000","message":"checkNodeLiveness is used in the \"can this node be reused\" path. I don\u0027t use the static driver, but my hunch is if we deregister the node because it is not accessible immediately after a job completes then we should still log that at the exception level?\n\nI worry that warning would be too quiet for this specific case since you\u0027ll stop using that node right?","commit_id":"20d6c3ee45d393e9c1250b53399ac8ef048eab08"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"59046b1f0f352e96717cc2733929fad712b1f050","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                               gather_hostkeys\u003dFalse)"},{"line_number":130,"context_line":"            return True"},{"line_number":131,"context_line":"        except Exception:"},{"line_number":132,"context_line":"            self.log.warning(\"Failed to connect to node: %s\", node_tuple)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        try:"},{"line_number":135,"context_line":"            self.deregisterNode(count\u003d1, node_tuple\u003dnode_tuple)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_8fb964ec","line":132,"in_reply_to":"3fa7e38b_6f3188bb","updated":"2020-01-17 15:28:25.000000000","message":"On irc corvus had the suggestion that we could include the error message from the exception (without trace) and log with error level which probably would be a good compromise between the information the trace gives us and less log spam.","commit_id":"20d6c3ee45d393e9c1250b53399ac8ef048eab08"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"5f227d5c3c19541e1a2b199020b0ae4f2a4186db","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                               gather_hostkeys\u003dFalse)"},{"line_number":130,"context_line":"            return True"},{"line_number":131,"context_line":"        except Exception:"},{"line_number":132,"context_line":"            self.log.warning(\"Failed to connect to node: %s\", node_tuple)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        try:"},{"line_number":135,"context_line":"            self.deregisterNode(count\u003d1, node_tuple\u003dnode_tuple)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b33ff0b0","line":132,"in_reply_to":"3fa7e38b_7260960d","updated":"2020-01-17 06:36:51.000000000","message":"If warning is too quite we can log this as error, however I would prefer not to print the full traceback, since we don\u0027t gain any additional insights from that.","commit_id":"20d6c3ee45d393e9c1250b53399ac8ef048eab08"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"bb66e3aceed4ba4697921c2f1b69d1ff12358cbb","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                               gather_hostkeys\u003dFalse)"},{"line_number":130,"context_line":"            return True"},{"line_number":131,"context_line":"        except Exception:"},{"line_number":132,"context_line":"            self.log.warning(\"Failed to connect to node: %s\", node_tuple)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        try:"},{"line_number":135,"context_line":"            self.deregisterNode(count\u003d1, node_tuple\u003dnode_tuple)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_816369ab","line":132,"in_reply_to":"3fa7e38b_8fb964ec","updated":"2020-01-20 06:13:57.000000000","message":"ack","commit_id":"20d6c3ee45d393e9c1250b53399ac8ef048eab08"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"7b75fcd457ebc69516fbf8e32130b7b57102e9a7","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                               gather_hostkeys\u003dFalse)"},{"line_number":130,"context_line":"            return True"},{"line_number":131,"context_line":"        except Exception:"},{"line_number":132,"context_line":"            self.log.warning(\"Failed to connect to node: %s\", node_tuple)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        try:"},{"line_number":135,"context_line":"            self.deregisterNode(count\u003d1, node_tuple\u003dnode_tuple)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_6f3188bb","line":132,"in_reply_to":"3fa7e38b_b33ff0b0","updated":"2020-01-17 15:23:58.000000000","message":"As an operator I treat stack traces generally as a sign that I as an operator must analyze and fix the root cause. Since this type of error can be user induced I\u0027d prefer not having a traceback but just a warning or error message.","commit_id":"20d6c3ee45d393e9c1250b53399ac8ef048eab08"}]}