)]}'
{"nodepool/driver/utils.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"1f2ef99d9bf287cd78f3e978b9688630b5440216","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        stats.StatsReporter.__init__(self)"},{"line_number":49,"context_line":"        logger \u003d logging.getLogger(\"nodepool.NodeLauncher\")"},{"line_number":50,"context_line":"        # TODO: Add event id from request when it\u0027s plumbed through"},{"line_number":51,"context_line":"        self.log \u003d get_annotated_logger(logger, node_request\u003dNone,"},{"line_number":52,"context_line":"                                        node\u003dnode.id)"},{"line_number":53,"context_line":"        self.zk \u003d zk_conn"},{"line_number":54,"context_line":"        self.node \u003d node"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_1d458e44","line":51,"range":{"start_line":51,"start_character":48,"end_line":51,"end_character":65},"updated":"2020-01-20 20:56:50.000000000","message":"Are there more changes coming that will actually send a NodeRequest? Currently this has no value.","commit_id":"44eb1ce630d5888c8795ad866b06b8372e4eba86"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"79b4c88a800c7381e1d653e16f12ebf80b7f33e4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        stats.StatsReporter.__init__(self)"},{"line_number":49,"context_line":"        logger \u003d logging.getLogger(\"nodepool.NodeLauncher\")"},{"line_number":50,"context_line":"        # TODO: Add event id from request when it\u0027s plumbed through"},{"line_number":51,"context_line":"        self.log \u003d get_annotated_logger(logger, node_request\u003dNone,"},{"line_number":52,"context_line":"                                        node\u003dnode.id)"},{"line_number":53,"context_line":"        self.zk \u003d zk_conn"},{"line_number":54,"context_line":"        self.node \u003d node"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_b456d0cc","line":51,"range":{"start_line":51,"start_character":48,"end_line":51,"end_character":65},"in_reply_to":"3fa7e38b_1d458e44","updated":"2020-01-21 06:04:02.000000000","message":"Yes, sorry. There will be a patch to add that here. I just didn\u0027t finish that part yet.","commit_id":"44eb1ce630d5888c8795ad866b06b8372e4eba86"}],"nodepool/logconfig.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"526eddebec2ceb854ea1beb1386ce42c33edf465","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        extra \u003d {}"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    if node_request is not None:"},{"line_number":165,"context_line":"        extra[\"event_id\"] \u003d node_request.event_id"},{"line_number":166,"context_line":"        extra[\u0027node_request\u0027] \u003d node_request.id"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    if node is not None:"},{"line_number":169,"context_line":"        extra[\"node\"] \u003d node"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_5b58e423","line":166,"range":{"start_line":165,"start_character":0,"end_line":166,"end_character":47},"updated":"2020-01-21 14:31:12.000000000","message":"Since you don\u0027t actually need the entire NodeRequest object for logging, I think you should just pass these two attributes in separately.","commit_id":"ee17daa620a5e9e8742030afa2771909ce1609a7"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"c0d7090f699d351b38a5862a63c27ed8e36da64c","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        extra \u003d {}"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    if node_request is not None:"},{"line_number":165,"context_line":"        extra[\"event_id\"] \u003d node_request.event_id"},{"line_number":166,"context_line":"        extra[\u0027node_request\u0027] \u003d node_request.id"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    if node is not None:"},{"line_number":169,"context_line":"        extra[\"node\"] \u003d node"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_bbc3188c","line":166,"range":{"start_line":165,"start_character":1,"end_line":166,"end_character":47},"updated":"2020-01-22 16:24:58.000000000","message":"Since you only need the event_id and request ID from the NodeRequest object, I\u0027d rather see those items passed in to get_annotated_logger() separately","commit_id":"ee17daa620a5e9e8742030afa2771909ce1609a7"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"ba5db277a6814b276b3e67d246c6a5249299a32f","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        extra \u003d {}"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    if node_request is not None:"},{"line_number":165,"context_line":"        extra[\"event_id\"] \u003d node_request.event_id"},{"line_number":166,"context_line":"        extra[\u0027node_request\u0027] \u003d node_request.id"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    if node is not None:"},{"line_number":169,"context_line":"        extra[\"node\"] \u003d node"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_1bb90cca","line":166,"range":{"start_line":165,"start_character":0,"end_line":166,"end_character":47},"in_reply_to":"3fa7e38b_5b58e423","updated":"2020-01-21 14:50:46.000000000","message":"k, I can change that. I was trying to keep that similar to what\u0027s already available in Zuul [0], but maybe it\u0027s a good idea to allow passing a (generic) event id that doesn\u0027t necessarily has to come from a node request.\n\n[0] https://opendev.org/zuul/zuul/src/branch/master/zuul/lib/logutil.py#L18","commit_id":"ee17daa620a5e9e8742030afa2771909ce1609a7"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"1066f73befbed0b89f750d81b97a5391523e757b","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        extra \u003d {}"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    if node_request is not None:"},{"line_number":165,"context_line":"        extra[\"event_id\"] \u003d node_request.event_id"},{"line_number":166,"context_line":"        extra[\u0027node_request\u0027] \u003d node_request.id"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    if node is not None:"},{"line_number":169,"context_line":"        extra[\"node\"] \u003d node"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_1238f7ea","line":166,"range":{"start_line":165,"start_character":1,"end_line":166,"end_character":47},"in_reply_to":"3fa7e38b_bbc3188c","updated":"2020-01-22 16:31:09.000000000","message":"I don\u0027t know how this statement got repeated here on a recheck. I blame FF caching.","commit_id":"ee17daa620a5e9e8742030afa2771909ce1609a7"}]}