)]}'
{"nodepool/launcher.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"85f24b7ce1c7af9e37082f91cc1fc915a9b67d43","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        # the same priority, use the relative_priority field to"},{"line_number":177,"context_line":"        # further sort, then finally, the submission order."},{"line_number":178,"context_line":"        requests \u003d list(self.zk.nodeRequestIterator())"},{"line_number":179,"context_line":"        requests.sort(key\u003dlambda r: (int(r.id.split(\u0027-\u0027)[0]),"},{"line_number":180,"context_line":"                                     r.relative_priority,"},{"line_number":181,"context_line":"                                     int(r.id.split(\u0027-\u0027)[1])))"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        for req in requests:"},{"line_number":184,"context_line":"            if not self.running:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_87e53240","line":181,"range":{"start_line":179,"start_character":0,"end_line":181,"end_character":62},"updated":"2020-01-29 13:57:13.000000000","message":"Sorting numerically is fine, but our storeNodeRequest() API accepts a string, which will now be counter-intuitive. Perhaps that should be changed to an int too? Not sure yet what the implications of that would be.","commit_id":"c9d0460f0af17f22f96a32abde9c3f8a3c166eaa"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"71fda6c6295dd55b8fc43d478fe4c685b1e46816","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        # the same priority, use the relative_priority field to"},{"line_number":177,"context_line":"        # further sort, then finally, the submission order."},{"line_number":178,"context_line":"        requests \u003d list(self.zk.nodeRequestIterator())"},{"line_number":179,"context_line":"        requests.sort(key\u003dlambda r: (int(r.id.split(\u0027-\u0027)[0]),"},{"line_number":180,"context_line":"                                     r.relative_priority,"},{"line_number":181,"context_line":"                                     int(r.id.split(\u0027-\u0027)[1])))"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        for req in requests:"},{"line_number":184,"context_line":"            if not self.running:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_0c11e6ae","line":181,"range":{"start_line":179,"start_character":0,"end_line":181,"end_character":62},"in_reply_to":"3fa7e38b_87e53240","updated":"2020-02-07 01:49:36.000000000","message":"Perhaps we could do the int to string conversion only once in the _nodePath functions. IIUC, this is the only place having a string for id is useful right?","commit_id":"c9d0460f0af17f22f96a32abde9c3f8a3c166eaa"}]}