)]}'
{"nodepool/cmd/nodepoolcmd.py":[{"author":{"_account_id":29671,"name":"Albin Vass","email":"opendev@albinvass.com","username":"albin_vass"},"change_message_id":"6b73c84c4ecaebf5f884840e6e3ddd3cf711206c","unresolved":false,"context_lines":[{"line_number":332,"context_line":"            print(t)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        def show_nodes():"},{"line_number":335,"context_line":"            print(\"\\nNodes:\")"},{"line_number":336,"context_line":"            t \u003d PrettyTable([\u0027ID\u0027, \u0027Server ID\u0027])"},{"line_number":337,"context_line":"            t.align \u003d \u0027l\u0027"},{"line_number":338,"context_line":"            for node in provider_nodes:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_7281afc3","line":335,"range":{"start_line":335,"start_character":19,"end_line":335,"end_character":21},"updated":"2020-03-12 13:55:14.000000000","message":"I think it would look better if the newline was printed between show_builds and show_nodes when both are used instead of always adding a newline before the nodes.","commit_id":"16e83fe2c3f91bbdcc1735487ebee7b081ef4680"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"828e84bd5f581da44487cfd995ecda2c9c127034","unresolved":false,"context_lines":[{"line_number":332,"context_line":"            print(t)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        def show_nodes():"},{"line_number":335,"context_line":"            print(\"\\nNodes:\")"},{"line_number":336,"context_line":"            t \u003d PrettyTable([\u0027ID\u0027, \u0027Server ID\u0027])"},{"line_number":337,"context_line":"            t.align \u003d \u0027l\u0027"},{"line_number":338,"context_line":"            for node in provider_nodes:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_e352b3de","line":335,"range":{"start_line":335,"start_character":19,"end_line":335,"end_character":21},"in_reply_to":"1fa4df85_7281afc3","updated":"2020-03-12 15:46:04.000000000","message":"Oh, yes, I agree. I didn\u0027t notice that bit.","commit_id":"16e83fe2c3f91bbdcc1735487ebee7b081ef4680"},{"author":{"_account_id":29671,"name":"Albin Vass","email":"opendev@albinvass.com","username":"albin_vass"},"change_message_id":"6b73c84c4ecaebf5f884840e6e3ddd3cf711206c","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        if self.args.nodes:"},{"line_number":347,"context_line":"            show_nodes()"},{"line_number":348,"context_line":"        if not self.args.builds and not self.args.nodes:"},{"line_number":349,"context_line":"            show_builds()"},{"line_number":350,"context_line":"            show_nodes()"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    def config_validate(self):"},{"line_number":353,"context_line":"        validator \u003d ConfigValidator(self.args.config)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_52683320","line":350,"range":{"start_line":349,"start_character":0,"end_line":350,"end_character":24},"updated":"2020-03-12 13:55:14.000000000","message":"Something like:\n\nshow_builds()\nprint(\"\\n\")\nshow_nodes()","commit_id":"16e83fe2c3f91bbdcc1735487ebee7b081ef4680"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"55ed5726a021c4b8071c3471e754fb25f93ff6eb","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        if not self.args.builds and not self.args.nodes:"},{"line_number":349,"context_line":"            show_builds()"},{"line_number":350,"context_line":"            print(\"\\n\")"},{"line_number":351,"context_line":"            show_nodes()"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    def config_validate(self):"},{"line_number":354,"context_line":"        validator \u003d ConfigValidator(self.args.config)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_e9e1edfd","line":351,"updated":"2020-03-17 22:16:26.000000000","message":"i think that \"--builds --nodes\" will actually be different now to specifying nothing, as in this case it has a space but \"--builds --nodes\" won\u0027t?","commit_id":"9f9fcdf03c13d9f7758ee2dd97394267fe93efe6"}],"nodepool/tests/unit/test_commands.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a5f6f148439705f673288301e59592e4c811e958","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        pool \u003d self.useNodepool(configfile, watermark_sleep\u003d1)"},{"line_number":375,"context_line":"        self.useBuilder(configfile)"},{"line_number":376,"context_line":"        pool.start()"},{"line_number":377,"context_line":"        self.waitForImage(\u0027fake-provider\u0027, \u0027fake-image\u0027)"},{"line_number":378,"context_line":"        self.waitForNodes(\u0027fake-label\u0027)"},{"line_number":379,"context_line":"        p2_nodes \u003d self.waitForNodes(\u0027fake-label2\u0027)"},{"line_number":380,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_1db139e2","line":377,"updated":"2020-03-16 21:17:14.000000000","message":"We are asserting that fake-provider2\u0027s content shows up below. Should we be waiting for that provider instead?","commit_id":"11429b6881cba4a4a6e00b9f47396a6c5ecfa5bb"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a5f6f148439705f673288301e59592e4c811e958","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        pool.start()"},{"line_number":377,"context_line":"        self.waitForImage(\u0027fake-provider\u0027, \u0027fake-image\u0027)"},{"line_number":378,"context_line":"        self.waitForNodes(\u0027fake-label\u0027)"},{"line_number":379,"context_line":"        p2_nodes \u003d self.waitForNodes(\u0027fake-label2\u0027)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"        # Get rid of the second provider so that when we remove its"},{"line_number":382,"context_line":"        # data from ZooKeeper, the builder and launcher don\u0027t attempt to"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_fdc53d3e","line":379,"updated":"2020-03-16 21:17:14.000000000","message":"Though waiting for the label here is probably sufficient. I guess the line above is mostly just confusing.","commit_id":"11429b6881cba4a4a6e00b9f47396a6c5ecfa5bb"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a5f6f148439705f673288301e59592e4c811e958","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        p2_nodes \u003d self.waitForNodes(\u0027fake-label2\u0027)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"        # Get rid of the second provider so that when we remove its"},{"line_number":382,"context_line":"        # data from ZooKeeper, the builder and launcher don\u0027t attempt to"},{"line_number":383,"context_line":"        # recreate the data."},{"line_number":384,"context_line":"        self.replace_config(configfile, \u0027info_cmd_two_provider_remove.yaml\u0027)"},{"line_number":385,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_1de619ea","line":382,"updated":"2020-03-16 21:17:14.000000000","message":"I don\u0027t think we are removing its data from zk? Is this section necessary?","commit_id":"11429b6881cba4a4a6e00b9f47396a6c5ecfa5bb"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"8ef420c20460a785356df970a3ac1eb1e9472357","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        p2_nodes \u003d self.waitForNodes(\u0027fake-label2\u0027)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"        # Get rid of the second provider so that when we remove its"},{"line_number":382,"context_line":"        # data from ZooKeeper, the builder and launcher don\u0027t attempt to"},{"line_number":383,"context_line":"        # recreate the data."},{"line_number":384,"context_line":"        self.replace_config(configfile, \u0027info_cmd_two_provider_remove.yaml\u0027)"},{"line_number":385,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_306c4f07","line":382,"in_reply_to":"1fa4df85_1de619ea","updated":"2020-03-17 15:36:56.000000000","message":"This test was copied from the test above that does erasing. I\u0027ve simplified it in the next PS. Should address all of your comments.","commit_id":"11429b6881cba4a4a6e00b9f47396a6c5ecfa5bb"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"55ed5726a021c4b8071c3471e754fb25f93ff6eb","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        pool.start()"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        nodes \u003d self.waitForNodes(\u0027fake-label\u0027)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        # Verify that only the image builds are listed."},{"line_number":381,"context_line":"        cmd \u003d [\u0027info\u0027, \u0027fake-provider\u0027, \u0027--builds\u0027]"},{"line_number":382,"context_line":"        self.assert_listed(configfile, cmd, 0, \u0027fake-image\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_49d36139","line":379,"updated":"2020-03-17 22:16:26.000000000","message":"for completeness should probably test the backwards compat behaviour that nothing prints both?","commit_id":"9f9fcdf03c13d9f7758ee2dd97394267fe93efe6"}]}