)]}'
{"nodepool/cmd/config_validator.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"e5f73446dc4b21558a1785d69a7a6179a6a08764","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                  (label[\u0027name\u0027], provider[\u0027name\u0027]))"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        diskimages \u003d {}"},{"line_number":117,"context_line":"        if config.get(\u0027diskimages\u0027, None):"},{"line_number":118,"context_line":"            for diskimage in config.get(\u0027diskimages\u0027):"},{"line_number":119,"context_line":"                name \u003d diskimage[\u0027name\u0027]"},{"line_number":120,"context_line":"                if name in diskimages:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_60409d36","line":117,"updated":"2020-03-18 23:02:12.000000000","message":"None is the default in .get, so that argument can be omitted.","commit_id":"98f15f39b3442748fd4dfb817c0c3f3f4d9466f8"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"efedbf02f7f1b4fb6e3ea72fc4022d41f09e1f78","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                  (label[\u0027name\u0027], provider[\u0027name\u0027]))"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        diskimages \u003d {}"},{"line_number":117,"context_line":"        if config.get(\u0027diskimages\u0027, None):"},{"line_number":118,"context_line":"            for diskimage in config.get(\u0027diskimages\u0027):"},{"line_number":119,"context_line":"                name \u003d diskimage[\u0027name\u0027]"},{"line_number":120,"context_line":"                if name in diskimages:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_e0948dea","line":117,"in_reply_to":"1fa4df85_60409d36","updated":"2020-03-19 00:06:33.000000000","message":"Done","commit_id":"98f15f39b3442748fd4dfb817c0c3f3f4d9466f8"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"e5f73446dc4b21558a1785d69a7a6179a6a08764","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        diskimages \u003d {}"},{"line_number":117,"context_line":"        if config.get(\u0027diskimages\u0027, None):"},{"line_number":118,"context_line":"            for diskimage in config.get(\u0027diskimages\u0027):"},{"line_number":119,"context_line":"                name \u003d diskimage[\u0027name\u0027]"},{"line_number":120,"context_line":"                if name in diskimages:"},{"line_number":121,"context_line":"                    log.error(\"diskimage %s already defined\" % name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_803b59c6","line":118,"updated":"2020-03-18 23:02:12.000000000","message":"But rather than doing this twice, you can just:\n  for diskimage in config.get(\u0027diskimages\u0027, []):\n\nAnd save a level of indentation.","commit_id":"98f15f39b3442748fd4dfb817c0c3f3f4d9466f8"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"efedbf02f7f1b4fb6e3ea72fc4022d41f09e1f78","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        diskimages \u003d {}"},{"line_number":117,"context_line":"        if config.get(\u0027diskimages\u0027, None):"},{"line_number":118,"context_line":"            for diskimage in config.get(\u0027diskimages\u0027):"},{"line_number":119,"context_line":"                name \u003d diskimage[\u0027name\u0027]"},{"line_number":120,"context_line":"                if name in diskimages:"},{"line_number":121,"context_line":"                    log.error(\"diskimage %s already defined\" % name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_40f80148","line":118,"in_reply_to":"1fa4df85_803b59c6","updated":"2020-03-19 00:06:33.000000000","message":"Done","commit_id":"98f15f39b3442748fd4dfb817c0c3f3f4d9466f8"}]}