)]}'
{"nodepool/builder.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"dbc029ffe4c3884cc893313540ee448e31e2b8c6","unresolved":false,"context_lines":[{"line_number":624,"context_line":"                for _diskimage in new_config.diskimages.values():"},{"line_number":625,"context_line":"                    if _diskimage.name \u003d\u003d diskimage.name:"},{"line_number":626,"context_line":"                        diskimage \u003d _diskimage"},{"line_number":627,"context_line":"                        break"},{"line_number":628,"context_line":"                self._checkImageForScheduledImageUpdates(diskimage)"},{"line_number":629,"context_line":"            except Exception:"},{"line_number":630,"context_line":"                self.log.exception(\"Exception checking for scheduled \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_5fd1f6fa","line":627,"updated":"2020-08-20 20:24:41.000000000","message":"This seems a bit too detailed for this method (and DRY for the other).  Maybe instead we could just exit early if we have performed a build, let the existing \"reload config\" stuff happen, and then we\u0027ll start this loop over?  The only downside I could see is we could starve image builds if building all the images takes longer than the rebuild interval.\n\nOr if that doesn\u0027t sound great, how about we implement a checkConfig method on the base worker that determines if the config has changed, and if so, exit this loop and restart?","commit_id":"6dbe6d351a17e64900e8929a9633b07a3a39c2aa"}],"nodepool/tests/unit/test_builder.py":[{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"2a3f5ca9407385a7e10a485c1d26f23919378b58","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        # Wait for the build to fail before we replace our config. Otherwise"},{"line_number":441,"context_line":"        # we may replace the config before we build the image."},{"line_number":442,"context_line":"        found \u003d False"},{"line_number":443,"context_line":"        while not found:"},{"line_number":444,"context_line":"            builds \u003d self.zk.getBuilds(\u0027fake-image\u0027)"},{"line_number":445,"context_line":"            for build in builds:"},{"line_number":446,"context_line":"                # Lexicographical order"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_e5c15331","line":443,"updated":"2020-09-08 08:17:37.000000000","message":"nit: using iterate_timeout would ensure that this won\u0027t block the test","commit_id":"3f22d3f927e109386d257d7f1e87344d6772ae7b"}]}