)]}'
{"nodepool/nodeutils.py":[{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"ef1b22a36455d0f84f8646ec07431120733b47cf","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                # We use each supported key type in turn to ensure we get"},{"line_number":111,"context_line":"                # back that specific host key type."},{"line_number":112,"context_line":"                key_types \u003d opts.key_types"},{"line_number":113,"context_line":"                opts.key_types \u003d [key_types[key_index]]"},{"line_number":114,"context_line":"                key_index +\u003d 1"},{"line_number":115,"context_line":"                if key_index \u003e\u003d len(key_types):"},{"line_number":116,"context_line":"                    key_index \u003d -1"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_b9605303","line":113,"updated":"2020-11-04 16:45:26.000000000","message":"So this opens one connection for every potential key type (afaik 6 atm)?","commit_id":"cb1860565f741cae1ffb62091cc756bae155a3f1"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"1ff6e92de212c6917a6a12172bb454a22e988bbd","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                # We use each supported key type in turn to ensure we get"},{"line_number":111,"context_line":"                # back that specific host key type."},{"line_number":112,"context_line":"                key_types \u003d opts.key_types"},{"line_number":113,"context_line":"                opts.key_types \u003d [key_types[key_index]]"},{"line_number":114,"context_line":"                key_index +\u003d 1"},{"line_number":115,"context_line":"                if key_index \u003e\u003d len(key_types):"},{"line_number":116,"context_line":"                    key_index \u003d -1"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_749a4263","line":113,"in_reply_to":"1f621f24_348baa1f","updated":"2020-11-04 17:19:46.000000000","message":"That\u0027s a possibility, but limits you if for some reason multiple keys would be a valid need. If we add all the keys ssh should just validate the preferred one it ends up using is correct. Then later if the preferred option changes it will validate that instead.","commit_id":"cb1860565f741cae1ffb62091cc756bae155a3f1"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"63990a778e4b568eb23d96f64596af9e6c04014d","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                # We use each supported key type in turn to ensure we get"},{"line_number":111,"context_line":"                # back that specific host key type."},{"line_number":112,"context_line":"                key_types \u003d opts.key_types"},{"line_number":113,"context_line":"                opts.key_types \u003d [key_types[key_index]]"},{"line_number":114,"context_line":"                key_index +\u003d 1"},{"line_number":115,"context_line":"                if key_index \u003e\u003d len(key_types):"},{"line_number":116,"context_line":"                    key_index \u003d -1"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_348baa1f","line":113,"in_reply_to":"1f621f24_7429a236","updated":"2020-11-04 17:17:59.000000000","message":"When i was looking to do this, one idea I thought about was to expose something into nodepool.pool.labels cfg to allow the user to select which hostkey format to use.\n\nIn our case, for ansible we are looking to just default to ecdsa.","commit_id":"cb1860565f741cae1ffb62091cc756bae155a3f1"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"abba1555bdfb3f3ba0d3880ad346e08f45fa8a4b","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                # We use each supported key type in turn to ensure we get"},{"line_number":111,"context_line":"                # back that specific host key type."},{"line_number":112,"context_line":"                key_types \u003d opts.key_types"},{"line_number":113,"context_line":"                opts.key_types \u003d [key_types[key_index]]"},{"line_number":114,"context_line":"                key_index +\u003d 1"},{"line_number":115,"context_line":"                if key_index \u003e\u003d len(key_types):"},{"line_number":116,"context_line":"                    key_index \u003d -1"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_7429a236","line":113,"in_reply_to":"1f621f24_b9605303","updated":"2020-11-04 17:10:49.000000000","message":"Yes, it will do a proper scan rather than going with the first one that both sides support based on paramiko\u0027s priority listing. The reason for this is ed25119 is top of paramiko\u0027s priority list but does not have fips support. Another potential option is to reorder paramiko\u0027s list maybe do rsa, ecdsa, ed25119, dsa. But I think the approach in this change is most flexible.\n\nAs a side note this method has always returned a list seemingly with the intention of doing a proper scan.","commit_id":"cb1860565f741cae1ffb62091cc756bae155a3f1"}]}