)]}'
{"nodepool/builder.py":[{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"1ca93711693fbeccac4eacb4cf123fc83959d29c","unresolved":true,"context_lines":[{"line_number":802,"context_line":"        image_file \u003d DibImageFile(base)"},{"line_number":803,"context_line":"        filename \u003d image_file.to_path(self._config.images_dir, False)"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        # If we don\u0027t have enough free space, reject this build"},{"line_number":806,"context_line":"        if (self._config.images_dir_required_free or"},{"line_number":807,"context_line":"            diskimage.images_dir_required_free):"},{"line_number":808,"context_line":"            headroom \u003d self._config.images_dir_required_free"}],"source_content_type":"text/x-python","patch_set":1,"id":"f7560bc9_a2b81e85","line":805,"updated":"2020-11-26 08:10:31.000000000","message":"I think we should think about the placement of this block as there are different possibilities with different advantages/disadvantages.\n\n_buildImage (here):\n\n* we already have the lock and the image build object in zk\n* possibly high turnaround frequency in zk\n* high visibility of failed builds (appear in dib-image-list)\n* possibly confusing or the operator since there is no build log for a failed build in the dib-image-list\n* confusing for the user who looks at the dib-image-list web endpoint. This point can act as a ticket generator in our case even if there are other builders that can build the image.\n\n\n_checkImageForManualBuildRequest and _checkImageForScheduledImageUpdates:\n\n* avoid lock and image build object -\u003e builder just ignores it\n* less traffic on zk\n* low visibility of this condition (error logs)\n* less confusing since there is no mismatch of failed image build with missing build log\n\n\nAll in all I think I\u0027d tend slightly to the second option despite less visibility (that\u0027s still in the error log of each builder) due to the user confusion point which could get problematic or us.","commit_id":"3527d484a8fe358a576475a2c87d0117bff9631d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8ec146a286d63e383a309f97f5129507280e7abe","unresolved":true,"context_lines":[{"line_number":802,"context_line":"        image_file \u003d DibImageFile(base)"},{"line_number":803,"context_line":"        filename \u003d image_file.to_path(self._config.images_dir, False)"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        # If we don\u0027t have enough free space, reject this build"},{"line_number":806,"context_line":"        if (self._config.images_dir_required_free or"},{"line_number":807,"context_line":"            diskimage.images_dir_required_free):"},{"line_number":808,"context_line":"            headroom \u003d self._config.images_dir_required_free"}],"source_content_type":"text/x-python","patch_set":1,"id":"9194f6c6_6ae081ae","line":805,"in_reply_to":"f7560bc9_a2b81e85","updated":"2020-11-27 05:41:52.000000000","message":"I tend to agree with that.  I also think we should have some back-off; like not try again for 2 minutes.  I\u0027ll try to rework it","commit_id":"3527d484a8fe358a576475a2c87d0117bff9631d"}]}