)]}'
{"doc/source/azure.rst":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"77a6929cb7ecdbda1fea4e5fe3825c18ce6035ef","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  az ad sp create-for-rbac --name nodepool --sdk-auth"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"You must also have create a network for Nodepool to use.  Be sure to"},{"line_number":15,"context_line":"enable IPv6 on the network if you plan to use it."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Selecting the azure driver adds the following options to the :attr:`providers`"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5fabe137_59735bc7","line":14,"range":{"start_line":14,"start_character":19,"end_line":14,"end_character":25},"updated":"2021-06-18 21:30:50.000000000","message":"Nit: created","commit_id":"b32ad34217051d8cc12ca8873b5d6b2fc28ccf41"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"77a6929cb7ecdbda1fea4e5fe3825c18ce6035ef","unresolved":true,"context_lines":[{"line_number":118,"context_line":"   .. attr:: ipv4"},{"line_number":119,"context_line":"      :type: bool"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"      Whether to enable IPv4 networking.  Defaults to true unless ipv6"},{"line_number":122,"context_line":"      is enabled.  Enabling this will attach a private IP address."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"   .. attr:: ipv6"},{"line_number":125,"context_line":"      :type: bool"}],"source_content_type":"text/x-rst","patch_set":6,"id":"c740d768_aad04631","line":122,"range":{"start_line":121,"start_character":42,"end_line":122,"end_character":17},"updated":"2021-06-18 21:30:50.000000000","message":"It might be a good idea to enable ipv4 even when ipv6 is enabled? A lot of software continues to not be dual stack aware and having working ipv4 to fall back to can be helpful.","commit_id":"b32ad34217051d8cc12ca8873b5d6b2fc28ccf41"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"9697804b9f018673f29864f130dbd8d26da5c123","unresolved":false,"context_lines":[{"line_number":119,"context_line":"      :type: bool"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"      Whether to enable IPv4 networking.  Defaults to true unless ipv6"},{"line_number":122,"context_line":"      is enabled.  Enabling this will attach a private IP address."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"   .. attr:: ipv6"},{"line_number":125,"context_line":"      :type: bool"}],"source_content_type":"text/x-rst","patch_set":6,"id":"8c0d67bf_885b659c","line":122,"updated":"2021-06-18 21:40:03.000000000","message":"That sounds reasonable; I don\u0027t know why I set it otherwise.  There may be something about setting up networks in Azure where this made sense.  All I can say is that I *did* think about it, and this is what I came up with, so if you don\u0027t feel strongly about it, I\u0027d like to leave it as-is.","commit_id":"b32ad34217051d8cc12ca8873b5d6b2fc28ccf41"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"77a6929cb7ecdbda1fea4e5fe3825c18ce6035ef","unresolved":true,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"   .. attr:: rate"},{"line_number":164,"context_line":"      :type: float seconds"},{"line_number":165,"context_line":"      :default: 1"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"      In seconds, amount to wait between operations on the provider."},{"line_number":168,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1011b811_e3b025cf","line":165,"range":{"start_line":165,"start_character":16,"end_line":165,"end_character":17},"updated":"2021-06-18 21:30:50.000000000","message":"Nit: could make this 1.0 to make it clearer the type is floating point.","commit_id":"b32ad34217051d8cc12ca8873b5d6b2fc28ccf41"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"77a6929cb7ecdbda1fea4e5fe3825c18ce6035ef","unresolved":true,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"   .. attr:: boot-timeout"},{"line_number":170,"context_line":"      :type: int seconds"},{"line_number":171,"context_line":"      :default: 60"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"      Once an instance is active, how long to try connecting to the"},{"line_number":174,"context_line":"      image via SSH.  If the timeout is exceeded, the node launch is"}],"source_content_type":"text/x-rst","patch_set":6,"id":"0c876732_3bd59726","line":171,"range":{"start_line":171,"start_character":16,"end_line":171,"end_character":18},"updated":"2021-06-18 21:30:50.000000000","message":"The value in the code seems to be 120 not 60. See https://review.opendev.org/c/zuul/nodepool/+/781926/6/nodepool/driver/azure/config.py\n\nThis is why I -1\u0027d. The other comments are not critical.","commit_id":"b32ad34217051d8cc12ca8873b5d6b2fc28ccf41"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"77a6929cb7ecdbda1fea4e5fe3825c18ce6035ef","unresolved":true,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"   .. attr:: launch-timeout"},{"line_number":178,"context_line":"      :type: int seconds"},{"line_number":179,"context_line":"      :default: 3600"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"      The time to wait from issuing the command to create a new instance"},{"line_number":182,"context_line":"      until that instance is reported as \"active\".  If the timeout is"}],"source_content_type":"text/x-rst","patch_set":6,"id":"790621fc_152f429c","line":179,"range":{"start_line":179,"start_character":16,"end_line":179,"end_character":20},"updated":"2021-06-18 21:30:50.000000000","message":"This timeout seems excessive? Particularly if our boot-timeout default is 1/60th this value.","commit_id":"b32ad34217051d8cc12ca8873b5d6b2fc28ccf41"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"9697804b9f018673f29864f130dbd8d26da5c123","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"   .. attr:: launch-timeout"},{"line_number":178,"context_line":"      :type: int seconds"},{"line_number":179,"context_line":"      :default: 3600"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"      The time to wait from issuing the command to create a new instance"},{"line_number":182,"context_line":"      until that instance is reported as \"active\".  If the timeout is"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf5e1afc_46f6c2e2","line":179,"updated":"2021-06-18 21:40:03.000000000","message":"You\u0027d think.  :)\n\nIt\u0027s also the default for the openstack driver.","commit_id":"b32ad34217051d8cc12ca8873b5d6b2fc28ccf41"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"77a6929cb7ecdbda1fea4e5fe3825c18ce6035ef","unresolved":true,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"      .. attr:: username"},{"line_number":243,"context_line":"         :type: str"},{"line_number":244,"context_line":"         :required:"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"         The username that should be used when connecting to the node."},{"line_number":247,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"fc332ef4_cde9e48b","line":244,"updated":"2021-06-18 21:30:50.000000000","message":"Does this default to zuul?","commit_id":"b32ad34217051d8cc12ca8873b5d6b2fc28ccf41"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"9697804b9f018673f29864f130dbd8d26da5c123","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"      .. attr:: username"},{"line_number":243,"context_line":"         :type: str"},{"line_number":244,"context_line":"         :required:"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"         The username that should be used when connecting to the node."},{"line_number":247,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"d5b811e4_6cef31bc","line":244,"updated":"2021-06-18 21:40:03.000000000","message":"I don\u0027t think so.","commit_id":"b32ad34217051d8cc12ca8873b5d6b2fc28ccf41"}]}