)]}'
{"nodepool/driver/aws/provider.py":[{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"4c66395c5d35b5647bdb53c182a9d0c6621ed7e5","unresolved":true,"context_lines":[{"line_number":116,"context_line":"        else:"},{"line_number":117,"context_line":"            return images[0].get(\"ImageId\")"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @cachetools.func.ttl_cache(maxsize\u003d1, ttl\u003d10)"},{"line_number":120,"context_line":"    def getImageId(self, cloud_image):"},{"line_number":121,"context_line":"        image_id \u003d cloud_image.image_id"},{"line_number":122,"context_line":"        image_filters \u003d cloud_image.image_filters"}],"source_content_type":"text/x-python","patch_set":2,"id":"37750da0_6483a943","line":119,"updated":"2022-02-05 18:02:36.000000000","message":"What\u0027s the reason for maxsize\u003d1? This seems to cache only the last retrieved image?","commit_id":"05b639932d19bf20546837ad661c3e5b4c05ac05"},{"author":{"_account_id":29946,"name":"Andy Ladjadj","email":"andy.ladjadj@adevinta.com","username":"andy.ladjadj"},"change_message_id":"ed633ae7f63faf739b1facd73e8d19486834d227","unresolved":true,"context_lines":[{"line_number":116,"context_line":"        else:"},{"line_number":117,"context_line":"            return images[0].get(\"ImageId\")"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @cachetools.func.ttl_cache(maxsize\u003d1, ttl\u003d10)"},{"line_number":120,"context_line":"    def getImageId(self, cloud_image):"},{"line_number":121,"context_line":"        image_id \u003d cloud_image.image_id"},{"line_number":122,"context_line":"        image_filters \u003d cloud_image.image_filters"}],"source_content_type":"text/x-python","patch_set":2,"id":"58596cc8_f3e4edc9","line":119,"in_reply_to":"37750da0_6483a943","updated":"2022-02-21 15:15:38.000000000","message":"You right, in the case of a multi images configuration, this cache does not work as expected, we can keep the default maxsize","commit_id":"05b639932d19bf20546837ad661c3e5b4c05ac05"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"2dc2c529fbe5e449aac514f18a7cdeadf62d3eba","unresolved":true,"context_lines":[{"line_number":116,"context_line":"        else:"},{"line_number":117,"context_line":"            return images[0].get(\"ImageId\")"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @cachetools.func.ttl_cache(ttl\u003d10)"},{"line_number":120,"context_line":"    def getImageId(self, cloud_image):"},{"line_number":121,"context_line":"        image_id \u003d cloud_image.image_id"},{"line_number":122,"context_line":"        image_filters \u003d cloud_image.image_filters"}],"source_content_type":"text/x-python","patch_set":3,"id":"a6ee8355_d9d679e4","line":119,"updated":"2022-02-23 21:20:12.000000000","message":"I guess the quite low ttl of 10s is because you want quick updates if cloud_image doesn\u0027t contain an image_id?","commit_id":"a5fe4967e1f19e21ab3702ae9545be91631a58e1"},{"author":{"_account_id":29946,"name":"Andy Ladjadj","email":"andy.ladjadj@adevinta.com","username":"andy.ladjadj"},"change_message_id":"5dec22d81015764667d3c77e49c0016aa6ee2c0f","unresolved":true,"context_lines":[{"line_number":116,"context_line":"        else:"},{"line_number":117,"context_line":"            return images[0].get(\"ImageId\")"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @cachetools.func.ttl_cache(ttl\u003d10)"},{"line_number":120,"context_line":"    def getImageId(self, cloud_image):"},{"line_number":121,"context_line":"        image_id \u003d cloud_image.image_id"},{"line_number":122,"context_line":"        image_filters \u003d cloud_image.image_filters"}],"source_content_type":"text/x-python","patch_set":3,"id":"7d24aea8_772fbb87","line":119,"in_reply_to":"a6ee8355_d9d679e4","updated":"2022-03-16 16:06:00.000000000","message":"This TTL is low to prevent only the concurrent call on the AWS API, but we want to retrieve the new image in a brief time.\n\nEg: If we ran 200 instances at the same time, the cache returns the same value without perform API call","commit_id":"a5fe4967e1f19e21ab3702ae9545be91631a58e1"}]}
