)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"19d8eef638e0678770e9625855d0e6d1d630e0a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"80eaf352_a467fb0c","updated":"2022-02-05 17:21:14.000000000","message":"A release note might make sense since this is a new feature.","commit_id":"62730a4dbe63edb0060d960211359d13cb08bde2"}],"nodepool/driver/gce/adapter.py":[{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"8e4b240c4d7b5be465e74999e7f5de8663c2e2de","unresolved":true,"context_lines":[{"line_number":121,"context_line":"        mtype \u003d self._getMachineType(task_manager, label.instance_type)"},{"line_number":122,"context_line":"        machine_type \u003d mtype[\u0027selfLink\u0027]"},{"line_number":123,"context_line":"        network \u003d dict(network\u003dlabel.pool.network or \u0027global/networks/default\u0027,"},{"line_number":124,"context_line":"                       subnetwork\u003dlabel.pool.subnetwork,"},{"line_number":125,"context_line":"                       accessConfigs\u003d[dict("},{"line_number":126,"context_line":"                           type\u003d\u0027ONE_TO_ONE_NAT\u0027,"},{"line_number":127,"context_line":"                           name\u003d\u0027External NAT\u0027)])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abc2fce_ef76df5b","line":124,"updated":"2022-02-05 17:18:24.000000000","message":"Do we know that this doesn\u0027t break if no subnetwork is given (aka subnetwork is explicitly set to None)?","commit_id":"62730a4dbe63edb0060d960211359d13cb08bde2"}],"nodepool/driver/gce/config.py":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"93b35664cefbb1942fe87deb4585fbb653322498","unresolved":true,"context_lines":[{"line_number":138,"context_line":"                    and other.name \u003d\u003d self.name"},{"line_number":139,"context_line":"                    and other.host_key_checking \u003d\u003d self.host_key_checking"},{"line_number":140,"context_line":"                    and other.use_internal_ip \u003d\u003d self.use_internal_ip"},{"line_number":141,"context_line":"                    and other.network \u003d\u003d self.network"},{"line_number":142,"context_line":"                    and other.labels \u003d\u003d self.labels)"},{"line_number":143,"context_line":"        return False"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"0d8fa82b_d41a7ef1","line":141,"updated":"2021-11-15 19:31:22.000000000","message":"shouldn\u0027t this also check for subnetwork ?","commit_id":"62730a4dbe63edb0060d960211359d13cb08bde2"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"8e4b240c4d7b5be465e74999e7f5de8663c2e2de","unresolved":true,"context_lines":[{"line_number":138,"context_line":"                    and other.name \u003d\u003d self.name"},{"line_number":139,"context_line":"                    and other.host_key_checking \u003d\u003d self.host_key_checking"},{"line_number":140,"context_line":"                    and other.use_internal_ip \u003d\u003d self.use_internal_ip"},{"line_number":141,"context_line":"                    and other.network \u003d\u003d self.network"},{"line_number":142,"context_line":"                    and other.labels \u003d\u003d self.labels)"},{"line_number":143,"context_line":"        return False"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b25c25db_8e682e77","line":141,"in_reply_to":"0d8fa82b_d41a7ef1","updated":"2022-02-05 17:18:24.000000000","message":"I think it should","commit_id":"62730a4dbe63edb0060d960211359d13cb08bde2"}]}