)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"286fc0adecb86323f376913b578fb387c3477f9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"100de09d_32100c3f","updated":"2021-11-15 19:36:45.000000000","message":"-1 as it seems like the cleanup is not going to work as expected.","commit_id":"b0a74930b2f4d11de8a1e436e8a5fb596710b2ea"}],"nodepool/driver/kubernetes/config.py":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"286fc0adecb86323f376913b578fb387c3477f9b","unresolved":true,"context_lines":[{"line_number":92,"context_line":"            \u0027image\u0027: str,"},{"line_number":93,"context_line":"            \u0027image-pull\u0027: str,"},{"line_number":94,"context_line":"            \u0027namespace\u0027: str,"},{"line_number":95,"context_line":"            \u0027service-account\u0027: str,"},{"line_number":96,"context_line":"            \u0027python-path\u0027: str,"},{"line_number":97,"context_line":"            \u0027shell-type\u0027: str,"},{"line_number":98,"context_line":"            \u0027cpu\u0027: int,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a313810b_4724534c","line":95,"updated":"2021-11-15 19:36:45.000000000","message":"Should we check that setting namespace is only valid when type is pod?","commit_id":"b0a74930b2f4d11de8a1e436e8a5fb596710b2ea"}],"nodepool/driver/kubernetes/provider.py":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"286fc0adecb86323f376913b578fb387c3477f9b","unresolved":true,"context_lines":[{"line_number":110,"context_line":"            \"propagationPolicy\": \"Background\""},{"line_number":111,"context_line":"        }"},{"line_number":112,"context_line":"        try:"},{"line_number":113,"context_line":"            self.k8s_client.delete_namespace(server_id, body\u003ddelete_body)"},{"line_number":114,"context_line":"            self.log.info(\"%s: namespace removed\" % server_id)"},{"line_number":115,"context_line":"        except Exception:"},{"line_number":116,"context_line":"            # TODO: implement better exception handling"}],"source_content_type":"text/x-python","patch_set":1,"id":"bb48e4a1_15363f48","line":113,"updated":"2021-11-15 19:36:45.000000000","message":"It seems like this is assuming a kubernetes node \u003d\u003d a namespace.","commit_id":"b0a74930b2f4d11de8a1e436e8a5fb596710b2ea"}],"nodepool/tests/fixtures/kubernetes.yaml":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"286fc0adecb86323f376913b578fb387c3477f9b","unresolved":true,"context_lines":[{"line_number":31,"context_line":"            image: docker.io/fedora:28"},{"line_number":32,"context_line":"          - name: shared-ns-pods"},{"line_number":33,"context_line":"            type: pod"},{"line_number":34,"context_line":"            image: docker.io/ubuntu:focal"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2b2c6aa2_321ea6a1","line":34,"updated":"2021-11-15 19:36:45.000000000","message":"Is this missing the namespace attribute?","commit_id":"b0a74930b2f4d11de8a1e436e8a5fb596710b2ea"}]}
