)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31995,"name":"Lida Liu","email":"lida.liu@volvocars.com","username":"lliu0712"},"change_message_id":"925a0844992d071dd1fb8a33ed8f23461a163376","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f6aaa596_252e5f10","updated":"2022-01-17 08:40:12.000000000","message":"Also, is it possible for nodepool config checker to verify the token for cloud provider?","commit_id":"b8035de65f563b6b4c31a2de3439fcdfcdca5a84"}],"nodepool/launcher.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"952518b05b05bb44a24d8a63120f4fb6bd25afbd","unresolved":false,"context_lines":[{"line_number":959,"context_line":"                                                     self.getZK())"},{"line_number":960,"context_line":"        for provider_name in list(config.providers.keys()):"},{"line_number":961,"context_line":"            if provider_name not in config.provider_managers:"},{"line_number":962,"context_line":"                del config.providers[provider_name]"},{"line_number":963,"context_line":"        self.setConfig(config)"},{"line_number":964,"context_line":""},{"line_number":965,"context_line":"    def removeCompletedRequests(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"6538d84f_0ecbf7e7","line":962,"updated":"2022-01-17 18:27:00.000000000","message":"I think deleting it is the right thing to do here.  This method runs very often, so if it is fixed, it will immediately be recreated.\n\nIf we were to keep the old configuration, there would be no indication to the user that there was a problem, and if the launcher was restarted, there would be no old configuration to use.  That means that a configuration error could persist for quite a long time before being discovered only after some kind of fault that caused the launcher to restart.","commit_id":"b8035de65f563b6b4c31a2de3439fcdfcdca5a84"},{"author":{"_account_id":31995,"name":"Lida Liu","email":"lida.liu@volvocars.com","username":"lliu0712"},"change_message_id":"925a0844992d071dd1fb8a33ed8f23461a163376","unresolved":true,"context_lines":[{"line_number":959,"context_line":"                                                     self.getZK())"},{"line_number":960,"context_line":"        for provider_name in list(config.providers.keys()):"},{"line_number":961,"context_line":"            if provider_name not in config.provider_managers:"},{"line_number":962,"context_line":"                del config.providers[provider_name]"},{"line_number":963,"context_line":"        self.setConfig(config)"},{"line_number":964,"context_line":""},{"line_number":965,"context_line":"    def removeCompletedRequests(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"47900ace_123a1ae0","line":962,"range":{"start_line":962,"start_character":16,"end_line":962,"end_character":51},"updated":"2022-01-17 08:40:12.000000000","message":"should we directly delete the provider? Is it possible for nodepool to maintain the old working config and throw out the error which wrong config is planned to be updated but failed","commit_id":"b8035de65f563b6b4c31a2de3439fcdfcdca5a84"}]}