)]}'
{"nodepool/driver/aws/provider.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"16c31b273285daaf92458e085db90fafb5478693","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def quotaNeededByLabel(self, ntype, pool):"},{"line_number":258,"context_line":"        # TODO: return real quota information about a label"},{"line_number":259,"context_line":"        return QuotaInformation(cores\u003d0, instances\u003d1, ram\u003d0, default\u003d1)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def unmanagedQuotaUsed(self):"},{"line_number":262,"context_line":"        # TODO: return real quota information about quota"}],"source_content_type":"text/x-python","patch_set":2,"id":"9270cea2_03b849e2","line":259,"updated":"2022-01-27 18:09:31.000000000","message":"I tried to match existing similar drivers.  Since this driver should but doesn\u0027t implement core/ram metrics, I omitted them here (so it will behave the same as before).  For openshift, I matched what we already did for the k8s driver, where we just assume 1 core.","commit_id":"9c90d5bf2b935d6a2806ef5ea9ea0fa4b2e76b0a"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"893ce2127dbdfe13a329de4ea934944195a1b0fe","unresolved":true,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def quotaNeededByLabel(self, ntype, pool):"},{"line_number":258,"context_line":"        # TODO: return real quota information about a label"},{"line_number":259,"context_line":"        return QuotaInformation(cores\u003d0, instances\u003d1, ram\u003d0, default\u003d1)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def unmanagedQuotaUsed(self):"},{"line_number":262,"context_line":"        # TODO: return real quota information about quota"}],"source_content_type":"text/x-python","patch_set":2,"id":"bb1b8039_1c13b894","line":259,"updated":"2022-01-27 18:04:57.000000000","message":"In some cases the stub quotaNeededByLabel has set cores and ram to 0 and in others they are set to 1. Is there reason for that? Might be better to be more consistent?","commit_id":"9c90d5bf2b935d6a2806ef5ea9ea0fa4b2e76b0a"}],"nodepool/driver/static/provider.py":[{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"4d8da853df7a3344ddb42b6b7af073f01af9a243","unresolved":true,"context_lines":[{"line_number":508,"context_line":"        return QuotaInformation(cores\u003d0, instances\u003d1, ram\u003d0, default\u003d1)"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    def unmanagedQuotaUsed(self):"},{"line_number":511,"context_line":"        # TODO: return real quota information about quota"},{"line_number":512,"context_line":"        return QuotaInformation()"}],"source_content_type":"text/x-python","patch_set":2,"id":"be21e636_9399eade","line":511,"updated":"2022-01-26 17:36:26.000000000","message":"I think the static driver has no unmanaged quota (aka resources that are not managed by nodepool) used by definition so we could remove this todo.","commit_id":"9c90d5bf2b935d6a2806ef5ea9ea0fa4b2e76b0a"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"16c31b273285daaf92458e085db90fafb5478693","unresolved":false,"context_lines":[{"line_number":508,"context_line":"        return QuotaInformation(cores\u003d0, instances\u003d1, ram\u003d0, default\u003d1)"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    def unmanagedQuotaUsed(self):"},{"line_number":511,"context_line":"        # TODO: return real quota information about quota"},{"line_number":512,"context_line":"        return QuotaInformation()"}],"source_content_type":"text/x-python","patch_set":2,"id":"6ec28242_0e24ecd7","line":511,"updated":"2022-01-27 18:09:31.000000000","message":"True, this is mostly copypasta, but I sort of left it thinking we really should think about whether we can apply some quota info here (maybe statically defined?).  But I should have either deleted the comment or changed it to that.  :/","commit_id":"9c90d5bf2b935d6a2806ef5ea9ea0fa4b2e76b0a"}],"nodepool/tests/unit/test_driver_openshiftpods.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"16c31b273285daaf92458e085db90fafb5478693","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        pool.start()"},{"line_number":88,"context_line":"        req \u003d zk.NodeRequest()"},{"line_number":89,"context_line":"        req.state \u003d zk.REQUESTED"},{"line_number":90,"context_line":"        req.state \u003d zk.REQUESTED"},{"line_number":91,"context_line":"        req.node_types.append(\u0027pod-fedora\u0027)"},{"line_number":92,"context_line":"        self.zk.storeNodeRequest(req)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"771a6ad8_12235bfa","line":90,"updated":"2022-01-27 18:09:31.000000000","message":"Gah.","commit_id":"9c90d5bf2b935d6a2806ef5ea9ea0fa4b2e76b0a"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"893ce2127dbdfe13a329de4ea934944195a1b0fe","unresolved":true,"context_lines":[{"line_number":87,"context_line":"        pool.start()"},{"line_number":88,"context_line":"        req \u003d zk.NodeRequest()"},{"line_number":89,"context_line":"        req.state \u003d zk.REQUESTED"},{"line_number":90,"context_line":"        req.state \u003d zk.REQUESTED"},{"line_number":91,"context_line":"        req.node_types.append(\u0027pod-fedora\u0027)"},{"line_number":92,"context_line":"        self.zk.storeNodeRequest(req)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"4014eb7e_18cd86cf","line":90,"updated":"2022-01-27 18:04:57.000000000","message":"This line is redundant with the one before it.","commit_id":"9c90d5bf2b935d6a2806ef5ea9ea0fa4b2e76b0a"}]}