)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a63ee7579f5c0f2a35da2be1800713451facb557","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"65cef119_8c70698c","updated":"2022-04-26 05:14:38.000000000","message":"gtg with updated flavor handling from https://review.opendev.org/c/zuul/nodepool/+/834152/2","commit_id":"0adda1584baacbcc9c60f873d674c942598b8a21"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"211bdece95646e1dd624313d798078a8b33f85e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ea35eb09_b13991d6","updated":"2022-04-28 10:36:22.000000000","message":"recheck","commit_id":"0adda1584baacbcc9c60f873d674c942598b8a21"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f984221b142f803e098147f4c85b57a5aac8fe38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0b4a6ddc_1556c91b","updated":"2022-04-28 07:30:32.000000000","message":"recheck unrelated unstable unit test","commit_id":"0adda1584baacbcc9c60f873d674c942598b8a21"}],"nodepool/driver/openstack/provider.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"cb6adc9d5e3842b8b909e42bc6452dd22c9408b9","unresolved":true,"context_lines":[{"line_number":143,"context_line":"                flavor \u003d server.flavor"},{"line_number":144,"context_line":"            else:"},{"line_number":145,"context_line":"                flavor \u003d flavors.get(server.flavor.id)"},{"line_number":146,"context_line":"            if not flavor:"},{"line_number":147,"context_line":"                continue"},{"line_number":148,"context_line":"            used_quota.add(QuotaInformation.construct_from_flavor(flavor))"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        return used_quota"}],"source_content_type":"text/x-python","patch_set":3,"id":"bd1ebc2c_432a092d","line":147,"range":{"start_line":146,"start_character":12,"end_line":147,"end_character":24},"updated":"2022-03-17 08:02:14.000000000","message":"this seems to suggest if we don\u0027t get the flavor, we don\u0027t add to the quota?  that doesn\u0027t seem right?","commit_id":"5319085046da780803021a9b6a6ae6c6686d3bac"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"db4aabcc15f0bce797c72195a27cbdf2389dc9c3","unresolved":true,"context_lines":[{"line_number":143,"context_line":"                flavor \u003d server.flavor"},{"line_number":144,"context_line":"            else:"},{"line_number":145,"context_line":"                flavor \u003d flavors.get(server.flavor.id)"},{"line_number":146,"context_line":"            if not flavor:"},{"line_number":147,"context_line":"                continue"},{"line_number":148,"context_line":"            used_quota.add(QuotaInformation.construct_from_flavor(flavor))"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        return used_quota"}],"source_content_type":"text/x-python","patch_set":3,"id":"eb4664de_17b0ece0","line":147,"range":{"start_line":146,"start_character":12,"end_line":147,"end_character":24},"in_reply_to":"bd1ebc2c_432a092d","updated":"2022-03-17 08:10:31.000000000","message":"re-acquainting myself with the problem ... if the flavor doesn\u0027t set the vcpu\u0027s, which previously was filled in as \"0\" but now the value is not present?\n\nSo it\u0027s probably fair to say this has the same overall affect, in that nothing is added to the quota.\n\nthe comments here should be updated, I would say, at least.\n\nA better question might be how should we be getting the vcpu\u0027s of these hosts?  The vcpu\u0027s is a required property of a flavor, right?  it doesn\u0027t seem to make sense to not have this info.","commit_id":"5319085046da780803021a9b6a6ae6c6686d3bac"}]}