)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"18c0dd2da3b518c91791c8785239a09eff318a18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d4e8b8d7_9d709c13","updated":"2022-03-14 11:02:09.000000000","message":"I think a better way would be to include the node tuple when we log the exception during cleanup as we already do in other places https://opendev.org/zuul/nodepool/src/branch/master/nodepool/driver/static/provider.py#L353-L354","commit_id":"6c1aec18b4eb7cc90bc85856b09c80ea00fcc5ce"},{"author":{"_account_id":10961,"name":"lotorev vitaly","display_name":"Vitaliy Lotorev","email":"lotorev@gmail.com","username":"Vitaliy"},"change_message_id":"6727567635f2885dc1b7a10dcbfda52aae905938","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3c63a0f7_4a3e5d79","in_reply_to":"d4e8b8d7_9d709c13","updated":"2022-05-02 21:34:05.000000000","message":"Done","commit_id":"6c1aec18b4eb7cc90bc85856b09c80ea00fcc5ce"},{"author":{"_account_id":10961,"name":"lotorev vitaly","display_name":"Vitaliy Lotorev","email":"lotorev@gmail.com","username":"Vitaliy"},"change_message_id":"61c9b9649c9f00347f5a6ae0d510ed1896cbabea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"115e8491_1b410e6a","updated":"2022-05-21 08:27:45.000000000","message":"recheck","commit_id":"6520ae56b680f08b8ddf02227bb86da5e8c4f7a8"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"56e0a9ab422c65d188a37de1f66b2b22e010c581","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f07e530c_5955e337","updated":"2022-05-20 06:31:50.000000000","message":"recheck","commit_id":"6520ae56b680f08b8ddf02227bb86da5e8c4f7a8"}],"nodepool/nodeutils.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"917c25f4cd55fe6aa100c379ed56bb391aadbd22","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        addrinfo \u003d socket.getaddrinfo(node.hostname, node.connection_port)[0]"},{"line_number":50,"context_line":"    except socket.error:"},{"line_number":51,"context_line":"        log.exception("},{"line_number":52,"context_line":"            \u0027Exception connecting to %s on port %s\u0027, node.hostname,"},{"line_number":53,"context_line":"            node.connection_port)"},{"line_number":54,"context_line":"        raise"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2d7613fd_4f192d40","line":52,"updated":"2022-03-14 10:31:17.000000000","message":"IIUC the above socket call is not actually attempting a connection, but just preparing to do so, so the exception is an issue with name resolution most likely, not with the actual connection.\n\nTo me this seems to be a special case of the \"else\" below, so maybe we should stick to that exception being raised and just add the hostname into the generated message? Likely both here and below.","commit_id":"6c1aec18b4eb7cc90bc85856b09c80ea00fcc5ce"},{"author":{"_account_id":10961,"name":"lotorev vitaly","display_name":"Vitaliy Lotorev","email":"lotorev@gmail.com","username":"Vitaliy"},"change_message_id":"6727567635f2885dc1b7a10dcbfda52aae905938","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        addrinfo \u003d socket.getaddrinfo(node.hostname, node.connection_port)[0]"},{"line_number":50,"context_line":"    except socket.error:"},{"line_number":51,"context_line":"        log.exception("},{"line_number":52,"context_line":"            \u0027Exception connecting to %s on port %s\u0027, node.hostname,"},{"line_number":53,"context_line":"            node.connection_port)"},{"line_number":54,"context_line":"        raise"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"158ec6dc_70f33384","line":52,"in_reply_to":"2d7613fd_4f192d40","updated":"2022-05-02 21:34:05.000000000","message":"I reverted nodeutils.py file and added printing nodeTuple() in cleanupLeakedResources() in nodepool/driver/static/provider.py.","commit_id":"6c1aec18b4eb7cc90bc85856b09c80ea00fcc5ce"}]}