)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34641,"name":"Pedro Moritz de Carvalho Neto","email":"Pedro.MoritzdeCarvalhoNeto@windriver.com","username":"PedroMoritz"},"change_message_id":"b65aa916331c156209995cecb5112589434e2491","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d8356cf9_3b149dae","updated":"2022-03-14 22:30:54.000000000","message":"recheck","commit_id":"1578f517fcd47f2195e6b1efed560505a1ad5d57"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"974710f942bddc7d6f944da63a5fcdfeea7da840","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"18a9d7b4_cff5cdda","updated":"2022-03-16 21:05:46.000000000","message":"It would be good to know when that would be useful. The pod type is made to simulate a regular instance where zuul can execute job similarly to the other nodes provided by openstack or aws. Thus the pod should not be doing anything else than waiting for the ansible driven exec call.","commit_id":"00df9f9db41fc67ddfbc7a5e99d5c95046661a88"},{"author":{"_account_id":34641,"name":"Pedro Moritz de Carvalho Neto","email":"Pedro.MoritzdeCarvalhoNeto@windriver.com","username":"PedroMoritz"},"change_message_id":"ad67cca0b485cb1fb753aa012f4d206df92948c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a6634641_03666fb9","updated":"2022-04-18 21:02:52.000000000","message":"The main reason for this change would be avoiding errors like \"Failed to get D-Bus connection\" and similar since Init process is not spawned with PID 1 and the container is not created with privilege mode within K8s driver. However, since we used a script to simulate systemctl this change or other changes on pods creation specs are not necessary anymore.","commit_id":"00df9f9db41fc67ddfbc7a5e99d5c95046661a88"}],"doc/source/kubernetes.rst":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"76486d11f249f906be3fbb197b4b00e0653d5b24","unresolved":true,"context_lines":[{"line_number":193,"context_line":"            A map of key-value pairs to ensure the Kubernetes scheduler"},{"line_number":194,"context_line":"            places the Pod on a node with specific node labels."},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"         .. attr:: override-container-command"},{"line_number":197,"context_line":"            :type: bool"},{"line_number":198,"context_line":"            :default: True"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"f14216e9_c1e9f01f","line":196,"updated":"2022-03-16 20:26:18.000000000","message":"Reading these new docs it isn\u0027t clear to me what the old behavior was and why it is useful.\n\nLooking more closely I believe the intent was that the container would be started in a pod then told to sit idle while the rest of the job connected to it and directed it to do work. Knowing this it might be better to set this up as a single flag something like:\n\n   .. attr:: override-container-command\n      :type: bool\n      :default: True\n\n      Only used by the :value:`providers[kubernetes].pools.labels.type.pod`\n      label type. The default behavior is to run \"/bin/sh -c \u0027while true;\n      do sleep 30; done;\u0027\" in the container forcing it to idle except for\n      the tasks run against the container by your job definition. This can\n      be set to false if you would prefer to run the container\u0027s default\n      CMD value instead.\n\nThen don\u0027t bother with override-container-args. Basically make this a single toggle and make it more clear why one might want to set it.","commit_id":"00df9f9db41fc67ddfbc7a5e99d5c95046661a88"}],"nodepool/driver/kubernetes/config.py":[{"author":{"_account_id":34641,"name":"Pedro Moritz de Carvalho Neto","email":"Pedro.MoritzdeCarvalhoNeto@windriver.com","username":"PedroMoritz"},"change_message_id":"0f7c3129340fcf19dfc89d8d6127a61d6ceab9a4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            pl.memory \u003d label.get(\u0027memory\u0027)"},{"line_number":51,"context_line":"            pl.env \u003d label.get(\u0027env\u0027, [])"},{"line_number":52,"context_line":"            pl.node_selector \u003d label.get(\u0027node-selector\u0027)"},{"line_number":53,"context_line":"            pl.override_container_command \u003d label.get(\u0027override-container-command\u0027, True)"},{"line_number":54,"context_line":"            pl.override_container_args \u003d label.get(\u0027override-container-args\u0027, True)"},{"line_number":55,"context_line":"            pl.pool \u003d self"},{"line_number":56,"context_line":"            self.labels[pl.name] \u003d pl"}],"source_content_type":"text/x-python","patch_set":2,"id":"d42614c4_d9605b7c","line":53,"in_reply_to":"e8e6a572_28b64ae9","updated":"2022-03-14 21:28:20.000000000","message":"\u003e pep8: E501 line too long (89 \u003e 79 characters)\n\nPlease fix.","commit_id":"342352a107a91eb27319cbe1487188b8ed1185f3"},{"author":{"_account_id":34641,"name":"Pedro Moritz de Carvalho Neto","email":"Pedro.MoritzdeCarvalhoNeto@windriver.com","username":"PedroMoritz"},"change_message_id":"0f7c3129340fcf19dfc89d8d6127a61d6ceab9a4","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            pl.env \u003d label.get(\u0027env\u0027, [])"},{"line_number":52,"context_line":"            pl.node_selector \u003d label.get(\u0027node-selector\u0027)"},{"line_number":53,"context_line":"            pl.override_container_command \u003d label.get(\u0027override-container-command\u0027, True)"},{"line_number":54,"context_line":"            pl.override_container_args \u003d label.get(\u0027override-container-args\u0027, True)"},{"line_number":55,"context_line":"            pl.pool \u003d self"},{"line_number":56,"context_line":"            self.labels[pl.name] \u003d pl"},{"line_number":57,"context_line":"            full_config.labels[label[\u0027name\u0027]].pools.append(self)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9e3d2195_aeaaefb2","line":54,"in_reply_to":"d2f7f2c7_08a72683","updated":"2022-03-14 21:28:20.000000000","message":"\u003e pep8: E501 line too long (83 \u003e 79 characters)\n\nPlease fix.","commit_id":"342352a107a91eb27319cbe1487188b8ed1185f3"}]}