)]}'
{"nodepool/launcher.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"200f1fb0c992152591b7f49b4232995821fdea3b","unresolved":true,"context_lines":[{"line_number":981,"context_line":"                timeout\u003dconfig.zookeeper_timeout,"},{"line_number":982,"context_line":"            )"},{"line_number":983,"context_line":"            self.zk_client.connect()"},{"line_number":984,"context_line":"            self.zk \u003d zk.ZooKeeper(self.zk_client)"},{"line_number":985,"context_line":"        else:"},{"line_number":986,"context_line":"            self.log.debug(\"Detected ZooKeeper server changes\")"},{"line_number":987,"context_line":"            self.zk_client.resetHosts(configured)"}],"source_content_type":"text/x-python","patch_set":3,"id":"61829169_ed8caf15","line":984,"updated":"2022-05-23 17:35:23.000000000","message":"In testing and the builder we disable the cache but don\u0027t do so for the launcher here. Is that something we should make consistent?","commit_id":"10df93540fa49cf2134a46fa63440d1a905b3dfd"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"66334e3855b01ca3da4637407b73363ace11d0be","unresolved":false,"context_lines":[{"line_number":981,"context_line":"                timeout\u003dconfig.zookeeper_timeout,"},{"line_number":982,"context_line":"            )"},{"line_number":983,"context_line":"            self.zk_client.connect()"},{"line_number":984,"context_line":"            self.zk \u003d zk.ZooKeeper(self.zk_client)"},{"line_number":985,"context_line":"        else:"},{"line_number":986,"context_line":"            self.log.debug(\"Detected ZooKeeper server changes\")"},{"line_number":987,"context_line":"            self.zk_client.resetHosts(configured)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f2a8f2c_24f5b951","line":984,"updated":"2022-05-23 17:42:40.000000000","message":"The cache is mainly for the launcher (and to be clear, the launcher used in tests also uses the cache).\n\nMost of Nodepool was written to use ZK synchronously; we only added some caching in specific cases later.","commit_id":"10df93540fa49cf2134a46fa63440d1a905b3dfd"}],"nodepool/tests/unit/test_launcher.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"200f1fb0c992152591b7f49b4232995821fdea3b","unresolved":true,"context_lines":[{"line_number":1658,"context_line":"        self.assertEqual(\u0027secret\u0027, fake_image.env_vars[\u0027REG_PASSWORD\u0027])"},{"line_number":1659,"context_line":""},{"line_number":1660,"context_line":"        zk_servers \u003d pool.config.zookeeper_servers"},{"line_number":1661,"context_line":"        self.assertTrue(len(zk_servers) \u003e 0)"},{"line_number":1662,"context_line":"        expected \u003d (f\u0027{self.zookeeper_host}:{self.zookeeper_port}\u0027"},{"line_number":1663,"context_line":"                    f\u0027{self.zookeeper_chroot}\u0027)"},{"line_number":1664,"context_line":"        self.assertEqual(expected, zk_servers)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa9c22a4_5e16393f","line":1661,"updated":"2022-05-23 17:35:23.000000000","message":"This assertion basically checks that we have a zk_servers string with more than one character in it. Previously we were asserting the length of the number of servers was one and not greater, but this new check would allow more than one.\n\nThe next assertion validates the single entry is present. May just want to remove this assertion? Not a huge deal, but calling out the difference.","commit_id":"10df93540fa49cf2134a46fa63440d1a905b3dfd"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"66334e3855b01ca3da4637407b73363ace11d0be","unresolved":false,"context_lines":[{"line_number":1658,"context_line":"        self.assertEqual(\u0027secret\u0027, fake_image.env_vars[\u0027REG_PASSWORD\u0027])"},{"line_number":1659,"context_line":""},{"line_number":1660,"context_line":"        zk_servers \u003d pool.config.zookeeper_servers"},{"line_number":1661,"context_line":"        self.assertTrue(len(zk_servers) \u003e 0)"},{"line_number":1662,"context_line":"        expected \u003d (f\u0027{self.zookeeper_host}:{self.zookeeper_port}\u0027"},{"line_number":1663,"context_line":"                    f\u0027{self.zookeeper_chroot}\u0027)"},{"line_number":1664,"context_line":"        self.assertEqual(expected, zk_servers)"}],"source_content_type":"text/x-python","patch_set":3,"id":"12f6c05c_2c40535e","line":1661,"updated":"2022-05-23 17:42:40.000000000","message":"Yes, it does seem redundant now.","commit_id":"10df93540fa49cf2134a46fa63440d1a905b3dfd"}],"nodepool/zk/__init__.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"66334e3855b01ca3da4637407b73363ace11d0be","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                timeout\u003dself.timeout,"},{"line_number":131,"context_line":"                handler\u003dPoolSequentialThreadingHandler(),"},{"line_number":132,"context_line":"            )"},{"line_number":133,"context_line":"            if self.tls_key:"},{"line_number":134,"context_line":"                args[\u0027use_ssl\u0027] \u003d True"},{"line_number":135,"context_line":"                args[\u0027keyfile\u0027] \u003d self.tls_key"},{"line_number":136,"context_line":"                args[\u0027certfile\u0027] \u003d self.tls_cert"}],"source_content_type":"text/x-python","patch_set":3,"id":"af0c2731_8240da92","line":133,"updated":"2022-05-23 17:42:40.000000000","message":"Likely so.","commit_id":"10df93540fa49cf2134a46fa63440d1a905b3dfd"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"200f1fb0c992152591b7f49b4232995821fdea3b","unresolved":true,"context_lines":[{"line_number":130,"context_line":"                timeout\u003dself.timeout,"},{"line_number":131,"context_line":"                handler\u003dPoolSequentialThreadingHandler(),"},{"line_number":132,"context_line":"            )"},{"line_number":133,"context_line":"            if self.tls_key:"},{"line_number":134,"context_line":"                args[\u0027use_ssl\u0027] \u003d True"},{"line_number":135,"context_line":"                args[\u0027keyfile\u0027] \u003d self.tls_key"},{"line_number":136,"context_line":"                args[\u0027certfile\u0027] \u003d self.tls_cert"}],"source_content_type":"text/x-python","patch_set":3,"id":"c58fe00d_360f40b9","line":133,"updated":"2022-05-23 17:35:23.000000000","message":"Nit (I expect this cleanup can go into zuul as well?) we require tls now and throw and error in __init__ if not provided. That means we don\u0027t need this check anymore.","commit_id":"10df93540fa49cf2134a46fa63440d1a905b3dfd"}],"nodepool/zk/zookeeper.py":[{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"27a9efe024ebb32c6ab5671a8d475d6f76d6b983","unresolved":true,"context_lines":[{"line_number":121,"context_line":"    def __init__(self):"},{"line_number":122,"context_line":"        self.id \u003d None"},{"line_number":123,"context_line":"        self.provider_name \u003d None"},{"line_number":124,"context_line":"        self.priority \u003d 100"},{"line_number":125,"context_line":"        self._supported_labels \u003d set()"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def __eq__(self, other):"}],"source_content_type":"text/x-python","patch_set":2,"id":"15efd1f4_15877666","line":124,"updated":"2022-05-23 14:30:17.000000000","message":"I guess this actually belongs to 841816","commit_id":"e67da965b05db6fe48d16c389c1001d270e12f01"}]}