)]}'
{"nodepool/launcher.py":[{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"343eb14178d802b9ebf12eabd2dd01d0408e2d9d","unresolved":true,"context_lines":[{"line_number":85,"context_line":"        pool \u003d self.getPoolConfig()"},{"line_number":86,"context_line":"        provider \u003d self.getProviderConfig()"},{"line_number":87,"context_line":"        if pool.priority is not None:"},{"line_number":88,"context_line":"            priority \u003d pool.priority"},{"line_number":89,"context_line":"        elif provider.priority is not None:"},{"line_number":90,"context_line":"            priority \u003d provider.priority"},{"line_number":91,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"660735cf_997ab623","line":88,"updated":"2022-05-23 15:09:22.000000000","message":"nit: if we return the priorities directly we could get rid of the elifs and elses which would make it slightly easier to read.","commit_id":"3245c6b9104a81d8752f16e1e2e602849883dd30"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"be1b2357ecbe1cb930b841dc319749c158be483c","unresolved":true,"context_lines":[{"line_number":208,"context_line":"            launcher_ids_with_higher_priority \u003d set("},{"line_number":209,"context_line":"                x.id for x in candidate_launchers"},{"line_number":210,"context_line":"                if x.priority \u003c priority and not x.paused"},{"line_number":211,"context_line":"            )"},{"line_number":212,"context_line":"            if launcher_ids_with_higher_priority:"},{"line_number":213,"context_line":"                log.debug(\"Yielding request to higher priority providers %s\","},{"line_number":214,"context_line":"                          launcher_ids_with_higher_priority)"}],"source_content_type":"text/x-python","patch_set":2,"id":"679dc778_e5e31150","line":211,"updated":"2022-05-23 20:18:29.000000000","message":"Does this need to filter out launchers that have already declined the request? We do similar above in the case where a specific provider has been requested, but if we haven\u0027t requested a specific provider we may not have filtered that yet.","commit_id":"3245c6b9104a81d8752f16e1e2e602849883dd30"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"e42a68e3f722fb0b38ed947c63360835e0e6745a","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            launcher_ids_with_higher_priority \u003d set("},{"line_number":209,"context_line":"                x.id for x in candidate_launchers"},{"line_number":210,"context_line":"                if x.priority \u003c priority and not x.paused"},{"line_number":211,"context_line":"            )"},{"line_number":212,"context_line":"            if launcher_ids_with_higher_priority:"},{"line_number":213,"context_line":"                log.debug(\"Yielding request to higher priority providers %s\","},{"line_number":214,"context_line":"                          launcher_ids_with_higher_priority)"}],"source_content_type":"text/x-python","patch_set":2,"id":"32b13ece_8a3bcf66","line":211,"updated":"2022-05-23 20:28:43.000000000","message":"Good idea.  I\u0027ll rework this to do that for both at the start.","commit_id":"3245c6b9104a81d8752f16e1e2e602849883dd30"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"902cf04049ca7fc97692c3c1a24791e4af54b04f","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                labels \u003d set()"},{"line_number":412,"context_line":"                for prov_cfg in self.nodepool.config.providers.values():"},{"line_number":413,"context_line":"                    labels.update(prov_cfg.getSupportedLabels())"},{"line_number":414,"context_line":"                self.component_info.supported_labels \u003d list(labels)"},{"line_number":415,"context_line":"                self.component_info.priority \u003d self.getPriority()"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"                self.updateProviderLimits("}],"source_content_type":"text/x-python","patch_set":2,"id":"d7a13ef7_1d6116b4","line":414,"updated":"2022-05-23 15:13:19.000000000","message":"Actually, I add that feature/check in this change; I added a Gerrit comment to point it out.","commit_id":"3245c6b9104a81d8752f16e1e2e602849883dd30"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"343eb14178d802b9ebf12eabd2dd01d0408e2d9d","unresolved":true,"context_lines":[{"line_number":411,"context_line":"                labels \u003d set()"},{"line_number":412,"context_line":"                for prov_cfg in self.nodepool.config.providers.values():"},{"line_number":413,"context_line":"                    labels.update(prov_cfg.getSupportedLabels())"},{"line_number":414,"context_line":"                self.component_info.supported_labels \u003d list(labels)"},{"line_number":415,"context_line":"                self.component_info.priority \u003d self.getPriority()"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"                self.updateProviderLimits("}],"source_content_type":"text/x-python","patch_set":2,"id":"190855fc_39461e07","line":414,"updated":"2022-05-23 15:09:22.000000000","message":"It doesn\u0027t look like the BaseComponent checks if this has been changed in __setattr__ (correct me if I\u0027m wrong). So we should either catch non-changes there or keep the if expression here to keep traffic on zk low.","commit_id":"3245c6b9104a81d8752f16e1e2e602849883dd30"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"93f960bb163b69b987fca6a8b64e32bf703a2638","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                labels \u003d set()"},{"line_number":412,"context_line":"                for prov_cfg in self.nodepool.config.providers.values():"},{"line_number":413,"context_line":"                    labels.update(prov_cfg.getSupportedLabels())"},{"line_number":414,"context_line":"                self.component_info.supported_labels \u003d list(labels)"},{"line_number":415,"context_line":"                self.component_info.priority \u003d self.getPriority()"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"                self.updateProviderLimits("}],"source_content_type":"text/x-python","patch_set":2,"id":"07e2eacf_a1751c69","line":414,"in_reply_to":"d7a13ef7_1d6116b4","updated":"2022-05-23 15:15:30.000000000","message":"whoops, I\u0027ve overlooked that","commit_id":"3245c6b9104a81d8752f16e1e2e602849883dd30"}],"nodepool/zk/components.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"902cf04049ca7fc97692c3c1a24791e4af54b04f","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            return super().__setattr__(name, value)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        if self.content[name] \u003d\u003d value:"},{"line_number":108,"context_line":"            return"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # Set the value in the local content dict"},{"line_number":111,"context_line":"        self.content[name] \u003d value"}],"source_content_type":"text/x-python","patch_set":2,"id":"a61d8f7f_babd374f","line":108,"updated":"2022-05-23 15:13:19.000000000","message":"We check whether the value is the same here and short-circuit.","commit_id":"3245c6b9104a81d8752f16e1e2e602849883dd30"}]}