)]}'
{"doc/source/aws.rst":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9b1b2ade57a89b9dcc627308ec79d71d5bfa6c19","unresolved":true,"context_lines":[{"line_number":394,"context_line":""},{"line_number":395,"context_line":"         The size of the root EBS volume, in GiB, for the image.  If"},{"line_number":396,"context_line":"         omitted, the volume size reported for the imported snapshot"},{"line_number":397,"context_line":"         will be used."},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"   .. attr:: pools"},{"line_number":400,"context_line":"      :type: list"}],"source_content_type":"text/x-rst","patch_set":2,"id":"954ab2cb_73427fe0","line":397,"updated":"2022-08-22 16:18:57.000000000","message":"In openstack land this is typically an attribute of the instance flavor then the image will growroot into the resulting disk. As a user that makes more sense to me since you might boot an image with different sizes of disk for different needs.\n\nIs it possible to express it that way in AWS too? Otherwise AWS users might need to upload the same image multiple times to get different sizes of disks.","commit_id":"89cda5a1ba5e7b2c7f33e13ffaf8bb057d94b358"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"a6d6c1c88d79f1faa4ed433a26aefc36e16b532e","unresolved":false,"context_lines":[{"line_number":394,"context_line":""},{"line_number":395,"context_line":"         The size of the root EBS volume, in GiB, for the image.  If"},{"line_number":396,"context_line":"         omitted, the volume size reported for the imported snapshot"},{"line_number":397,"context_line":"         will be used."},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"   .. attr:: pools"},{"line_number":400,"context_line":"      :type: list"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bae4e09a_a61acd8d","line":397,"in_reply_to":"954ab2cb_73427fe0","updated":"2022-08-22 16:31:00.000000000","message":"As best as I can tell, this is used as a sort of \"default\", and then when users launch an instance, they can specify a larger disk and growroot as you describe.  Nodepool lets us set that for labels: https://zuul-ci.org/docs/nodepool/latest/aws.html#attr-providers.[aws].pools.labels.volume-size\n\nSo given all that, I think a typical user would want to just ignore this value (and so nodepool will just use the image size) and then specify a value for the label.  But maybe if they always want to use a 200G disk with a given image, maybe they set it here and ignore the label attribute.","commit_id":"89cda5a1ba5e7b2c7f33e13ffaf8bb057d94b358"}],"nodepool/driver/aws/adapter.py":[{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"16a4c9681e24bb7cff63b1494c02ad9962594c37","unresolved":true,"context_lines":[{"line_number":444,"context_line":"                            \u0027DeleteOnTermination\u0027: True,"},{"line_number":445,"context_line":"                            \u0027SnapshotId\u0027: task["},{"line_number":446,"context_line":"                                \u0027SnapshotTaskDetail\u0027][\u0027SnapshotId\u0027],"},{"line_number":447,"context_line":"                            \u0027VolumeSize\u0027: provider_image.volume_size,"},{"line_number":448,"context_line":"                            \u0027VolumeType\u0027: provider_image.volume_type,"},{"line_number":449,"context_line":"                        },"},{"line_number":450,"context_line":"                    },"}],"source_content_type":"text/x-python","patch_set":1,"id":"8f1045e6_3eceb2b2","line":447,"updated":"2022-08-04 18:56:34.000000000","message":"Since the snapshot has a size, I think we should default to the snapshot size instead of 20gb. This would eliminate the need to specify a fixed size in the config for larger images.","commit_id":"21e4edcebd4b854efff3cb538f5902f08e294923"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"6d1f4aad5068be5fd5304c7f097b309bb0b69e5a","unresolved":false,"context_lines":[{"line_number":444,"context_line":"                            \u0027DeleteOnTermination\u0027: True,"},{"line_number":445,"context_line":"                            \u0027SnapshotId\u0027: task["},{"line_number":446,"context_line":"                                \u0027SnapshotTaskDetail\u0027][\u0027SnapshotId\u0027],"},{"line_number":447,"context_line":"                            \u0027VolumeSize\u0027: provider_image.volume_size,"},{"line_number":448,"context_line":"                            \u0027VolumeType\u0027: provider_image.volume_type,"},{"line_number":449,"context_line":"                        },"},{"line_number":450,"context_line":"                    },"}],"source_content_type":"text/x-python","patch_set":1,"id":"e625a5d0_9cbcfeac","line":447,"in_reply_to":"8f1045e6_3eceb2b2","updated":"2022-08-04 21:04:28.000000000","message":"Good call.","commit_id":"21e4edcebd4b854efff3cb538f5902f08e294923"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9b1b2ade57a89b9dcc627308ec79d71d5bfa6c19","unresolved":true,"context_lines":[{"line_number":451,"context_line":"                    },"},{"line_number":452,"context_line":"                ],"},{"line_number":453,"context_line":"                RootDeviceName\u003d\u0027/dev/sda1\u0027,"},{"line_number":454,"context_line":"                VirtualizationType\u003d\u0027hvm\u0027,"},{"line_number":455,"context_line":"                Name\u003dimage_name,"},{"line_number":456,"context_line":"            )"},{"line_number":457,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"29756354_9767eec0","line":454,"updated":"2022-08-22 16:18:57.000000000","message":"I think AWS has kvm virt flavors now too. I wonder if hardcoding this means the image can\u0027t be used with kvm? Maybe we need to make this configurable like the volume size and type?","commit_id":"89cda5a1ba5e7b2c7f33e13ffaf8bb057d94b358"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"621b9679861a122b870e5b2e2cfc51f3e5695f8e","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                    },"},{"line_number":452,"context_line":"                ],"},{"line_number":453,"context_line":"                RootDeviceName\u003d\u0027/dev/sda1\u0027,"},{"line_number":454,"context_line":"                VirtualizationType\u003d\u0027hvm\u0027,"},{"line_number":455,"context_line":"                Name\u003dimage_name,"},{"line_number":456,"context_line":"            )"},{"line_number":457,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"748787c7_0d935c3f","line":454,"in_reply_to":"0ba4bacd_27546e35","updated":"2022-08-22 16:35:28.000000000","message":"This link doesn\u0027t seem to be loading for me. I wonder how they annotate things for kvm? That said it is easy to make this configurable later if that becomes necessary for their non xen images.","commit_id":"89cda5a1ba5e7b2c7f33e13ffaf8bb057d94b358"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"a6d6c1c88d79f1faa4ed433a26aefc36e16b532e","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                    },"},{"line_number":452,"context_line":"                ],"},{"line_number":453,"context_line":"                RootDeviceName\u003d\u0027/dev/sda1\u0027,"},{"line_number":454,"context_line":"                VirtualizationType\u003d\u0027hvm\u0027,"},{"line_number":455,"context_line":"                Name\u003dimage_name,"},{"line_number":456,"context_line":"            )"},{"line_number":457,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"0ba4bacd_27546e35","line":454,"in_reply_to":"29756354_9767eec0","updated":"2022-08-22 16:31:00.000000000","message":"I think that is just hvm/pv: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/virtualization_types.html","commit_id":"89cda5a1ba5e7b2c7f33e13ffaf8bb057d94b358"}]}