)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31083,"name":"Benjamin Schanzel","email":"benjamin.schanzel@bmw.de","username":"benjamin.schanzel"},"change_message_id":"95d2a0afeb93716c88102b4df3703f994ff18252","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1dcdba65_c554749b","updated":"2022-10-21 14:11:16.000000000","message":"recheck","commit_id":"6c9c219eb0444648c38545ce60d38a30ffa5f165"},{"author":{"_account_id":31083,"name":"Benjamin Schanzel","email":"benjamin.schanzel@bmw.de","username":"benjamin.schanzel"},"change_message_id":"c0af2a739c5642e72251b80c3b27a88a1ceb5e96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6abbfd6a_59912839","updated":"2022-10-13 13:15:59.000000000","message":"recheck","commit_id":"6c9c219eb0444648c38545ce60d38a30ffa5f165"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"079671eb6353e50c712030bb00a470eb5aa8eacd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9d6c0c54_3d1bcf38","updated":"2022-10-21 12:55:45.000000000","message":"recheck","commit_id":"6c9c219eb0444648c38545ce60d38a30ffa5f165"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"1a1592e18545013d9ae195758119b142b6d9d788","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e97a38ec_ae76e633","updated":"2022-10-24 05:21:25.000000000","message":"recheck","commit_id":"6c9c219eb0444648c38545ce60d38a30ffa5f165"}],"doc/source/kubernetes.rst":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"9e75484a1949cd0516348d8c5ad0504b1094bf9a","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"         Only used by the"},{"line_number":142,"context_line":"         :value:`providers.[kubernetes].pools.labels.type.pod` label type;"},{"line_number":143,"context_line":"         specifies a default value for"},{"line_number":144,"context_line":"         :attr:`providers.[kubernetes].pools.labels.storage` for all labels of"},{"line_number":145,"context_line":"         this pool that do not set their own value."},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"00197bca_4c0b30f3","line":143,"updated":"2022-10-12 22:12:52.000000000","message":"I agree with this.","commit_id":"67dabf5461d464089e2b6c49b5a1eba006dcafb8"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"5d62dffd0b1619bb9b30244e6f484df48d43361b","unresolved":true,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"         Only used by the"},{"line_number":142,"context_line":"         :value:`providers.[kubernetes].pools.labels.type.pod` label type;"},{"line_number":143,"context_line":"         specifies a default value for"},{"line_number":144,"context_line":"         :attr:`providers.[kubernetes].pools.labels.storage` for all labels of"},{"line_number":145,"context_line":"         this pool that do not set their own value."},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"2ae838af_a223ff8e","line":143,"updated":"2022-08-15 13:04:27.000000000","message":"I think we should also mention here that the unit is MB.","commit_id":"67dabf5461d464089e2b6c49b5a1eba006dcafb8"}],"nodepool/driver/kubernetes/provider.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"9e75484a1949cd0516348d8c5ad0504b1094bf9a","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                if label.memory:"},{"line_number":278,"context_line":"                    rbody[\u0027memory\u0027] \u003d \u0027%dMi\u0027 % int(label.memory)"},{"line_number":279,"context_line":"                if label.storage:"},{"line_number":280,"context_line":"                    rbody[\u0027ephemeral-storage\u0027] \u003d \u0027%dM\u0027 % int(label.storage)"},{"line_number":281,"context_line":"                container_body[\u0027resources\u0027][rtype] \u003d rbody"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        spec_body \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"1dd40bee_7be99520","line":280,"updated":"2022-10-12 22:12:52.000000000","message":"I just left a comment on another change advocating keeping memory specified as MiB since memory is customarily measured in MiB, and by that logic, this should be MB since that\u0027s how storage is customarily measured.\n\nIn retrospect, perhaps neither of these should be integers and instead should be strings.  Maybe we should fix that when we move it to Zuul.","commit_id":"67dabf5461d464089e2b6c49b5a1eba006dcafb8"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"5d62dffd0b1619bb9b30244e6f484df48d43361b","unresolved":true,"context_lines":[{"line_number":277,"context_line":"                if label.memory:"},{"line_number":278,"context_line":"                    rbody[\u0027memory\u0027] \u003d \u0027%dMi\u0027 % int(label.memory)"},{"line_number":279,"context_line":"                if label.storage:"},{"line_number":280,"context_line":"                    rbody[\u0027ephemeral-storage\u0027] \u003d \u0027%dM\u0027 % int(label.storage)"},{"line_number":281,"context_line":"                container_body[\u0027resources\u0027][rtype] \u003d rbody"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        spec_body \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"acfedc99_9673c198","line":280,"updated":"2022-08-15 13:04:27.000000000","message":"I think we should be consistent here and also use MiB as we do for the memory limits.","commit_id":"67dabf5461d464089e2b6c49b5a1eba006dcafb8"},{"author":{"_account_id":31083,"name":"Benjamin Schanzel","email":"benjamin.schanzel@bmw.de","username":"benjamin.schanzel"},"change_message_id":"4929aa1805a0581263d971fcf18cfd403b60967e","unresolved":true,"context_lines":[{"line_number":277,"context_line":"                if label.memory:"},{"line_number":278,"context_line":"                    rbody[\u0027memory\u0027] \u003d \u0027%dMi\u0027 % int(label.memory)"},{"line_number":279,"context_line":"                if label.storage:"},{"line_number":280,"context_line":"                    rbody[\u0027ephemeral-storage\u0027] \u003d \u0027%dM\u0027 % int(label.storage)"},{"line_number":281,"context_line":"                container_body[\u0027resources\u0027][rtype] \u003d rbody"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        spec_body \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"b04cf6a2_3e2ecd23","line":280,"in_reply_to":"1dd40bee_7be99520","updated":"2022-10-14 07:41:15.000000000","message":"As an intermediate step, we could also try to cast it to int, treating it as MiB (memory) or MB (storage), and as a fallback just pass it as a string, allowing the user to specify the unit of its choice. So with a deprecation notice we can eventually get rid of the (somewhat inconsistent) int interpretation and only support explicit units.","commit_id":"67dabf5461d464089e2b6c49b5a1eba006dcafb8"}]}