)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"57e2b9f890ae32272f98f9ec7bec61f6af0cf4fc","unresolved":false,"context_lines":[{"line_number":19,"context_line":"are needed.  First, we now calculate quota used by Nodepool nodes using"},{"line_number":20,"context_line":"the resources attribute of the node rather than asking the driver what"},{"line_number":21,"context_line":"the quota values are for the node\u0027s label (since a node\u0027s label may"},{"line_number":22,"context_line":"no longer correspond 1:1 to an instance type).  Second, we ensure that"},{"line_number":23,"context_line":"all quota-supporting drivers store resource information on the node to"},{"line_number":24,"context_line":"support this change."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a051a58_faab219b","line":22,"updated":"2022-08-25 20:43:09.000000000","message":"I agree that\u0027s worth considering.  I\u0027ve marked this change WIP and moved it to the end of the stack until we decide on that.","commit_id":"85587993bbfb8b77fb8d63c95095ce77516ef419"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8dc693c0abc409a811089ae323c4fcf65b25c610","unresolved":true,"context_lines":[{"line_number":19,"context_line":"are needed.  First, we now calculate quota used by Nodepool nodes using"},{"line_number":20,"context_line":"the resources attribute of the node rather than asking the driver what"},{"line_number":21,"context_line":"the quota values are for the node\u0027s label (since a node\u0027s label may"},{"line_number":22,"context_line":"no longer correspond 1:1 to an instance type).  Second, we ensure that"},{"line_number":23,"context_line":"all quota-supporting drivers store resource information on the node to"},{"line_number":24,"context_line":"support this change."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"21c793c9_09ce7d09","line":22,"updated":"2022-08-25 20:10:02.000000000","message":"I haven\u0027t been able to fully review this change yet, but this parenthetical concerns me. I think it is helpful that nodepool labels provide a consistent result (at least within a cloud provider). OpenDev for example has gone through a lot of effort to try and normalize this as much as possible and where not possible add new labels instead. The reason for this is that it is confusing to users when they ask for something and get what they perceive to be vastly different.\n\nWould it be better to address this by specifying in the job itself that the job can be run on one of multiple labels? Then you can have different labels for the different valid types? This was it is more explicit to the user that they are accepting variance.","commit_id":"85587993bbfb8b77fb8d63c95095ce77516ef419"}]}