)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"390f72b2c4b458d98f1ec4e435f473fde3b793a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d671a83c_042e59a4","updated":"2022-09-19 20:42:54.000000000","message":"lgtm apart from the debug leftover","commit_id":"efd57a4df99afcd70eaa0fa754c5ab34ddac10e2"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"cec6d165addbf5df429fc72da177f2f86547e385","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7d76d037_fc7859c6","updated":"2022-10-26 20:06:43.000000000","message":"Should the pool label entry ensure its iops and throughput values are greater than or equal to the disk image specifications? I can go either way on this as it may be valid to intentionally reduce the resources on a specific label but reuse the same image otherwise.","commit_id":"4ea824cfa96eb50d96e23241673785c46d870f61"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"59b1a7dcc11dc2fb48445fd9e5a81391c347886b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"57c5ed82_69257c98","in_reply_to":"7c515414_bc1f0c4c","updated":"2022-10-26 20:25:55.000000000","message":"That works for me. I\u0027ll go ahead and approve this with the idea that we can improve it later if necessary.","commit_id":"4ea824cfa96eb50d96e23241673785c46d870f61"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"f932fd5b9fe7ff19edf7998b344ad980a167ef3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7c515414_bc1f0c4c","in_reply_to":"7d76d037_fc7859c6","updated":"2022-10-26 20:23:57.000000000","message":"That\u0027s a good question, and I don\u0027t know AWS\u0027s behavior right now (I don\u0027t see it documented).  If AWS permits it, we certainly should, so I think it\u0027s reasonable to leave this as permissive now and make it more restrictive later if we find we\u0027re able.","commit_id":"4ea824cfa96eb50d96e23241673785c46d870f61"}],"doc/source/aws.rst":[{"author":{"_account_id":28088,"name":"Benedikt Löffler","email":"benedikt.loeffler@bmw.de","username":"bloeffler"},"change_message_id":"7c3761881e9e8701ef98fd3f958f2a8d78c699d2","unresolved":true,"context_lines":[{"line_number":422,"context_line":"      .. attr:: throughput"},{"line_number":423,"context_line":"         :type: int"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"         The troughput of the volume in MiB/s.  This is only valid for"},{"line_number":426,"context_line":"         ``gp3`` volumes."},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"      .. attr:: tags"}],"source_content_type":"text/x-rst","patch_set":2,"id":"a5ab7ee4_bb96f034","line":425,"updated":"2022-10-14 07:40:14.000000000","message":"typo: throughput","commit_id":"e23456201b8f4993dc0a3309a785d05bd36e81ac"},{"author":{"_account_id":28088,"name":"Benedikt Löffler","email":"benedikt.loeffler@bmw.de","username":"bloeffler"},"change_message_id":"7c3761881e9e8701ef98fd3f958f2a8d78c699d2","unresolved":true,"context_lines":[{"line_number":651,"context_line":"           .. attr:: throughput"},{"line_number":652,"context_line":"              :type: int"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"              The troughput of the volume in MiB/s.  This is only"},{"line_number":655,"context_line":"              valid for ``gp3`` volumes."},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"           .. attr:: userdata"}],"source_content_type":"text/x-rst","patch_set":2,"id":"be257cb7_fc5c2f7d","line":654,"range":{"start_line":654,"start_character":18,"end_line":654,"end_character":27},"updated":"2022-10-14 07:40:14.000000000","message":"typo: throughput","commit_id":"e23456201b8f4993dc0a3309a785d05bd36e81ac"}],"nodepool/driver/aws/adapter.py":[{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"390f72b2c4b458d98f1ec4e435f473fde3b793a0","unresolved":true,"context_lines":[{"line_number":832,"context_line":"                args[\u0027BlockDeviceMappings\u0027] \u003d [mapping]"},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"        with self.rate_limiter(log.debug, \"Created instance\"):"},{"line_number":835,"context_line":"            print(args)"},{"line_number":836,"context_line":"            log.debug(f\"Creating VM {hostname}\")"},{"line_number":837,"context_line":"            instances \u003d self.ec2.create_instances(**args)"},{"line_number":838,"context_line":"            log.debug(f\"Created VM {hostname} as instance {instances[0].id}\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"67d73c5e_d8e80ec0","line":835,"updated":"2022-09-19 20:42:54.000000000","message":"Debugging leftover","commit_id":"efd57a4df99afcd70eaa0fa754c5ab34ddac10e2"}]}