)]}'
{"nodepool/driver/openstack/adapter.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"adb973357b9a19807b85cb3fdc29f3e18b95c882","unresolved":true,"context_lines":[{"line_number":415,"context_line":"            yield OpenStackInstance(self.provider, server, quota)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def getQuotaLimits(self):"},{"line_number":418,"context_line":"        with Timer(self.log, \u0027API call get_compute_limits\u0027):"},{"line_number":419,"context_line":"            limits \u003d self._client.get_compute_limits()"},{"line_number":420,"context_line":"        return QuotaInformation.construct_from_limits(limits)"},{"line_number":421,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"533a92af_62d0fbce","line":418,"updated":"2023-01-20 02:04:17.000000000","message":"Is this different to statsd stats.timers.nodepool.task.\u003cprovider\u003e.compute.limits.200?  I did think the idea was that we setup the statsd prefixes in the clouds.yaml sufficiently that the client code could log all this.","commit_id":"34c3dfd6e875917a97349915cadc97d8fba0a214"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"162eb98d0bfa4cafece5d451987bba8cd0363aa0","unresolved":false,"context_lines":[{"line_number":415,"context_line":"            yield OpenStackInstance(self.provider, server, quota)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def getQuotaLimits(self):"},{"line_number":418,"context_line":"        with Timer(self.log, \u0027API call get_compute_limits\u0027):"},{"line_number":419,"context_line":"            limits \u003d self._client.get_compute_limits()"},{"line_number":420,"context_line":"        return QuotaInformation.construct_from_limits(limits)"},{"line_number":421,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"20236314_83e1a1be","line":418,"in_reply_to":"533a92af_62d0fbce","updated":"2023-01-20 15:19:18.000000000","message":"Cool thanks for double checking.  I thought maybe at some point there was a logging option, but I couldn\u0027t find it.  So much has changed around that over time.","commit_id":"34c3dfd6e875917a97349915cadc97d8fba0a214"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"162eb98d0bfa4cafece5d451987bba8cd0363aa0","unresolved":false,"context_lines":[{"line_number":415,"context_line":"            yield OpenStackInstance(self.provider, server, quota)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def getQuotaLimits(self):"},{"line_number":418,"context_line":"        with Timer(self.log, \u0027API call get_compute_limits\u0027):"},{"line_number":419,"context_line":"            limits \u003d self._client.get_compute_limits()"},{"line_number":420,"context_line":"        return QuotaInformation.construct_from_limits(limits)"},{"line_number":421,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bea1ffcb_1e16be1c","line":418,"in_reply_to":"533a92af_62d0fbce","updated":"2023-01-20 15:19:18.000000000","message":"Cool thanks for double checking.  I thought maybe at some point there was a logging option, but I couldn\u0027t find it.  So much has changed around that over time.","commit_id":"34c3dfd6e875917a97349915cadc97d8fba0a214"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"819be62e8405d709c993214dd556d9f4cd0001ee","unresolved":false,"context_lines":[{"line_number":415,"context_line":"            yield OpenStackInstance(self.provider, server, quota)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def getQuotaLimits(self):"},{"line_number":418,"context_line":"        with Timer(self.log, \u0027API call get_compute_limits\u0027):"},{"line_number":419,"context_line":"            limits \u003d self._client.get_compute_limits()"},{"line_number":420,"context_line":"        return QuotaInformation.construct_from_limits(limits)"},{"line_number":421,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f4c66915_20a52e5d","line":418,"in_reply_to":"533a92af_62d0fbce","updated":"2023-01-20 02:14:29.000000000","message":"I need to see this in log files (as in, in sequence with other actions) to debug the performance of the new statemachine driver (I\u0027m looking for procedural bottlenecks in the code).  I looked for it, but I don\u0027t see this info currently being logged; can the sdk be convinced to log it?\n\nIf that\u0027s the case, I think it would be sufficient for most of these.","commit_id":"34c3dfd6e875917a97349915cadc97d8fba0a214"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8eda8252aca66e7ea2b27cedac40063f3c2a9ac9","unresolved":true,"context_lines":[{"line_number":415,"context_line":"            yield OpenStackInstance(self.provider, server, quota)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def getQuotaLimits(self):"},{"line_number":418,"context_line":"        with Timer(self.log, \u0027API call get_compute_limits\u0027):"},{"line_number":419,"context_line":"            limits \u003d self._client.get_compute_limits()"},{"line_number":420,"context_line":"        return QuotaInformation.construct_from_limits(limits)"},{"line_number":421,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"08ee87f6_6c113cf1","line":418,"in_reply_to":"f4c66915_20a52e5d","updated":"2023-01-20 02:56:08.000000000","message":"ahh, yes it won\u0027t be in sequence, more a general idea of the actions\n\n\u003e can the sdk be convinced to log it?\n\nI guess this is done at\n\nhttps://opendev.org/openstack/openstacksdk/src/branch/master/openstack/proxy.py#L307\n\nwhere the proxy chooses between statsd, influxdb and prometheus.  It does feel like a \"log\" option there to also output timing data via self.log might be possible, but I can\u0027t see it there...","commit_id":"34c3dfd6e875917a97349915cadc97d8fba0a214"}],"nodepool/nodeutils.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"321521e6ba13fed9c36dccbdcff0ca427bf2b043","unresolved":true,"context_lines":[{"line_number":176,"context_line":"        self.msg \u003d msg"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def __enter__(self):"},{"line_number":179,"context_line":"        self.start \u003d time.monotonic()"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def __exit__(self, type, value, traceback):"},{"line_number":182,"context_line":"        delta \u003d time.monotonic() - self.start"}],"source_content_type":"text/x-python","patch_set":3,"id":"60d3f411_175f450d","line":179,"updated":"2023-01-29 21:18:35.000000000","message":"perhaps perf_counter() is a better fit for this call?","commit_id":"80d83da73fb3d7980445edb8e187800fb3bd719b"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"7a706cd8edc36df2831fff739725515d8d32c5d4","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        self.msg \u003d msg"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def __enter__(self):"},{"line_number":179,"context_line":"        self.start \u003d time.monotonic()"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def __exit__(self, type, value, traceback):"},{"line_number":182,"context_line":"        delta \u003d time.monotonic() - self.start"}],"source_content_type":"text/x-python","patch_set":3,"id":"a288a859_20031c08","line":179,"in_reply_to":"60d3f411_175f450d","updated":"2023-02-04 15:32:01.000000000","message":"Yep","commit_id":"80d83da73fb3d7980445edb8e187800fb3bd719b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"321521e6ba13fed9c36dccbdcff0ca427bf2b043","unresolved":true,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def __exit__(self, type, value, traceback):"},{"line_number":182,"context_line":"        delta \u003d time.monotonic() - self.start"},{"line_number":183,"context_line":"        self.log.debug(f\u0027{self.msg} in {delta}\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"aaeba982_b0d7bf14","line":183,"updated":"2023-01-29 21:18:35.000000000","message":"I do get that the point is to specifically see the cost of a given call in context, but I wonder if this would be useful to have a key and send this into statsd for aggregate data too?","commit_id":"80d83da73fb3d7980445edb8e187800fb3bd719b"}]}