)]}'
{"nodepool/tests/unit/test_webapp.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"58137fbc142fc48f1fad4165e87cda9135ee4719","unresolved":true,"context_lines":[{"line_number":153,"context_line":"    def test_image_status_json(self):"},{"line_number":154,"context_line":"        configfile \u003d self.setup_config(\"node.yaml\")"},{"line_number":155,"context_line":"        pool \u003d self.useNodepool(configfile, watermark_sleep\u003d1)"},{"line_number":156,"context_line":"        builder \u003d self.useBuilder(configfile)"},{"line_number":157,"context_line":"        # Make sure we have enough time to test for the build request"},{"line_number":158,"context_line":"        # before it\u0027s processed by the build worker."},{"line_number":159,"context_line":"        for worker in builder._build_workers:"}],"source_content_type":"text/x-python","patch_set":1,"id":"36ffeacd_9a60960c","line":156,"updated":"2023-03-10 22:13:17.000000000","message":"Why is this test, and the ones below here, fine with starting the builder before the webapp? Seems they follow the same basic structure as above which is start the two services then make web requests to inspect image state?","commit_id":"d7b5161ae675ad0e8ec117e5e889213fc257ca90"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"a07f48a379fa6434abc743d469a173f70ec384cf","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    def test_image_status_json(self):"},{"line_number":154,"context_line":"        configfile \u003d self.setup_config(\"node.yaml\")"},{"line_number":155,"context_line":"        pool \u003d self.useNodepool(configfile, watermark_sleep\u003d1)"},{"line_number":156,"context_line":"        builder \u003d self.useBuilder(configfile)"},{"line_number":157,"context_line":"        # Make sure we have enough time to test for the build request"},{"line_number":158,"context_line":"        # before it\u0027s processed by the build worker."},{"line_number":159,"context_line":"        for worker in builder._build_workers:"}],"source_content_type":"text/x-python","patch_set":1,"id":"217d1d3c_1bc0d997","line":156,"in_reply_to":"36ffeacd_9a60960c","updated":"2023-03-10 22:24:20.000000000","message":"I can do this one too.  It has a slightly different startup sequence, but it\u0027ll work too.\n\nI don\u0027t think it\u0027s important to update the others -- we technically only need one test to cover this particular startup sequence.","commit_id":"d7b5161ae675ad0e8ec117e5e889213fc257ca90"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7b128a4eb44fbe76af9cf5c8f739351d836efd1c","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    def test_image_status_json(self):"},{"line_number":154,"context_line":"        configfile \u003d self.setup_config(\"node.yaml\")"},{"line_number":155,"context_line":"        pool \u003d self.useNodepool(configfile, watermark_sleep\u003d1)"},{"line_number":156,"context_line":"        builder \u003d self.useBuilder(configfile)"},{"line_number":157,"context_line":"        # Make sure we have enough time to test for the build request"},{"line_number":158,"context_line":"        # before it\u0027s processed by the build worker."},{"line_number":159,"context_line":"        for worker in builder._build_workers:"}],"source_content_type":"text/x-python","patch_set":1,"id":"988447a7_92d22f1c","line":156,"in_reply_to":"36ffeacd_9a60960c","updated":"2023-03-10 22:24:37.000000000","message":"I misunderstood this change when I wrote the prior comment. I had thought the bug was in the test service startup ordering. There was an issue there, but that issue prevented coverage of an issue in the actual application. THis allowed broken application code to land as it was not tripped due to the race in the tests above.\n\nTo address this the buggy application is fixed (that is the update to the other file) and the tests above are updated to cover that code properly. We don\u0027t need to update this test because ~4 tests above is sufficient to cover the case we are concerned about.","commit_id":"d7b5161ae675ad0e8ec117e5e889213fc257ca90"}]}