)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33134,"name":"Dong Zhang","email":"dong.zhang@bmw.de","username":"dongzhang"},"change_message_id":"1868f9628f06aedcb7266e64655b919d1b0a16f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2909b220_6623d547","updated":"2023-03-22 09:25:39.000000000","message":"recheck","commit_id":"f5aee06ff203143510be4a0099b1e494cd2af0aa"},{"author":{"_account_id":33134,"name":"Dong Zhang","email":"dong.zhang@bmw.de","username":"dongzhang"},"change_message_id":"ac1dd80469d1d3e01dd0df83aa7a8848712989bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6f8a242f_79d1dcf2","updated":"2023-03-22 09:28:13.000000000","message":"recheck","commit_id":"f5aee06ff203143510be4a0099b1e494cd2af0aa"},{"author":{"_account_id":35619,"name":"Christian von Schultz","display_name":"Christian von Schultz","email":"christian+u1@embedl.com","username":"von"},"change_message_id":"7fe85f726013f8d09b569321d644337bfaa5a0f2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2ae52850_d89fdf0a","updated":"2023-03-29 12:33:17.000000000","message":"I have a similar patch at https://review.opendev.org/c/zuul/nodepool/+/875050","commit_id":"4a1fbca27fb7dab5c4413a5d0cfa3f32d746e9f0"}],"nodepool/driver/aws/adapter.py":[{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"66100d0a5d1543337cc43e127ba3ddd7c11d1a16","unresolved":true,"context_lines":[{"line_number":362,"context_line":"                \u0027terminated\u0027, \u0027shutting-down\u0027):"},{"line_number":363,"context_line":"                continue"},{"line_number":364,"context_line":"            quota \u003d self._getQuotaForInstanceType(instance.instance_type)"},{"line_number":365,"context_line":"            yield AwsInstance(self.provider, instance, quota)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    def getQuotaLimits(self):"},{"line_number":368,"context_line":"        # Get the instance types that this provider handles"}],"source_content_type":"text/x-python","patch_set":2,"id":"de5491aa_b2507be3","line":365,"updated":"2023-03-22 11:09:18.000000000","message":"I\u0027m wondering if instead of filtering out all \"shutting-down\" instances we might want to catch exceptions when creating the `AwsInstance` here. This way the calculated quota might not get skewed too much. E.g. like\n\n    try:\n        yield AwsInstance(self.proivider, instance, quota)\n    except Exception:\n        self.log.exception(\"...\")\n        \nI guess the main question here is if shutting down instances should still be counted for the quota or not. Don\u0027t have a strong opinion on that.","commit_id":"f5aee06ff203143510be4a0099b1e494cd2af0aa"},{"author":{"_account_id":33134,"name":"Dong Zhang","email":"dong.zhang@bmw.de","username":"dongzhang"},"change_message_id":"e8fb310af12cc9ea55d3e2dc7628fb1907bc3aaa","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                \u0027terminated\u0027, \u0027shutting-down\u0027):"},{"line_number":363,"context_line":"                continue"},{"line_number":364,"context_line":"            quota \u003d self._getQuotaForInstanceType(instance.instance_type)"},{"line_number":365,"context_line":"            yield AwsInstance(self.provider, instance, quota)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    def getQuotaLimits(self):"},{"line_number":368,"context_line":"        # Get the instance types that this provider handles"}],"source_content_type":"text/x-python","patch_set":2,"id":"9c0389dc_a37621f2","line":365,"in_reply_to":"de5491aa_b2507be3","updated":"2023-03-29 11:00:21.000000000","message":"I updated a new patch to avoid the exception in AwsInstance\u0027s constructor instead.","commit_id":"f5aee06ff203143510be4a0099b1e494cd2af0aa"}]}