)]}'
{"nodepool/zk/zookeeper.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"78d64f3f447b3c852e83b88e4d54a95a934c7b3f","unresolved":true,"context_lines":[{"line_number":2543,"context_line":"        self.kazoo_client.set(path, node.serialize())"},{"line_number":2544,"context_line":"        self.deleteRawNode(node.id)"},{"line_number":2545,"context_line":"        if node._thread_lock.locked():"},{"line_number":2546,"context_line":"            node._thread_lock.release()"},{"line_number":2547,"context_line":""},{"line_number":2548,"context_line":"    def getReadyNodesOfTypes(self, labels, cached\u003dTrue):"},{"line_number":2549,"context_line":"        \u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3e71869c_3143c758","line":2546,"updated":"2023-04-21 15:36:50.000000000","message":"Do we care about breaking convention accessing the private attribute on node from zookeeper methods?","commit_id":"e10cd2eb0b124cde4de405fdec758684f1441659"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"566461f0a5f7fa99dff5cf44ac153f28133cdfe2","unresolved":false,"context_lines":[{"line_number":2543,"context_line":"        self.kazoo_client.set(path, node.serialize())"},{"line_number":2544,"context_line":"        self.deleteRawNode(node.id)"},{"line_number":2545,"context_line":"        if node._thread_lock.locked():"},{"line_number":2546,"context_line":"            node._thread_lock.release()"},{"line_number":2547,"context_line":""},{"line_number":2548,"context_line":"    def getReadyNodesOfTypes(self, labels, cached\u003dTrue):"},{"line_number":2549,"context_line":"        \u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"0987e17d_42bf7295","line":2546,"in_reply_to":"3e71869c_3143c758","updated":"2023-04-21 15:39:43.000000000","message":"This class is the only class that accesses this attribute, so it\u0027s in convention.\n\nThe Node class is defined in this file and is very closely tied with the ZooKeeper class; if this were java, this would be a protected attribute in the same package.","commit_id":"e10cd2eb0b124cde4de405fdec758684f1441659"}]}